On 19/02/2013 12:06, Laszlo Hornyak wrote:
Hi,
I agree with that.
for the - messages this in my opinion would be both more clear and friendly:
-1: In my opinion it needs work.
how about
"-1: Please review my comments"
-2: I disagree.
"-2: Please reconsider"
- Original Message
I like most of these proposals. It'll make gerrit friendlier :-)
- Original Message -
> From: "Itamar Heim"
> To: "Laszlo Hornyak"
> Cc: engine-devel@ovirt.org
> Sent: Wednesday, February 20, 2013 9:32:53 AM
> Subject: Re: [Engine-devel] Changing Gerrit -1 message
>
> On 19/02/2013 12:0
On 02/18/2013 05:09 AM, Kanagaraj Mayilsamy wrote:
>
>
> - Original Message -
>> From: "Vojtech Szocs"
>> To: "Daniel Erez"
>> Cc: a...@ovirt.org, engine-devel@ovirt.org
>> Sent: Saturday, February 16, 2013 1:07:56 AM
>> Subject: Re: [Engine-devel] REST API calls from the GUI
>>
>> Hi D
- Original Message -
> From: "Michael Pasternak"
> To: "Kanagaraj Mayilsamy"
> Cc: "Vojtech Szocs" , engine-devel@ovirt.org,
> a...@ovirt.org
> Sent: Wednesday, February 20, 2013 5:55:50 PM
> Subject: Re: [Engine-devel] REST API calls from the GUI
>
> On 02/18/2013 05:09 AM, Kanagaraj
On 02/14/2013 11:20 AM, Doron Fediuck wrote:
>
>
> - Original Message -
>> From: "Michael Pasternak"
>> To: "Libor Spevak"
>> Cc: engine-devel@ovirt.org, a...@ovirt.org
>> Sent: Wednesday, February 13, 2013 12:55:36 PM
>> Subject: Re: [Engine-devel] REST API calls from the GUI
>>
>>
>>
On 02/20/2013 02:45 PM, Kanagaraj Mayilsamy wrote:
>
> - Original Message -
>> > From: "Michael Pasternak"
>> > To: "Kanagaraj Mayilsamy"
>> > Cc: "Vojtech Szocs" , engine-devel@ovirt.org,
>> > a...@ovirt.org
>> > Sent: Wednesday, February 20, 2013 5:55:50 PM
>> > Subject: Re: [Engine-d
thoughts on how to trim these?
(in openstack gerrit they auto-abandon patches with no activity for a
couple of weeks - author can revive them back when they are relevant)
preferred_email | count
--+--
mkole...@redhat.com | 17
rgo...@redhat.com
- Original Message -
> thoughts on how to trim these?
> (in openstack gerrit they auto-abandon patches with no activity for a
> couple of weeks - author can revive them back when they are relevant)
>
> preferred_email | count
> --+--
> mkole...@r
Hi,
Why not sending this as a reminder?
But sending also the gerrit links
For example, I assume mkolesni sent an engine patch, maybe I as someone who
also sends patches to engine can review (even if not ACK, share some thoughts?)
Thanks,
Yair
- Original Message -
> From: "Itamar Heim"
On 20/02/2013 18:02, Mike Kolesnik wrote:
- Original Message -
thoughts on how to trim these?
(in openstack gerrit they auto-abandon patches with no activity for a
couple of weeks - author can revive them back when they are relevant)
preferred_email | count
-
On 20/02/2013 18:04, Yair Zaslavsky wrote:
Hi,
Why not sending this as a reminder?
But sending also the gerrit links
For example, I assume mkolesni sent an engine patch, maybe I as someone who
also sends patches to engine can review (even if not ACK, share some thoughts?)
if you want to help
- Original Message -
> From: "Itamar Heim"
> To: "Yair Zaslavsky"
> Cc: "engine-devel"
> Sent: Wednesday, February 20, 2013 6:17:43 PM
> Subject: Re: [Engine-devel] Engine - top 10 with patches with no activity for
> more than 30 days
>
> On 20/02/2013 18:04, Yair Zaslavsky wrote:
>
I tend to agree as well regarding the -1 message, although I think that
since -2 blocks your change from, merging it, it should still be strict.
Perhaps we could consider adding one more negative value?
Regards,
Maor
On 02/20/2013 11:59 AM, Antoni Segura Puimedon wrote:
> I like most of these pro
- Original Message -
> From: "Maor Lipchuk"
> To: engine-devel@ovirt.org
> Sent: Thursday, February 21, 2013 12:25:57 AM
> Subject: Re: [Engine-devel] Changing Gerrit -1 message
>
> I tend to agree as well regarding the -1 message, although I think
> that
> since -2 blocks your change f
14 matches
Mail list logo
