[Engine-devel] clean testable code

2013-08-11 Thread Giuseppe Vallarelli
Talking with my teammates I've noticed that there is some confusion related to what testing means and in general how tests can improve the quality of the codebase by favouring the development of components that are of higher quality - unluckily it doesn't favour hair regrowing. Tests are also

Re: [Engine-devel] Proposal for new commit msg design for engine commits

2013-07-11 Thread Giuseppe Vallarelli
- Original Message - | From: Eyal Edri ee...@redhat.com | To: Fabian Deutsch fabi...@redhat.com | Cc: engine-devel engine-devel@ovirt.org, infra in...@ovirt.org | Sent: Thursday, July 11, 2013 10:57:31 AM | Subject: Re: [Engine-devel] Proposal for new commit msg design for engine commits

Re: [Engine-devel] Proposal for new commit msg design for engine commits

2013-07-09 Thread Giuseppe Vallarelli
Hi Eyal, I really appreciate your concern and desire to streamline our CI infrastructure, but I'm afraid there might be some issues worth of discussing. If I've understood correctly a developer should add some kind of tags to idenfity the impact of the patch and so the subsets of tests (impact

Re: [Engine-devel] VNic QoS measure units and attributes.

2013-06-25 Thread Giuseppe Vallarelli
- Original Message - | From: Ofri Masad oma...@redhat.com | To: Giuseppe Vallarelli gvall...@redhat.com | Cc: Livnat Peer lp...@redhat.com, engine-devel@ovirt.org | Sent: Tuesday, June 25, 2013 8:19:30 AM | Subject: Re: [Engine-devel] VNic QoS measure units and attributes. | | Hi Giuseppe

[Engine-devel] VNic QoS measure units and attributes.

2013-06-24 Thread Giuseppe Vallarelli
Hi Ofri, I've been reading your design page for this feature [1] and and I've found out that there's a possible unit of measure mismatch regarding: Average, Burst and Peak, clearly makes sense to use Mbps on the gui but I wonder if you're aware that the vdsm api expects respectivly: kB/sec, kB

Re: [Engine-devel] VNic QoS measure units and attributes.

2013-06-24 Thread Giuseppe Vallarelli
- Original Message - | From: Livnat Peer lp...@redhat.com | To: Giuseppe Vallarelli gvall...@redhat.com | Cc: engine-devel@ovirt.org | Sent: Monday, June 24, 2013 6:31:43 PM | Subject: Re: [Engine-devel] VNic QoS measure units and attributes. | | On 06/24/2013 03:07 PM, Giuseppe

Re: [Engine-devel] Add traffic shaping parameters for a network interface.

2013-06-12 Thread Giuseppe Vallarelli
- Original Message - | From: Doron Fediuck dfedi...@redhat.com | To: Giuseppe Vallarelli gvall...@redhat.com | Cc: Livnat Peer lp...@redhat.com, engine-devel@ovirt.org, Dan Kenigsberg dan...@redhat.com | Sent: Wednesday, June 12, 2013 9:05:35 AM | Subject: Re: [Engine-devel] Add traffic

Re: [Engine-devel] Add traffic shaping parameters for a network interface.

2013-06-12 Thread Giuseppe Vallarelli
- Original Message - | From: Giuseppe Vallarelli gvall...@redhat.com | To: Doron Fediuck dfedi...@redhat.com | Cc: engine-devel@ovirt.org | Sent: Wednesday, June 12, 2013 9:28:19 AM | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network interface

Re: [Engine-devel] Add traffic shaping parameters for a network interface.

2013-06-11 Thread Giuseppe Vallarelli
Related to QoS parameters reporting to the engine. Looks like they're already available, I tried to use vdsClient with list verb and I've got the devices list where a 'specParams' is defined (it's empty because I didn't try it with my last patch). devices = [... {'nicModel': 'pv', 'macAddr':

[Engine-devel] Add traffic shaping parameters for a network interface.

2013-06-10 Thread Giuseppe Vallarelli
Hi Guys, I've recently submitted a patch to support traffic shaping for a network interface (http://gerrit.ovirt.org/#/c/15445/). This work is needed in order to support http://www.ovirt.org/Features/Network_QoS . Given: 'specParams': {'inbound': {'average': '1000', 'peak': '5000', 'burst':

Re: [Engine-devel] Add traffic shaping parameters for a network interface.

2013-06-10 Thread Giuseppe Vallarelli
- Original Message - | From: Dan Kenigsberg dan...@redhat.com | To: Giuseppe Vallarelli gvall...@redhat.com | Cc: engine-devel@ovirt.org | Sent: Monday, June 10, 2013 4:22:54 PM | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network interface. | | On Mon, Jun 10, 2013

Re: [Engine-devel] Add traffic shaping parameters for a network interface.

2013-06-10 Thread Giuseppe Vallarelli
- Original Message - | From: Doron Fediuck dfedi...@redhat.com | To: Giuseppe Vallarelli gvall...@redhat.com | Cc: Dan Kenigsberg dan...@redhat.com, engine-devel@ovirt.org | Sent: Monday, June 10, 2013 6:46:29 PM | Subject: Re: [Engine-devel] Add traffic shaping parameters for a network