Re: [Engine-devel] vds_dynamic refactor

2014-04-06 Thread Liran Zelkha
Don't go down that road. Status shouldn't be saved in the db. But anyway statistics is rapidly changing. So it fits... On Apr 3, 2014 5:14 PM, Gilad Chaplik gchap...@redhat.com wrote: - Original Message - From: Liran Zelkha liran.zel...@gmail.com To: Eli Mesika emes...@redhat.com

Re: [Engine-devel] vds_dynamic refactor

2014-04-06 Thread Liran Zelkha
True but that's no reason to have a bad schema On Apr 3, 2014 5:18 PM, Gilad Chaplik gchap...@redhat.com wrote: - Original Message - From: Liran Zelkha liran.zel...@gmail.com To: Gilad Chaplik gchap...@redhat.com Cc: Eli Mesika emes...@redhat.com, engine-devel engine-devel

Re: [Engine-devel] vds_dynamic refactor

2014-04-06 Thread Liran Zelkha
On Thu, Apr 3, 2014 at 5:33 PM, Gilad Chaplik gchap...@redhat.com wrote: *From: *Liran Zelkha liran.zel...@gmail.com *To: *Gilad Chaplik gchap...@redhat.com *Cc: *Omer Frenkel ofren...@redhat.com, Eli Mesika emes...@redhat.com, engine-devel engine-devel@ovirt.org *Sent: *Thursday, April 3

Re: [Engine-devel] [Devel] vds_dynamic refactor

2014-04-06 Thread Liran Zelkha
On Fri, Apr 4, 2014 at 3:15 PM, Itamar Heim ih...@redhat.com wrote: On 04/04/2014 04:30 AM, Liran Zelkha wrote: On Thu, Apr 3, 2014 at 8:40 PM, Gilad Chaplik gchap...@redhat.com mailto:gchap...@redhat.com wrote: - Original Message - From: Liran Zelkha liran.zel

Re: [Engine-devel] vds_dynamic refactor

2014-04-03 Thread Liran Zelkha
Why not move it to vds_static? On Thu, Apr 3, 2014 at 2:00 PM, Gilad Chaplik gchap...@redhat.com wrote: Hi list, I propose to split vds_dynamic table into 2 tables: - vds_dynamic - vds_on_boot We need a place to put all non-dynamic data that gets updated once the host is booted, and I

Re: [Engine-devel] vds_dynamic refactor

2014-04-03 Thread Liran Zelkha
Zaslavsky yzasl...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Thursday, April 3, 2014 4:00:25 PM Subject: Re: [Engine-devel] vds_dynamic refactor - Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: Liran Zelkha liran.zel...@gmail.com Cc: Gilad

Re: [Engine-devel] Schema upgrade failure on master

2014-03-04 Thread Liran Zelkha
Happens to me too, on engine_dao_tests. DB is not empty, one line: engine_dao_tests= select * from event_subscriber; subscriber_id | event_up_name | method_id | method_address | tag_name | notification_method

Re: [Engine-devel] Schema upgrade failure on master

2014-03-04 Thread Liran Zelkha
had the same issue. Run from psql: truncate table event_subscriber; Then run the script. Note that this will delete all the rows from your table... On Tue, Mar 4, 2014 at 3:18 PM, Adam Litke ali...@redhat.com wrote: On 04/03/14 00:10 -0500, Martin Perina wrote: Hi Adam, I didn't notice any

[Engine-devel] Usage of Dynamic Queries

2014-03-03 Thread Liran Zelkha
Hi All, As part of an ongoing effort to improve oVirt performance, we're trying to reduce the number of Dynamic Queries usage in the code, and replace it with Postgres stored procedures. You wouldn't believe the performance gain. Please consider before making use of the Dynamic Queries feature -

Re: [Engine-devel] which data structure is better

2014-02-20 Thread Liran Zelkha
Hi Please don't add rapidly changing data to VDSDynamic - it has major performance implications. So, choose option B. Actually, try to expose relevant data in VDSDynamic and VDSStatistics, and VDS should call VDSDynamic and VDSStatistics and merge the data from both entities. On Thu, Feb 20,

[Engine-devel] Installing RHEVM DWH 3.2

2013-12-23 Thread Liran Zelkha
Anybody knows how to install RHEVM DWH version 3.2 using the subscription-manager? ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel

Re: [Engine-devel] Polling vs Pushing engine events

2013-12-17 Thread Liran Zelkha
Note that you can usually get all the information you want using 1 API call, which should still scale. For instance, /ovirt-engine/api/vms will give you a list of all VMs and their statuses, so you can just run an XPath and get the status of all of them. On Tue, Dec 17, 2013 at 10:18 AM, Itamar

Re: [Engine-devel] Ideas about engine clustering?

2013-08-28 Thread Liran Zelkha
I've added a wiki page on Engine HA. http://www.ovirt.org/Features/Engine_High_Availability Please add your comments, we'll try to make this an ongoing effort. On Sat, Aug 24, 2013 at 3:25 PM, Liran Zelkha liran.zel...@gmail.comwrote: IMHO EJB clustering is not the direction we should take

Re: [Engine-devel] Java Development Lifecycle

2013-08-27 Thread Liran Zelkha
+1 - Original Message - From: Mooli Tayer mta...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Tuesday, August 27, 2013 2:29:01 PM Subject: [Engine-devel] Java Development Lifecycle Hello, I've been working on the engine for a few month now, And I feel I have not yet been

Re: [Engine-devel] Ideas about engine clustering?

2013-08-24 Thread Liran Zelkha
IMHO EJB clustering is not the direction we should take, especially considering our IoC plans (see http://gerrit.ovirt.org/#/c/5575/). QuartzScheduler can be easily fixed by using a DB for Quartz configuration. We had such a discussion a few weeks ago. mod_jk is probably better for our HA.

[Engine-devel] ovirt.org and profiliing

2013-07-23 Thread Liran Zelkha
Hi all As part of our effort to get profiling licenses to the ovirt contributors, we need to place an image of JProfiler (the chosen profiler) on the home page of ovirt.org. Anyone here knows who has the rights to do that? Thanks ___ Engine-devel

Re: [Engine-devel] [rhevm-staff] Fwd: BatchUpdates and VdsUpdateRuntimeInfo

2013-07-03 Thread Liran Zelkha
Loaded average of a system that only runs update runtime info On Jul 3, 2013 2:45 PM, Michal Skrivanek mskri...@redhat.com wrote: - Forwarded Message - From: Liran Zelkha liran.zel...@gmail.com To: engine-devel engine-devel@ovirt.org Cc: Itamar Heim ih...@redhat.com, Barak

Re: [Engine-devel] Guid improvements

2013-07-01 Thread Liran Zelkha
Awesome!!! On Mon, Jul 1, 2013 at 10:29 AM, Allon Mureinik amure...@redhat.com wrote: - Original Message - From: Liran Zelkha liran.zel...@gmail.com To: Yair Zaslavsky yzasl...@redhat.com Cc: Allon Mureinik amure...@redhat.com, engine-devel engine-devel@ovirt.org Sent

Re: [Engine-devel] Guid improvements

2013-06-30 Thread Liran Zelkha
Great news. Allon - please note that GUID is being recreated from String by both DB calls and by data received from VDSM. It is VERY useful to cache Guid String--Guid, and not just Empty GUID. However, as the Guid class runs in GWT as well, you can't use Infinispan and you're limited in the

Re: [Engine-devel] Guid improvements

2013-06-30 Thread Liran Zelkha
I checked such a solution using JProfiler. Creating the GUID object takes much more CPU cycles that checking the string in the Map. On Jun 30, 2013, at 12:06 PM, Michael Pasternak wrote: On 06/30/2013 11:37 AM, Liran Zelkha wrote: Great news. Allon - please note that GUID is being recreated

Re: [Engine-devel] Guid improvements

2013-06-30 Thread Liran Zelkha
Why synchronization? No need for it. Worst case scenario a put (which should be much less common then get) will occur twice on the same key. On Jun 30, 2013, at 1:00 PM, Michael Pasternak wrote: On 06/30/2013 12:45 PM, Liran Zelkha wrote: All is true. But average UUID.fromString execution

Re: [Engine-devel] Guid improvements

2013-06-30 Thread Liran Zelkha
Sure. I agree. I'd be happy to show you the results in the profiler, so we can make a correct decision. On Jun 30, 2013, at 1:23 PM, Michael Pasternak wrote: On 06/30/2013 01:15 PM, Michael Pasternak wrote: On 06/30/2013 01:08 PM, Liran Zelkha wrote: Why synchronization? No need

Re: [Engine-devel] Updates in VdsUpdateRuntimeInfo

2013-06-12 Thread Liran Zelkha
) UpdateRuntimeInfo performance wasted roughly 40% of CPU time on DB activity. And only 12% of that was wasted on update behavior. My next task is to try and optimize the rest of overall database performance. - Original Message - From: Liran Zelkha liran.zel...@gmail.com To: Barak Azulay bazu

Re: [Engine-devel] Updates in VdsUpdateRuntimeInfo

2013-06-12 Thread Liran Zelkha
Batch updates for UpdateVmDeviceRuntimeInfo, UpdateVdsInterfaceStatistics and UpdateVdsDynamic. All improved execution performance by about 60-80%. On Jun 12, 2013, at 4:05 PM, Itamar Heim wrote: On 06/12/2013 04:03 PM, Liran Zelkha wrote: Hi all, Current status of VdsUpdateRuntimeInfo

[Engine-devel] Updates in VdsUpdateRuntimeInfo

2013-06-11 Thread Liran Zelkha
Hi all, I'm checking performance for VdsUpdateRunTimeInfo. Naturally, much of the performance surrounds database activity (getVmsRunningOnVds queries, updateDeviceRuntimeInfo, updateVmDynamic) Few questions: 1. I have implemented batch updates for procedure UpdateVmDeviceRuntimeInfo for

Re: [Engine-devel] Performance and scalability

2013-06-10 Thread Liran Zelkha
Will do. Thanks. On Mon, Jun 10, 2013 at 3:44 PM, Livnat Peer lp...@redhat.com wrote: On 06/04/2013 02:43 PM, Liran Zelkha wrote: Hi all, I've added a new feature page for Performance and Scalability. Please review and add your ideas... http://www.ovirt.org/Features

[Engine-devel] Performance and scalability

2013-06-04 Thread Liran Zelkha
Hi all, I've added a new feature page for Performance and Scalability. Please review and add your ideas... http://www.ovirt.org/Features/Performance_And_Scalability ___ Engine-devel mailing list Engine-devel@ovirt.org

Re: [Engine-devel] Performance and scalability

2013-06-04 Thread Liran Zelkha
- From: Laszlo Hornyak lhorn...@redhat.com To: Liran Zelkha lzel...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Tuesday, June 4, 2013 5:01:37 PM Subject: Re: [Engine-devel] Performance and scalability Hi Liran, Some comments to start the discussion: - Caching: exactly how

[Engine-devel] DB performance optimization

2013-05-13 Thread Liran Zelkha
Hi all, There is a WIP for caching and DB performance optimization. Please look at - http://gerrit.ovirt.org/#/c/14188/4 To summarize, it includes automatic caching for some business entities (*_static for instance), break up of VDS to VDS_static, VDS_dynamic and VDS_statistics, and support

Re: [Engine-devel] VDSM Fake

2013-04-30 Thread Liran Zelkha
Awesome. I really need this for the stress tests I'm running. How many hosts were you able to simulate with one web application? - Original Message - From: Libor Spevak lspe...@redhat.com To: engine-devel@ovirt.org Sent: Tuesday, April 30, 2013 12:50:52 PM Subject: [Engine-devel] VDSM

Re: [Engine-devel] Dropping encryption of database password

2013-04-30 Thread Liran Zelkha
Why not do use the same technology like JBoss DataSource password encryption? http://docs.jboss.org/jbosssecurity/docs/6.0/security_guide/html/Encrypting_Data_Source_Passwords.html On Wed, May 1, 2013 at 3:45 AM, Eli Mesika emes...@redhat.com wrote: - Original Message - From: Alon

[Engine-devel] Database Caching

2013-04-24 Thread Liran Zelkha
Hi I've created Change I04d7edea (http://gerrit.ovirt.org/#/c/14188/) that adds automatic database caching capabilities to the engine. To cache a business entity, just add an annotation called TimeToLiveInCache that accepts as a parameter the number of seconds this object can live in the cache

Re: [Engine-devel] Introducing Infinispan cache and some required actions after change

2013-04-23 Thread Liran Zelkha
Great news. I totally agree that Infinispan is the right way to go. Michael - let's sync on the database caching integration with Infinispan. Would love to hear your thoughts. - Original Message - From: Yair Zaslavsky yzasl...@redhat.com To: Michael Kublin mkub...@redhat.com Cc:

Re: [Engine-devel] Move SQL out of stored procedures

2013-04-02 Thread Liran Zelkha
the performance in engine. Laszlo - Original Message - From: Liran Zelkha lzel...@redhat.com To: Eli Mesika emes...@redhat.com Cc: engine-devel@ovirt.org Sent: Tuesday, April 2, 2013 7:24:08 AM Subject: Re: [Engine-devel] Move SQL out of stored procedures I also apologize

Re: [Engine-devel] Move SQL out of stored procedures

2013-04-02 Thread Liran Zelkha
Hi I think externalizing SQL can lead to a VERY difficult maintenance. But, as long as we stick to SQL (or stored procedures, just not ORM), I don't mind… On Apr 2, 2013, at 10:19 AM, Yair Zaslavsky wrote: - Original Message - From: Libor Spevak lspe...@redhat.com To: Juan

Re: [Engine-devel] Move SQL out of stored procedures

2013-04-01 Thread Liran Zelkha
I also apologize for jumping in late... I think concerning SQL injection we'll be covered by using PreparedStatements. Since we're using SpringJDBC, most of our code uses PreparedStatements anyway. Concerning ORM - I feel it won't really be beneficial to us. I know of very few projects who can