Re: [Engine-devel] network wiring DD questions/comments

2012-11-20 Thread Moti Asayag
Few more (here and inline): 1. Add can-do-action for network name with name 'none'. This is not must - if we change none with N/A in the network drop-down list. 2. In plugged -- plugged - updateVmInteface should be replaced with updateVmDevice. On 11/20/2012 09:40 AM, Livnat Peer wrote: Hi

Re: [Engine-devel] network wiring DD questions/comments

2012-11-20 Thread Alona Kaplan
Hi, Ive added my answers as inline comments. Thanks, Alona. Hi Alona, I reviewed the DD of wired/unwired and I have a few questions/comments - 1. update vnic while the VM is running should be limited to cluster 3.2 (except for plug/unplug) Ive updated the detailed wiki-

Re: [Engine-devel] network wiring DD questions/comments

2012-11-20 Thread Alona Kaplan
Few more (here and inline): 1. Add can-do-action for network name with name 'none'. This is not must - if we change none with N/A in the network drop-down list. Instead of none there will be an empty cell, to avoid confusion if a network name none will be added (Ive updated the wiki).

Re: [Engine-devel] network wiring DD questions/comments

2012-11-20 Thread Livnat Peer
On 20/11/12 17:06, Alona Kaplan wrote: Hi, Ive added my answers as inline comments. Thanks, Alona. Hi Alona, I reviewed the DD of wired/unwired and I have a few questions/comments - 1. update vnic while the VM is running should be limited to cluster 3.2 (except for plug/unplug)

Re: [Engine-devel] Network Wiring

2012-11-19 Thread Livnat Peer
On 18/11/12 17:06, Alona Kaplan wrote: snip purge a network while it is connected to VMs: Link-Down on all nics and connect to the empty/no network. (Yes I know, it's not par of the feature, but you know someone will ask for it soon :)) It should not be hard to implement; In

Re: [Engine-devel] Network Wiring

2012-11-18 Thread Alona Kaplan
NX users may confuse between connected to vm or connected to the switch (despite of plugged), as they used to link=up|downlink/ Yap, no convergence on terminology yet, right? I think we need to keep the plugged/unplugged not to confuse libvirt users Yes, with real iron

Re: [Engine-devel] Network Wiring

2012-11-18 Thread Dan Kenigsberg
On Sun, Nov 18, 2012 at 05:01:30AM -0500, Alona Kaplan wrote: snip purge a network while it is connected to VMs: Link-Down on all nics and connect to the empty/no network. (Yes I know, it's not par of the feature, but you know someone will ask for it soon :)) It should not be

Re: [Engine-devel] Network Wiring

2012-11-18 Thread Simon Grinberg
- Original Message - From: Dan Kenigsberg dan...@redhat.com To: Alona Kaplan alkap...@redhat.com Cc: Simon Grinberg si...@redhat.com, engine-devel@ovirt.org Sent: Sunday, November 18, 2012 1:12:05 PM Subject: Re: [Engine-devel] Network Wiring On Sun, Nov 18, 2012 at 05:01:30AM

Re: [Engine-devel] Network Wiring

2012-11-18 Thread Alona Kaplan
snip purge a network while it is connected to VMs: Link-Down on all nics and connect to the empty/no network. (Yes I know, it's not par of the feature, but you know someone will ask for it soon :)) It should not be hard to implement; In

Re: [Engine-devel] Network Wiring

2012-11-15 Thread Livnat Peer
On 15/11/12 05:57, Itamar Heim wrote: On 11/13/2012 04:46 PM, Alona Kaplan wrote: Hi all, Please review the wiki and add your comments. http://wiki.ovirt.org/wiki/Feature/NetworkWiring Dialog If the VM status is 'UP' If the Vnic is plugged there should be a

Re: [Engine-devel] Network Wiring

2012-11-15 Thread Dan Kenigsberg
On Wed, Nov 14, 2012 at 02:12:07PM -0500, Simon Grinberg wrote: The intention is to use the new API VDSM.libvirtVm.updateVmInteface for performing the network rewire in a single command. What does it do? I could not find updateVmInteface in vdsm git. Where is this defined? It's

Re: [Engine-devel] Network Wiring

2012-11-15 Thread Simon Grinberg
- Original Message - From: Dan Kenigsberg dan...@redhat.com To: Yaniv Kaul yk...@redhat.com Cc: Simon Grinberg si...@redhat.com, engine-devel@ovirt.org Sent: Thursday, November 15, 2012 3:36:02 PM Subject: Re: [Engine-devel] Network Wiring On Thu, Nov 15, 2012 at 02:43:23PM +0200

Re: [Engine-devel] Network Wiring

2012-11-15 Thread Dan Kenigsberg
On Thu, Nov 15, 2012 at 03:04:45PM -0500, Simon Grinberg wrote: NX users may confuse between connected to vm or connected to the switch (despite of plugged), as they used to link=up|downlink/ Yap, no convergence on terminology yet, right? I think we need to keep the

Re: [Engine-devel] Network Wiring

2012-11-14 Thread Yaniv Kaul
On 11/13/2012 04:46 PM, Alona Kaplan wrote: Hi all, Please review the wiki and add your comments. http://wiki.ovirt.org/wiki/Feature/NetworkWiring Thanks, Alona. ___ Engine-devel mailing list Engine-devel@ovirt.org

Re: [Engine-devel] Network Wiring

2012-11-14 Thread Itamar Heim
On 11/13/2012 04:46 PM, Alona Kaplan wrote: Hi all, Please review the wiki and add your comments. http://wiki.ovirt.org/wiki/Feature/NetworkWiring Dialog If the VM status is 'UP' If the Vnic is plugged there should be a message on top of the dialog Please

[Engine-devel] Network Wiring

2012-11-13 Thread Alona Kaplan
Hi all, Please review the wiki and add your comments. http://wiki.ovirt.org/wiki/Feature/NetworkWiring Thanks, Alona. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel

Re: [Engine-devel] Network Wiring

2012-11-13 Thread Simon Grinberg
From the summary: ...It supports the following actions without unplugging the Vnic, and it maintains the device address of the Vnic But in the dialogue section: If the Vnic is plugged there should be a message on top of the dialog Please notice, changing Type or MAC will cause unplugging

Re: [Engine-devel] Network Wiring

2012-11-13 Thread Moti Asayag
On 11/13/2012 07:58 PM, Simon Grinberg wrote: From the summary: ...It supports the following actions without unplugging the Vnic, and it maintains the device address of the Vnic But in the dialogue section: If the Vnic is plugged there should be a message on top of the dialog Please