Re: [Enigmail] [PATCH 2/2] .xpi generation should fail if components are missing

2013-12-29 Thread Patrick Brunschwig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 12.11.13 18:41, Patrick Brunschwig wrote: On 12.11.13 18:33, Daniel Kahn Gillmor wrote: On 11/12/2013 12:27 PM, Patrick Brunschwig wrote: This patch won't work for Thunderbird 19 and newer, as the referenced ${enigDllFile} (line 153) is only

Re: [Enigmail] [PATCH 2/2] .xpi generation should fail if components are missing

2013-11-12 Thread Daniel Kahn Gillmor
On 11/12/2013 12:27 PM, Patrick Brunschwig wrote: This patch won't work for Thunderbird 19 and newer, as the referenced ${enigDllFile} (line 153) is only generated on Gecko version = 18. Thus the files would not match. this seems like something that genxpi should know about, no? If it knows

[Enigmail] [PATCH 2/2] .xpi generation should fail if components are missing

2013-11-11 Thread Daniel Kahn Gillmor
Without this change, zip would happily carry on even if some elements are missing due to other undetected failures in the build process. It's better to catch errors in the .xpi generation at build time, rather than at install or runtime. --- genxpi | 2 +- 1 file changed, 1 insertion(+), 1