Re: [E-devel] [PATCH] ecore_imf: Add support for wayland

2013-04-19 Thread Eduardo Lima (Etrunko)
On Fri, Apr 19, 2013 at 10:54 AM, Rafael Antognolli wrote: > On Fri, Apr 19, 2013 at 6:56 AM, Chris Michael wrote: >> Also, you could use ecore_wl_registry_get instead of >> wl_display_get_registry. >> >> And ecore_wl_display_iterate instead of wl_display_dispatch. >> >> dh > > Notice that the wl

Re: [E-devel] [PATCH] ecore_imf: Add support for wayland

2013-04-19 Thread Rafael Antognolli
On Fri, Apr 19, 2013 at 6:56 AM, Chris Michael wrote: > Also, you could use ecore_wl_registry_get instead of > wl_display_get_registry. > > And ecore_wl_display_iterate instead of wl_display_dispatch. > > dh Notice that the wl_display_dispatch (and consequently, ecore_wl_display_iterate) may also

Re: [E-devel] [PATCH] ecore_imf: Add support for wayland

2013-04-19 Thread Jan Arne Petersen
Hi! Thanks for the quick review. I will find a better solution for the im_module_init and fix the formatting. Jan Arne On 04/19/2013 11:56 AM, Chris Michael wrote: > Also, you could use ecore_wl_registry_get instead of > wl_display_get_registry. > > And ecore_wl_display_iterate instead of wl_

Re: [E-devel] [EGIT] [apps/terminology] master 01/01: alt + 1, 2, 3, ...8, 9, 0 switch TO terminal tab # 1, 2, ... 8, 9, 10

2013-04-19 Thread Ray
Well, if there's no immediate possibility of configurability, I vote for CTRL+1,2,3..9,0 for me, those are the least likely to clash. best, Ray 2013/4/18 Carsten Haitzler > On Thu, 18 Apr 2013 19:50:29 +0200 Boris Faure said: > > > On 13-04-18 14:20, Gustavo Lima Chaves wrote: > > > * Carste

Re: [E-devel] [PATCH] ecore_imf: Add support for wayland

2013-04-19 Thread Chris Michael
Also, you could use ecore_wl_registry_get instead of wl_display_get_registry. And ecore_wl_display_iterate instead of wl_display_dispatch. dh On 19/04/13 10:53, Chris Michael wrote: > Hi Jan, > > Thanks for the efforts here :) > > After a quick review, this seems ok. Some of the formatting is w

Re: [E-devel] [PATCH] ecore_imf: Add support for wayland

2013-04-19 Thread Chris Michael
Hi Jan, Thanks for the efforts here :) After a quick review, this seems ok. Some of the formatting is wrong (ie: not EFL style), however that is just a minor thing. One thing that does concern me here tho is why: + wl_display_roundtrip(display); is being called in the im_module_init ? That