Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_widget: cleanup _elm_widget_on_focus function

2016-01-20 Thread Jean-Philippe André
On 20 January 2016 at 23:58, Cedric BAIL wrote: > On Jan 20, 2016 00:07, "Minkyu Kang" wrote: > > > > hermet pushed a commit to branch master. > > > > > > http://git.enlightenment.org/core/elementary.git/commit/?id=2eb95a547736af1445b0a292223ad8973ad24acb > > > > commit 2eb95a547736af1445b0a2922

Re: [E-devel] [EGIT] [bindings/python/python-efl] master 01/01: Implemented Genlist filter ability

2016-01-20 Thread Cedric BAIL
On Wed, Jan 20, 2016 at 1:55 PM, Dave Andreoli wrote: > davemds pushed a commit to branch master. > > http://git.enlightenment.org/bindings/python/python-efl.git/commit/?id=005dd26f73f0a634d16286362b80ce98e2e277a8 > > commit 005dd26f73f0a634d16286362b80ce98e2e277a8 > Author: Dave Andreoli > Date:

Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_widget: use internal function for clearing the focus

2016-01-20 Thread Cedric BAIL
On Jan 20, 2016 00:17, "Minkyu Kang" wrote: > > hermet pushed a commit to branch master. > > http://git.enlightenment.org/core/elementary.git/commit/?id=163d1c8b88fc613a4700cecc93f83f7136da0873 > > commit 163d1c8b88fc613a4700cecc93f83f7136da0873 > Author: Minkyu Kang > Date: Wed Jan 20 17:15:45

Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_widget: cleanup _elm_widget_on_focus function

2016-01-20 Thread Cedric BAIL
On Jan 20, 2016 00:07, "Minkyu Kang" wrote: > > hermet pushed a commit to branch master. > > http://git.enlightenment.org/core/elementary.git/commit/?id=2eb95a547736af1445b0a292223ad8973ad24acb > > commit 2eb95a547736af1445b0a292223ad8973ad24acb > Author: Minkyu Kang > Date: Wed Jan 20 17:06:22

Re: [E-devel] [EGIT] [apps/ephoto] master 01/01: Ephoto: Only update thumbs on monitor call when the thumb is in the current directory.

2016-01-20 Thread Stephen Houston
Lawd yes it needs to be refactored. Y'all quit complaining about my copy and paste haste haha. I will clean it up. The other is just me being overly cautious I reckon. On Jan 20, 2016 3:25 AM, "Andrew Williams" wrote: > Hi, > > I happened to notice this is the same code 3 times, can it not be >

Re: [E-devel] [EGIT] [apps/ephoto] master 01/01: Ephoto: Only update thumbs on monitor call when the thumb is in the current directory.

2016-01-20 Thread Andrew Williams
Hi, I happened to notice this is the same code 3 times, can it not be refactored to a different method and called 3 times? If I had my testing hat on I'd say that method also could be well rested to validate the other questions of how many char comparisons are needed :) Cheers, Andrew On Tue, 19