Re: [E-devel] [EGIT] [core/efl] master 01/02: eina: remove usless newline

2018-01-16 Thread Jean-Philippe André
Quick note: I think this patch affects ABI for anything that uses EO files outside of EFL tree (which isn't a stable feature). On Tue, Jan 16, 2018 at 7:53 PM, Jean-Philippe André wrote: > Hi, > > This broke make check (I fixed it now). > > Note that this patch probably

Re: [E-devel] [EGIT] [core/efl] master 01/02: eina: remove usless newline

2018-01-16 Thread Jean-Philippe André
Hi, (skip this mail if you don't care about micro optimization^^) On Tue, Jan 16, 2018 at 9:13 PM, Carsten Haitzler wrote: > On Tue, 16 Jan 2018 20:25:37 +0900 Jean-Philippe André > said: > > > Oh, another point. > > > > I'm pretty sure that the many

Re: [E-devel] [EGIT] [core/efl] master 01/06: efl_playable: split Efl.Player interface to Efl.Playable interface

2018-01-16 Thread Davide Andreoli
2018-01-16 14:08 GMT+01:00 Sungtaek Hong : > jpeg pushed a commit to branch master. > > http://git.enlightenment.org/core/efl.git/commit/?id= > 588995da317520fc92660b89b0864bb1f25abc09 > > commit 588995da317520fc92660b89b0864bb1f25abc09 > Author: Sungtaek Hong

Re: [E-devel] [EGIT] [core/efl] master 01/01: efl wl - fix segv where garbage ptr to comp surface is still there

2018-01-16 Thread Mike Blumenkrantz
I'd be interested in knowing how you came across this issue since that functionality should be handled automatically on surface hide. This patch is not a complete solution and will break some seat methods, so it would be great if we could get that cleaned up. On Tue, Jan 16, 2018 at 3:50 AM

Re: [E-devel] Internal liblz4 copy outdated (again), switch to normal system dep by default?

2018-01-16 Thread Stefan Schmidt
Hello. On 01/16/2018 01:11 PM, Carsten Haitzler wrote: > On Tue, 16 Jan 2018 09:23:54 +0100 Stefan Schmidt > said: > >> Hello. >> >> >> On 01/16/2018 02:40 AM, Carsten Haitzler wrote: >>> On Mon, 15 Jan 2018 12:49:14 +0100 Stefan Schmidt >>>

Re: [E-devel] Internal liblz4 copy outdated (again), switch to normal system dep by default?

2018-01-16 Thread Carsten Haitzler
On Tue, 16 Jan 2018 09:23:54 +0100 Stefan Schmidt said: > Hello. > > > On 01/16/2018 02:40 AM, Carsten Haitzler wrote: > > On Mon, 15 Jan 2018 12:49:14 +0100 Stefan Schmidt > > said: > > > >> Hello. > >> > >> > >> When looking through our builds

Re: [E-devel] [EGIT] [core/efl] master 01/02: eina: remove usless newline

2018-01-16 Thread Carsten Haitzler
On Tue, 16 Jan 2018 20:25:37 +0900 Jean-Philippe André said: > Oh, another point. > > I'm pretty sure that the many very ugly goto we have in the code to "not > pollute L1 cache" are in fact not useful. I had a look at the ASM produced > by GCC -O2 and it strictly follows

Re: [E-devel] [EGIT] [core/efl] master 01/02: eina: remove usless newline

2018-01-16 Thread Jean-Philippe André
Oh, another point. I'm pretty sure that the many very ugly goto we have in the code to "not pollute L1 cache" are in fact not useful. I had a look at the ASM produced by GCC -O2 and it strictly follows EINA_(UN)LIKELY. If goto is used for error handling, fine, but if it's used with "goto

Re: [E-devel] [EGIT] [core/efl] master 01/02: eina: remove usless newline

2018-01-16 Thread Jean-Philippe André
Hi, This broke make check (I fixed it now). Note that this patch probably should not have been merged as a single commit, as the Phab Diff contains multiple patches. Best regards, On Tue, Jan 16, 2018 at 5:50 PM, Jean Guyomarc'h wrote: > raster pushed a commit to branch

Re: [E-devel] Internal liblz4 copy outdated (again), switch to normal system dep by default?

2018-01-16 Thread Romain Naour
Hi Stefan, Le 16/01/2018 à 09:23, Stefan Schmidt a écrit : > Hello. > > > On 01/16/2018 02:40 AM, Carsten Haitzler wrote: >> On Mon, 15 Jan 2018 12:49:14 +0100 Stefan Schmidt >> said: >> >>> Hello. >>> >>> >>> When looking through our builds (in particularly the one

Re: [E-devel] Internal liblz4 copy outdated (again), switch to normal system dep by default?

2018-01-16 Thread Stefan Schmidt
Hello. On 01/16/2018 02:40 AM, Carsten Haitzler wrote: > On Mon, 15 Jan 2018 12:49:14 +0100 Stefan Schmidt > said: > >> Hello. >> >> >> When looking through our builds (in particularly the one which uses the >> liblz4 from system build option) I stumbled over now