Re: [E-devel] [EGIT] [core/efl] master 01/01: efl.task - move to returning future insead of bool + exit event

2018-03-20 Thread The Rasterman
On Tue, 20 Mar 2018 12:06:08 -0400 Cedric Bail said: > On March 20, 2018 7:38 AM, Carsten Haitzler wrote: > > On Tue, 20 Mar 2018 10:06:43 -0300 Gustavo Sverzut Barbieri > > barbi...@gmail.com said: > > > > > > I said I'd give up... but seeing this makes me sad. > > > > > > in two lines you:

Re: [E-devel] [EGIT] [core/efl] master 01/01: efl.task - move to returning future insead of bool + exit event

2018-03-20 Thread The Rasterman
On Tue, 20 Mar 2018 12:06:08 -0400 Cedric Bail said: > On March 20, 2018 7:38 AM, Carsten Haitzler wrote: > > On Tue, 20 Mar 2018 10:06:43 -0300 Gustavo Sverzut Barbieri > > barbi...@gmail.com said: > > > > > > I said I'd give up... but seeing this makes me sad. > > > > > > in two lines you:

Re: [E-devel] [EGIT] [core/efl] master 01/01: efl.task - move to returning future insead of bool + exit event

2018-03-20 Thread Cedric Bail
On March 20, 2018 7:38 AM, Carsten Haitzler wrote: > On Tue, 20 Mar 2018 10:06:43 -0300 Gustavo Sverzut Barbieri > barbi...@gmail.com said: > > I said I'd give up... but seeing this makes me sad. > > > > in two lines you: misused the Eina_Error AND missed the purpose of resolve. > > > > I hoped

Re: [E-devel] [EGIT] [core/efl] master 01/01: efl.task - move to returning future insead of bool + exit event

2018-03-20 Thread The Rasterman
On Tue, 20 Mar 2018 10:06:43 -0300 Gustavo Sverzut Barbieri said: > > static void > > _exe_exit_eval(Eo *obj, Efl_Exe_Data *pd) > > { > > if ((pd->fd.out == -1) && /*(pd->fd.in == -1) &&*/ > > (pd->fd.exited_read == -1) && (!pd->exit_called)) > > { > > -Eina_Future *j

Re: [E-devel] [EGIT] [core/efl] master 01/01: efl.task - move to returning future insead of bool + exit event

2018-03-20 Thread Gustavo Sverzut Barbieri
> static void > _exe_exit_eval(Eo *obj, Efl_Exe_Data *pd) > { > if ((pd->fd.out == -1) && /*(pd->fd.in == -1) &&*/ > (pd->fd.exited_read == -1) && (!pd->exit_called)) > { > -Eina_Future *job; > -Eo *loop = efl_provider_find(obj, EFL_LOOP_CLASS); > - > p

Re: [E-devel] [EGIT] [core/efl] master 01/02: eo: automatically cancel a future that is attached to an invalidated object.

2018-03-20 Thread Gustavo Sverzut Barbieri
On Mon, Mar 19, 2018 at 8:47 PM, Cedric BAIL wrote: > cedric pushed a commit to branch master. > > http://git.enlightenment.org/core/efl.git/commit/?id=21164b5a56f2ff0fbe8e60f85f7070212cbdfe38 > > commit 21164b5a56f2ff0fbe8e60f85f7070212cbdfe38 > Author: Cedric Bail > Date: Mon Mar 19 16:38:07