Re: [E-devel] [EGIT] [core/efl] master 01/02: elm - sel manager - fix windows build with selection vars

2018-04-23 Thread Carsten Haitzler
xOn Mon, 23 Apr 2018 21:30:29 +0300 Daniel Zaoui said: > Hey old man, > > Please ifdef your stuff, perv! Compilation fails on X - no member named win. it is in an ifdef already. ... and now it's broken on windows again. just the ifdef is too broad. it's for x AND win32.

[E-devel] Fw: Re: [EGIT] [core/efl] master 02/09: efl: use efl_add_ref to create objects which have no parent

2018-04-23 Thread Cedric Bail
Arf, this didn't got to the ml... ‐‐‐ Original Message ‐‐‐ On April 23, 2018 3:27 PM, Cedric Bail wrote: > On April 21, 2018 7:46 AM, Carsten Haitzler ras...@rasterman.com wrote: > > On Wed, 18 Apr 2018 12:38:46 -0400 Cedric Bail ced...@ddlm.me said: > > > On April 18,

Re: [E-devel] [EGIT] [core/efl] master 01/02: elm - sel manager - fix windows build with selection vars

2018-04-23 Thread Daniel Zaoui
Hey old man, Please ifdef your stuff, perv! Compilation fails on X - no member named win. Thanks D2 On Mon, 23 Apr 2018 09:37:34 -0700 Carsten Haitzler wrote: > raster pushed a commit to branch master. > >

Re: [E-devel] Commit Review Rules and Requirements

2018-04-23 Thread Mike Blumenkrantz
As some are aware, I've been trialing this for some time, and with two small exceptions, every patch I've written for the past month (92 patches) has been reviewed and landed by a third party, ie. someone who is not me. Half of these have been submitted and reviewed through phabricator and are

Re: [E-devel] Get an IRC meeting togther?

2018-04-23 Thread The Rasterman
On Mon, 23 Apr 2018 19:18:12 +0900 Carsten Haitzler (The Rasterman) said: conclusions for this meeting at the end of the vote: https://phab.enlightenment.org/V33 we have agreed to continue again tomorrow at the other popular time: 15:00GMT 24/4/2018 we shall continue

[E-devel] Commit Review Rules and Requirements

2018-04-23 Thread Stephen Houston
In our meeting today we discussed the need for more patch/commit reviewing and that there should be rules in place as to what should require a review before being pushed into master. These were some suggestions: Any commit that: A. Is not a fix or a feature planned for the next release B. Is

Re: [E-devel] Get an IRC meeting togther?

2018-04-23 Thread The Rasterman
On Wed, 18 Apr 2018 16:59:18 +0900 Carsten Haitzler (The Rasterman) said: reminder, this is in 4h40 from now... :) > specifically: > > https://phab.enlightenment.org/T6740 > > timed releases, roadmaps (release, project) etc. it'll be far better to do > this quickly