Re: [E-devel] Jenkins

2019-07-22 Thread Bertrand Jacquin
Hey, I just removed Jenkins notification since e5 is now gone from previous install. On Mon, Jul 22, 2019 at 09:10:24AM -0400, Mike Blumenkrantz wrote: > Hi, > > I'm still getting a long delay while pushing to the git server along with > > remote: post-receive-020-notify-jenkins: Notifying Jenk

Re: [E-devel] [EGIT] [core/efl] master 03/03: tests/ecore_wl2: Add test case for ecore_wl2_window_surface_id_get

2019-07-22 Thread Mike Blumenkrantz
Great, thanks! On Mon, Jul 22, 2019 at 9:13 AM Christopher Michael wrote: > On 7/22/19 9:05 AM, Mike Blumenkrantz wrote: > > Hi, > > You're off to a good start with all these tests! This test (and other tests > like it) should verify that they return the correct value, however. This > would mean

Re: [E-devel] [EGIT] [core/efl] master 03/03: tests/ecore_wl2: Add test case for ecore_wl2_window_surface_id_get

2019-07-22 Thread Christopher Michael
On 7/22/19 9:05 AM, Mike Blumenkrantz wrote: Hi, You're off to a good start with all these tests! This test (and other tests like it) should verify that they return the correct value, however. This would mean that you have a test which does: * display_connect() * window_create() * ck_assert(wi

[E-devel] Jenkins

2019-07-22 Thread Mike Blumenkrantz
Hi, I'm still getting a long delay while pushing to the git server along with remote: post-receive-020-notify-jenkins: Notifying Jenkins remote: curl: (28) Connection timed out after 10006 milliseconds Can this be disabled/fixed? Thanks, Mike ___ en

Re: [E-devel] [EGIT] [core/efl] master 03/03: tests/ecore_wl2: Add test case for ecore_wl2_window_surface_id_get

2019-07-22 Thread Mike Blumenkrantz
Hi, You're off to a good start with all these tests! This test (and other tests like it) should verify that they return the correct value, however. This would mean that you have a test which does: * display_connect() * window_create() * ck_assert(window_surface_get()) * ck_assert_int_ne(window_sur

Re: [E-devel] [EGIT] [core/efl] master 08/08: evas/map: permit evas_map_free(NULL)

2019-07-22 Thread Mike Blumenkrantz
Hi, There is no "validate" here, and there has not been for a long time. The MAGIC_CHECK macro now is just a null check. Regards, Mike On Mon, Jul 22, 2019 at 4:32 AM Hermet Park wrote: > This is bad, original validates the invalid map pointer. > Now it might be crashed since you removed it.

Re: [E-devel] [EGIT] [core/efl] master 08/08: evas/map: permit evas_map_free(NULL)

2019-07-22 Thread Hermet Park
This is bad, original validates the invalid map pointer. Now it might be crashed since you removed it. On Sat, Jul 20, 2019 at 11:51 PM Mike Blumenkrantz < michael.blumenkra...@gmail.com> wrote: > cedric pushed a commit to branch master. > > > http://git.enlightenment.org/core/efl.git/commit/?id=