[EGIT] [bindings/cxx/eflxx] master 264/314: After elm radically changed, some compilation errors are not fixed. I changed for this.

2013-12-30 Thread Hyoyoung Chang
tasn pushed a commit to branch master. http://git.enlightenment.org/bindings/cxx/eflxx.git/commit/?id=ae12d9c09a0f0e28af83878e243bfaeb6dfb45dc commit ae12d9c09a0f0e28af83878e243bfaeb6dfb45dc Author: Hyoyoung Chang Date: Tue Mar 13 06:22:39 2012 + After elm radically changed, some

[EGIT] [bindings/cxx/eflxx] master 265/314: due to elm_genlist_item_object_get() is deprecated, I made a patch to replace them to adequate apis. most of case is sending signal.

2013-12-30 Thread Hyoyoung Chang
tasn pushed a commit to branch master. http://git.enlightenment.org/bindings/cxx/eflxx.git/commit/?id=74cda7c273bdc6ba9fb3cc09513f8c8d4c5ead00 commit 74cda7c273bdc6ba9fb3cc09513f8c8d4c5ead00 Author: Hyoyoung Chang Date: Wed Mar 14 05:04:32 2012 + due to elm_genlist_item_object_get

Re: [E-devel] [Patch] fixed Ctxpopup _arrow_update

2013-01-30 Thread Hyoyoung Chang
Hello, your patch is nice to apply. but indent isn't why you change indent heavily? i think it's better to customize your editor. On Wed, Jan 30, 2013 at 1:17 PM, Bora Hwang wrote: > Dear all, > > In elc_ctxpopup.c, there's something wrong when calculating the position > of arrow. > According t

Re: [E-devel] can't focus to windows

2012-08-27 Thread Hyoyoung Chang
nts to programs" 6. check "Click raises the window" check "Click focuses the window" is there anyone who gets this bug? is it just me or? On Sun, Aug 26, 2012 at 10:19 PM, Carsten Haitzler wrote: > On Sun, 26 Aug 2012 22:11:50 +0900 Hyoyoung Chang said: > > set

Re: [E-devel] can't focus to windows

2012-08-26 Thread Hyoyoung Chang
t never gets selected. > > It shouldn't even appear, though :) > > Rui > > On Sun, 26 Aug 2012 20:07:27 +0900 > Carsten Haitzler (The Rasterman) wrote: > >> On Sun, 26 Aug 2012 19:46:06 +0900 Hyoyoung Chang >> said: >> >> > Dear all, >&

[E-devel] can't focus to windows

2012-08-26 Thread Hyoyoung Chang
Dear all, After I updated recent e, i found that i can't click any border windows. And I can't touch at all firefox or chome(which are using override redirected window) I think it's caused by r75540 --- a/trunk/e/src/bin/e_border.c +++ b/trunk/e/src/bin/e_border.c @@ -6512,8 +6512,10 @@ _e_borde

Re: [E-devel] E17 Korea meeting, round 2

2012-07-09 Thread Hyoyoung Chang
Itaewon again? OK, i'll like to join. yay On Mon, Jul 9, 2012 at 7:21 PM, Cedric BAIL wrote: > On Mon, Jul 9, 2012 at 7:14 PM, Carsten Haitzler wrote: >> On Mon, 9 Jul 2012 19:11:03 +0900 (KST) ChunEon Park said: >>> Everywhere, I'm ok. > > So Saturday Seoul then ! So Itaewon for a Bulgar resta

Re: [E-devel] [Patch] Fixed multibuttonentry`s bugs

2012-06-19 Thread Hyoyoung Chang
In svn r72484. thanks. On Tue, Jun 19, 2012 at 2:23 PM, Minseok Kim wrote: > Dear all, > > I've added patches for fixing bugs in multibuttonentry. > > First, elm_multibuttonentry_1.patch > When multibuttonentry is clicked, it shows entry input panel. > but at this time, there's no code for settin

Re: [E-devel] [e-users] Terminology - time to talk.

2012-06-17 Thread Hyoyoung Chang
frankly speaking, there's not many candidates of terminal emulator. most of times, i used gnome-terminal but it sometimes makes annoying w/o gnome-setting-daemons. so i'm used xfce4-terminal. now i'm very happy to use terminology. that means i don't need to install other libs. and i can contribute

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

2012-05-24 Thread Hyoyoung Chang
i removed casting at r71412 thanks guys. On Fri, May 25, 2012 at 10:28 AM, Daniel Juyung Seo wrote: > 1. do not cast in this case > 2. no space for casting > yes we have some wrong formatted codes, just fix them when we find them. > On May 25, 2012 12:21 AM, "Carsten Haitzler" wrote: > >> On Thu

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

2012-05-23 Thread Hyoyoung Chang
On Wed, May 23, 2012 at 05:56:10PM +0900, Bluezery wrote: >>>> 2012/5/23 Hyoyoung Chang : >>>> > Maybe it's best time to talk about sizeof(char) >>>> > >>>> > Do we need to sizeof(char)? I just that is problem of coding convention. >&g

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

2012-05-23 Thread Hyoyoung Chang
On Wed, May 23, 2012 at 6:59 PM, Daniel Juyung Seo wrote: > Do we really need go to here? > It looks clean but I want to avoid using goto too many places without > necessity. In this case, i think so. I don't like to use jump either. But if jump makes clear code, there's no need to avoid > > Da

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

2012-05-22 Thread Hyoyoung Chang
Maybe it's best time to talk about sizeof(char) Do we need to sizeof(char)? I just that is problem of coding convention. such as (a == 0) and (!a). Is there any predefined convention about this case? On Wed, May 23, 2012 at 10:52 AM, ChunEon Park wrote: > FYI, sizeof will be computed at the comp

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

2012-05-22 Thread Hyoyoung Chang
On Wed, May 23, 2012 at 1:02 AM, Leandro Pereira wrote: > On Mon, May 21, 2012 at 10:35 PM, Enlightenment SVN > wrote: >>    cnp_debug("Got some HTML: Checking encoding is useful\n"); >>    data = notify->data; >> +   char *stripstr = malloc(sizeof(char) * (data->length + 1)); > > sizeof(char) is

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

2012-05-21 Thread Hyoyoung Chang
Yeah. u'r right. I added some checking routines. thanks PS: could you change your default mail mode to txt? or just set to not convert ">" as ">"? On Tue, May 22, 2012 at 1:22 PM, ChunEon Park wrote: > It missed simple null checking after malloc. > > > + char *stripstr = malloc(sizeof(char) * (d

Re: [E-devel] fix non-NULL-terminated string bug when performing copy/paste using ELM_SEL_FORMAT_HTML

2012-05-21 Thread Hyoyoung Chang
in svn, thanks On Tue, May 22, 2012 at 12:30 AM, Michal Pakula vel Rutka wrote: > Dear EFL Developers, > > I have found a bug which occurs when using elm_selection_set and > elm_selection_get with ELM_SEL_FORMAT_HTML for non elm-entry. If copied > string has i.e. 4 character ("TEST") Elm_Select

Re: [E-devel] [Patch][elm_datetime] Fix documentation

2012-05-20 Thread Hyoyoung Chang
in svn, thanks. On Mon, May 21, 2012 at 3:33 PM, Bluezery wrote: > Hello, > > I fixed documentation typos. > elm_datetime_value_get() returns EINA_BOOL, not integer. > > -- > BRs, > Kim. > > -- > Live Security Virtual Con

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

2012-05-17 Thread Hyoyoung Chang
ot NULL >>> >>> >>> >>> 2012/5/17 ChunEon Park : >>>> I wonder why st is NULL. >>>> >>>> >>>> I think we need to prevent to not go that function in advance, if the st >>>> was invalid. >>>>

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

2012-05-17 Thread Hyoyoung Chang
eturn with EINA_TRUE. "!st" is just precondition. i think it can be removed. but it's convenient. isn't it? > > > > -Regards, Hermet- > > > -Original Message- > From: "Hyoyoung Chang"<hyoyo...@gmail.

Re: [E-devel] [Patch][elm_gesture_layer] handling NULL in _tap_gesture_check_finish()

2012-05-16 Thread Hyoyoung Chang
Thanks, in svn - r71187. On Thu, May 17, 2012 at 10:14 AM, Kim Shinwoo wrote: > Dear All, Hello. > > There is a case that the Eina_List l; of Taps_Type would be NULL in > _tap_gesture_check_finish(). > If the below calls in the callback of gesture layer for > ELM_GESTURE_N_DOUBLE_TAPS with ELM_GE

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

2012-05-16 Thread Hyoyoung Chang
Thanks, in svn - r71187 On Thu, May 17, 2012 at 1:39 PM, Enlightenment SVN wrote: > Log: > elementary/gesture_layer: add to null check at _tap_gesture_check_finish > >  Signed-off-by: Kim Shinwoo > > > Author:       hyoyoung > Date:         2012-05-16 21:39:40 -0700 (Wed, 16 May 2012) > New Revi

Re: [E-devel] [Patch][elm_map] Add elm_map_overlays_get & elm_map_overlay_visible_get

2012-05-14 Thread Hyoyoung Chang
It works well, and pretty nice feature. diffs are good to me. In _overlay_show(Elm_Map_Overlay *overlay), there's many if statements. how about to change switch/case? On Fri, May 4, 2012 at 2:29 PM, Bluezery wrote: > Dear EFL developers, > > I want to add 2 new APIs (elm_map_overlays_get & elm_m

Re: [E-devel] Celebrating elementary 1.0

2012-05-01 Thread Hyoyoung Chang
On Wed, May 2, 2012 at 1:39 PM, Jérôme Pinot wrote: > On 04/20/12 20:11, Carsten Haitzler wrote: >> On Fri, 20 Apr 2012 20:05:19 +0900 Daniel Juyung Seo >> said: >> >> > On Apr 20, 2012 7:46 PM, "Jérôme Pinot" wrote: >> > > >> > > On 04/20/12 13:57, Daniel Juyung Seo wrote: >> > > > Wow.. 10 yea

Re: [E-devel] [Patch] elm_diskselector, set icon to added item

2012-04-27 Thread Hyoyoung Chang
On Fri, Apr 27, 2012 at 3:55 PM, cnook wrote: > Dear all, hello. > > I have tried to use the map with the diskselector. > The attached patch is just draft version for using map. Is it really draft version? imho, it's too good to be initial version. i just found few points which can be improved.

Re: [E-devel] [e-users] New EFL release cycle 1.0/1.2/1.6

2012-04-25 Thread Hyoyoung Chang
On Thu, Apr 26, 2012 at 2:07 PM, Michael Blumenkrantz wrote: > On Thu, 26 Apr 2012 14:04:37 +0900 > Carsten Haitzler (The Rasterman) wrote: > >> On Thu, 26 Apr 2012 14:02:26 +0900 Daniel Juyung Seo >> said: >> >> > yay! keep rocking. >> > this is gonna be a memorial dot in the history :) >> >> a

Re: [E-devel] efl release 24hr countdown

2012-04-24 Thread Hyoyoung Chang
Pass me elm bugs, I'll keep it for the next commiter :P anyway i'll check elm bugs in trac. i think it's better to clean trac issues in 24 hours. On Tue, Apr 24, 2012 at 4:01 PM, Daniel Juyung Seo wrote: > Report the bugs > Hyoyoung, a new commiter, will fix them :) > > Daniel Juyung Seo (Seo

Re: [E-devel] SVN access recommendation for Hyoyoung Chang

2012-04-23 Thread Hyoyoung Chang
; > > > -Original Message- > From: "Daniel Juyung Seo"<seojuyu...@gmail.com> > To: "Carsten Haitzler"<ras...@rasterman.com>; > Cc: "Enlightenment developer > list"<enlightenment-devel@lists.sourceforge.net>; > Sent: 201

Re: [E-devel] [patch] elm_genlist - bugfix remained selection in decorate all mode

2012-04-20 Thread Hyoyoung Chang
After discuss with seoz, i changed to not clean selections also i removed the new added internal func. Thanks On Fri, Apr 20, 2012 at 4:00 PM, Hyoyoung Chang wrote: > Dear all, > > I made a small patch to fix remained selection bug. > In decorate all mode, some item selection is

[E-devel] [patch] elm_genlist - bugfix abnormal exit in gengrid

2012-04-20 Thread Hyoyoung Chang
Dear all, After introduced flipped mode to genlist, some clearing process is added to _elm_genlist_item_unrealize. In item _elm_genlist_item_unrealize, item is casting to gengrid item or genlist item. segfault is occurred in _elm_genlist_item_unrealize at using gengrid. this patch moves flipped mo

[E-devel] [patch] elm_genlist - bugfix remained selection in decorate all mode

2012-04-20 Thread Hyoyoung Chang
Dear all, I made a small patch to fix remained selection bug. In decorate all mode, some item selection is not cleared after unset decorate all mode. I added to fix it. And make unselecting common routine to a internal function. Thanks. Index: elementary/src/lib/elm_genlist.c

Re: [E-devel] Introducing EFL Korean User Group

2012-04-19 Thread Hyoyoung Chang
I think it's not about nationality. just language. isn't it, guys? On Fri, Apr 20, 2012 at 11:29 AM, Jérôme Pinot wrote: > On 04/19/12 16:21, Daniel Juyung Seo wrote: >> Dear all, this is Daniel Juyung Seo. >> I introduce EFL Korean User Group, >> http://efl.or.kr >> >> This group is not a big co

[E-devel] [patch] elm_genlist - bugfix at item flipped

2012-04-18 Thread Hyoyoung Chang
Dear all I made a small patch about item flipped. It resolves two bugs 1. flip_set and unset is called quickly, sometimes genlist can't free flipped data. it fixed to remove checking flipped status in item unrealize 2. add item unhighlight at flip_job Thanks. gl_flip_bugfix.txt.diff Descripti

Re: [E-devel] [Patch][Ecore][Win32] Checking control character

2012-04-13 Thread Hyoyoung Chang
I have a question. is there any need to double check to VK_CONTROL? On Fri, Apr 13, 2012 at 6:15 PM, cnook wrote: > Dear All, Hello. > > The control characters are generated by holding down the Control key while > you strike another letter or symbol key. > Because of this reason, The Evas_Event_K

Re: [E-devel] question about elm_cnp_selection_set in elm_cnp

2012-04-13 Thread Hyoyoung Chang
k it can be removed > > > > > > -Regards, Hermet- > > > > > -Original Message- > From: "Hyoyoung Chang"<hyoyo...@gmail.com> > To: "Enlightenment developer > list"<enlightenment-devel@lists.sourceforge.net>; > Cc: > Sent: 2012-0

[E-devel] [patch] elm_genlist - some lines indent fixes

2012-04-13 Thread Hyoyoung Chang
Dear all, I fixed several lines indent. Also remove useless comments. Thanks. Index: src/lib/elm_genlist.c === --- src/lib/elm_genlist.c (리비전 70165) +++ src/lib/elm_genlist.c (작업 사본) @@ -730,13 +730,13 @@ _item_unhighligh

Re: [E-devel] question about elm_cnp_selection_set in elm_cnp

2012-04-12 Thread Hyoyoung Chang
it's image type. that means some null char can be contained in the buffer. it's not char string so its not need to null terminated. On Fri, Apr 13, 2012 at 2:01 PM, Minseok Kim wrote: > I have a question. > > elm_cnp.c : 418 > --

Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-04-12 Thread Hyoyoung Chang
How about to add that printing warning in elm_widget? On Thu, Apr 12, 2012 at 9:11 PM, Daniel Juyung Seo wrote: > You are right. We need to document this. > But this is also a notice for the e-dev. If there is no sign like this > someone will add setter again some time later without noticing why

Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-04-06 Thread Hyoyoung Chang
On Fri, Apr 6, 2012 at 4:10 PM, Enlightenment SVN wrote: > Log: > elm genlist: Get the stringlist only when it does not exist. Free the > stringlist when we change the item class. > > Author:       seoz > Date:         2012-04-06 00:10:29 -0700 (Fri, 06 Apr 2012) > New Revision: 69946 > Trac:    

Re: [E-devel] [Patch] elm_cnp notify_handler patch

2012-04-05 Thread Hyoyoung Chang
On Tue, Apr 3, 2012 at 6:37 PM, Minseok Kim wrote: > When pasting data to entry, notify_handler_text sent incorrect string. > Because notify_handler_text received string including garbage value. > Thus I cut string as its data length. It's caused from inconsistent by X11 and ecore_x. X11 api, some

[E-devel] [patch] elm_genlist - rename and fix typo error in internal variables (2/2)

2012-04-04 Thread Hyoyoung Chang
Dear all, It simple renaming patch for elm_genlist. I rename two variables. deco_all_obj -> deco_all_view deco_all_textss -> deco_all_texts Thanks 0002-fix-typo-of-deco_all_texts-rename-deco_all_obj-to-de.patch Description: Binary data --

[E-devel] [patch] elm_genlist - add functionality to elm_genlist_fields_update (1/2)

2012-04-04 Thread Hyoyoung Chang
Dear all, I made a patch for elm_genlist_fields_update to selective content update. a genlist item can update any content regardless of its mode. Thanks. PS: It assumed my previous patch is applied ([patch] elm_genlist - split flip content from item's content) 0001-add-_item_mode_content_reali

Re: [E-devel] Elm_list_go - why does it exist? + Do we really need elm_list?

2012-04-04 Thread Hyoyoung Chang
On Wed, Apr 4, 2012 at 9:46 PM, Tom Hacohen wrote: > Hey, > > I think I've already asked those questions before, but the release is a > good time to review them again and make sure we like everything. > > First and foremost, why do we have elm_list_go, or more correctly, why > do we only have it i

[E-devel] [patch] elm_genlist - split flip content from item's content

2012-04-04 Thread Hyoyoung Chang
Dear all, in genlist flip mode, a item shares its content and flip content. it's split flip content patch. Thanks. 0001-split-flip-objects-from-item-s-contents.patch Description: Binary data -- Better than sec? Nothing

[E-devel] [patch] elm_genlist - renaming vars/funcs - mode_set -> decorate_it_set

2012-04-02 Thread Hyoyoung Chang
Dear all It renames genlist internal variables and functions. decorate_type -> decorate_it_type mode_set -> decorate_it_set It also includes that a api arguments' naming is changed. -EAPI void elm_genlist_item_decorate_mode_set(Elm_Object_Item *it, const char *mode_type, Eina_Bool mode_set); +EA

Re: [E-devel] [patch] elm_genlist - renaming vars - mode_view -> deco_it_view (1/3)

2012-04-02 Thread Hyoyoung Chang
Oops sorry. Adding attachment patch file. On Mon, Apr 2, 2012 at 8:36 PM, Hyoyoung Chang wrote: > Dear all > > it renames genlist internal variables. > > mode_view ->deco_it_view > decorate_mode_item_realized->decorate_all_item_realized > > thanks.

[E-devel] [patch] elm_genlist - renaming _decorate_mode to _decorate_all_mode (2/3)

2012-04-02 Thread Hyoyoung Chang
Dear all It renames genlist internal variables/functions. decorate_mode->decorate_all_mode _decorate_mode_item_*->_decorate_all_item_* thanks. 0002-rename-_decorate_mode-to-_decorate_all_mode.patch Description: Binary data ---

[E-devel] [patch] elm_genlist - renaming vars - mode_view -> deco_it_view (1/3)

2012-04-02 Thread Hyoyoung Chang
Dear all it renames genlist internal variables. mode_view ->deco_it_view decorate_mode_item_realized->decorate_all_item_realized thanks. -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here

Re: [E-devel] [patch] elm_genlist - renaming internal variables from "edit_" to "deco_"

2012-03-30 Thread Hyoyoung Chang
I talked with seoz. and agreed with previous naming changing is insufficient. so changed like this "mode_" -> "deco_it_" "edit_" -> "deco_all_" Thanks On Fri, Mar 30, 2012 at 3:33 PM, Hyoyoung Chang wrote: > Dear all, > > After edit mode

Re: [E-devel] Infinite loop ...

2012-03-30 Thread Hyoyoung Chang
(SeoZ) > > On Fri, Mar 30, 2012 at 10:49 AM, Hyoyoung Chang wrote: >> I checked this issue. >> In evas_free(), infinite loop is occurred >> >>   while (del) >>     { >>        del = 0; >>        EINA_INLIST_FOREACH(e->layers, lay) >

[E-devel] [patch] elm_genlist - renaming internal variables from "edit_" to "deco_"

2012-03-29 Thread Hyoyoung Chang
Dear all, After edit mode naming is changed, some legacy naming is remained. I changed naming to follow API naming changes. "edit_" -> "deco_" and also some explicit edc part names are changed. Some naming are remained as is, I'll fix at next patches. Thanks. Index: elementary/src/lib/elm_genli

Re: [E-devel] Infinite loop ...

2012-03-29 Thread Hyoyoung Chang
I checked this issue. In evas_free(), infinite loop is occurred while (del) { del = 0; EINA_INLIST_FOREACH(e->layers, lay) { Evas_Object *o; evas_layer_pre_free(lay); EINA_INLIST_FOREACH(lay->objects, o) {

[E-devel] [patch] elm_genlist - bugfix losting content_objs at flip_realize

2012-03-29 Thread Hyoyoung Chang
Dear all I made a patch about flip_realize. Currently flip feature uses content_objs, so it should keep its content_objs. However it's lost at _item_flips_realize(). So i fixed to initialize with its content_objs. Thanks Index: elementary/src/lib/elm_genlist.c

[E-devel] [patch] bugfix infinite loop in _elm_win_obj_callback_del

2012-03-28 Thread Hyoyoung Chang
Dear all, SeungGyun and I found infinite loop in _elm_win_obj_callback_del. It calls evas_object_del() to remove evas objects in evas. However sometimes, there're several objects (which its reference count is greater than 1) that aren't deleted. To fix that, I added two evas apis, and changed som

Re: [E-devel] [patch] elm_genlist - add merging edc strings list

2012-03-25 Thread Hyoyoung Chang
On Sun, Mar 25, 2012 at 5:19 PM, Daniel Juyung Seo wrote: > Hello, > > On Sun, Mar 25, 2012 at 4:42 PM, Hyoyoung Chang wrote: >> in most of cases, Daniel is right. >> But i added this for item_fields_update >> >>   if ((!itf) || (itf & ELM_GENLIST_ITEM_F

Re: [E-devel] [patch] elm_genlist - add merging edc strings list

2012-03-25 Thread Hyoyoung Chang
need to merge source(which is NULL) and cons here. Just use source. >> >> Daniel Juyung Seo (SeoZ) > > ti looks cleaner though imho. :) > >> On Sat, Mar 24, 2012 at 8:15 PM, Carsten Haitzler >> wrote: >> > On Fri, 23 Mar 2012 19:19:55 +0900 Hyoyoung Chang >

Re: [E-devel] E SVN: raster trunk/elementary

2012-03-24 Thread Hyoyoung Chang
hooray 1.0 \0/ On Sat, Mar 24, 2012 at 8:14 PM, Enlightenment SVN wrote: > Log: > update configure/readme for 1.0 alpha > > > > Author:       raster > Date:         2012-03-24 04:14:41 -0700 (Sat, 24 Mar 2012) > New Revision: 69599 > Trac:         http://trac.enlightenment.org/e/changeset/69599 >

[E-devel] [patch] elm_genlist - add merging edc strings list

2012-03-23 Thread Hyoyoung Chang
Dear all I add like a routine in previous patch. It add merging routines to realize functions. also i removed "elm_widget_stringlist_free(cons)" because all of it is freed at item_unrealize. Thanks Index: elementary/src/lib/elm_genlist.c ===

Re: [E-devel] [Patch][elementary] elc_ctxpopup using elm_list internally.

2012-03-21 Thread Hyoyoung Chang
yeap, it seems nice. btw, i have a question. - if (eina_list_count(wd->items) < 1) + list = elm_object_item_widget_get(ctxpopup_it->list_item); + + if (eina_list_count(elm_list_items_get(list)) < 2) { +elm_object_item_del(ctxpopup_it->list_item); evas_object_hide(WIDGE

Re: [E-devel] [Patch][elm_list] bug fix: crash occurs when container which contains the elm_list is deleted on the "elm_list item clicked" callback

2012-03-21 Thread Hyoyoung Chang
I think previous your mail is in another your mail account :P btw, i have a question. +if (it->icon) + evas_object_event_callback_del(it->icon, + EVAS_CALLBACK_CHANGED_SIZE_HINTS, + _changed_size_hi

[E-devel] [patch] els_scroller

2012-03-20 Thread Hyoyoung Chang
Dear all, At early calling gravity_set in els_scroller, segfault can be occurred. because in smart_add, there's no gravity_set/get func ptr set. This patch resolves the bug. Thanks Index: elementary/src/lib/els_scroller.c === --- ele

Re: [E-devel] [patch] elm_genlist - bugfix at flip_realize

2012-03-20 Thread Hyoyoung Chang
oops sorry. in diff, i did a mistakes it's refined version. On Tue, Mar 20, 2012 at 4:43 PM, Sanjeev BA wrote: > how does EINA_LIST_FOREACH(*source, l, key) work without initializing > *source ? > > On Tue, Mar 20, 2012 at 4:31 PM, Hyoyoung Chang wrote: > >> Dear a

[E-devel] [patch] elm_genlist - bugfix at flip_realize

2012-03-20 Thread Hyoyoung Chang
Dear all, I found a bug in _item_flip_realize. It replaces previous string list without free. this patch fixed for it. Thanks Index: elementary/src/lib/elm_genlist.c === --- elementary/src/lib/elm_genlist.c(리비전 69518) +++ element

Re: [E-devel] [Patch][Genlist] Add the moved.after/before signal instead of moved

2012-03-19 Thread Hyoyoung Chang
It seems nice except signal separator is "." How about change to "," from "."? other genlist signals uses "," as a naming separator. Also I think it's better gengrid also changed like this patch in next time :D On Tue, Mar 20, 2012 at 2:46 PM, chanwook jung wrote: > Dear all, > > Some application

Re: [E-devel] elm_scroller_gravity weirdness

2012-03-19 Thread Hyoyoung Chang
On Mon, Mar 19, 2012 at 8:07 PM, Leif Middelschulte wrote: > 2012/3/19 Hyoyoung Chang : >> On Mon, Mar 19, 2012 at 1:20 AM, Leif Middelschulte >> wrote: >>> 2012/3/18 Hyoyoung Chang : >>>> Hello >>>> >>>> I think the behavior of sc

[E-devel] [patch] elm_genlist - bugfix at item_state_update

2012-03-19 Thread Hyoyoung Chang
Dear all, I fixed minor error in _elm_genlist_item_state_update. If item is selected, it sends signal to item and edit_obj. But edit_obj is not checked by if statement. I added a parenthesis for it. Thanks Index: elementary/src/lib/elm_genlist.c ===

[E-devel] [patch] elm_genlist - bugfix at decorate mode

2012-03-18 Thread Hyoyoung Chang
Dear all, I found a bug in decorate mode that selection callback is called twice. Because two _mouse_down callbacks are added to a genlist item. I'm fixing this bug and some refactoring. Thanks. Index: elementary/src/lib/elm_genlist.c ==

Re: [E-devel] elm_scroller_gravity weirdness

2012-03-18 Thread Hyoyoung Chang
On Mon, Mar 19, 2012 at 1:20 AM, Leif Middelschulte wrote: > 2012/3/18 Hyoyoung Chang : >> Hello >> >> I think the behavior of scroller gravity is similar with edje. >> If y is set as 1.0, then scroller sticks bottom of its parent. > Parent? I guess the common perce

Re: [E-devel] elm_scroller_gravity weirdness

2012-03-18 Thread Hyoyoung Chang
Hello I think the behavior of scroller gravity is similar with edje. If y is set as 1.0, then scroller sticks bottom of its parent. At the document of api, yes i agree. it's ambiguous what's doing. Maybe the comment should be updated clearly. It's better to more be elaborate with examples. On Mo

Re: [E-devel] [patch] elm_genlist - add checking at show_item and widget type at calc_job

2012-03-14 Thread Hyoyoung Chang
d at any time. > If the "obj" is NULL in _calc_job, somewhere else must be wrong. > Can you check that point again? > > Daniel Juyung Seo (SeoZ) > > > On Wed, Mar 14, 2012 at 3:09 PM, Hyoyoung Chang wrote: >> Dear all. >> >> This patch include two c

[E-devel] [patch] elm_genlist - add checking at show_item and widget type at calc_job

2012-03-13 Thread Hyoyoung Chang
Dear all. This patch include two changes 1. at _scroll_item, added to check show_item is null or not. 2. at _calc_job, added to check genlist type because calc_job is added anytime, but some genlist clearing is can be done before doing calc_job. Thanks. Index: elementary/src/lib/elm_genlist.c

[E-devel] [patch] replace elm_genlist_item_object_get api

2012-03-13 Thread Hyoyoung Chang
Dear all. due to elm_genlist_item_object_get() is deprecated, I made a patch to replace them to adequate apis. most of case is sending signal. Thanks. Index: eve/src/bin/chrome.c === --- eve/src/bin/chrome.c(리비전 69309) +++ ev

[E-devel] [patch] elm_genlist - bugfix at genlist _item_select

2012-03-13 Thread Hyoyoung Chang
Dear all, In _item_select, some if conditional is not working as user intention. always_select mode checking is reversed and no-select mode is not checked. I add and fix it. Thanks Index: elementary/src/lib/elm_genlist.c === --- eleme

Re: [E-devel] [patch] building error fix at using gen{list, grid} functions

2012-03-12 Thread Hyoyoung Chang
Some active guys changed build errors. So i re-summit patch On Fri, Mar 9, 2012 at 3:23 PM, Hyoyoung Chang wrote: > Dear all, > > After elm radically changed, some compilation errors are not fixed. > I changed for this. > > 1. add a parameter for item_bring_in > -elm_gen

[E-devel] [patch] elm_genlist - add item signal emit hook

2012-03-09 Thread Hyoyoung Chang
Dear all. This is a patch about genlist to add item signal emit hook. due to elm_genlist_item_object_get is deprecated, item sinal emit hook should be supported. So it's added. + elm_widget_item_signal_emit_hook_set(it, _item_signal_emit_hook); Thanks Index: elementary/src/lib/elm_genlist.c ==

[E-devel] [patch] building error fix at using gen{list, grid} functions

2012-03-08 Thread Hyoyoung Chang
Dear all, After elm radically changed, some compilation errors are not fixed. I changed for this. 1. add a parameter for item_bring_in -elm_genlist_item_bring_in(it); +elm_genlist_item_bring_in(it, ELM_GENLIST_ITEM_SCROLLTO_IN); 2. change a enum type name - Elm_Genlist_Item_Flags + Elm_Genli

[E-devel] [patch] ephoto - resolve build errors

2012-03-08 Thread Hyoyoung Chang
Dear all In ephoto, elm_gengrid_item_bring_in is used. However some days ago, many changes was committed to elm. Also it's parameters are changed. It's patch for this. Thanks Index: ephoto/src/bin/ephoto_main.c === --- ephoto/src/bin

Re: [E-devel] ephoto fail

2012-03-08 Thread Hyoyoung Chang
Yeah you're right. elm_gengrid_item_bring_in's parameters is changed. added one more parameter to call bring_in to dest. I'll send a patch for this Thanks On Fri, Mar 9, 2012 at 1:15 AM, Dave Ray wrote: > Hi, > I am guessing that ephoto is now out if sync with all the elm changes > yesterday.

[E-devel] [patch] elm_gengrid - add item_select_mode_set/get apis

2012-03-07 Thread Hyoyoung Chang
Dear all, I made a item_select_mode_set/get in elm_gengrid. It works like genlist_item_select_mode apis. +EAPI void +elm_gengrid_item_select_mode_set(Elm_Object_Item *it, + Elm_Object_Select_Mode mode) +EAPI Elm_Object_Select_Mode +elm_gengrid_item_select_mode_get(

[E-devel] [patch] Elm_Object_Select_Mode comment update

2012-03-07 Thread Hyoyoung Chang
Dear all. After updated Elm_Object_Select_Mode naming, some comments are outdated. I changed it. Thanks. Index: src/lib/elm_genlist.h === --- src/lib/elm_genlist.h (리비전 69008) +++ src/lib/elm_genlist.h (작업 사본) @@ -193,9

[E-devel] [patch] elm_genlist - fix display_only_set comment

2012-03-07 Thread Hyoyoung Chang
Dear all I fixed some typos in comments about display_only_set mode. Thanks. Index: elementary/src/lib/elm_genlist.h === --- elementary/src/lib/elm_genlist.h(리비전 69006) +++ elementary/src/lib/elm_genlist.h(작업 사본) @@ -1830,11

[E-devel] [patch] elm_web - using elm_list_select_mode

2012-03-07 Thread Hyoyoung Chang
Dear all it's one line patch about elm_web to use select_mode. - elm_list_always_select_mode_set(list, EINA_TRUE); + elm_list_select_mode_set(data, ELM_OBJECT_SELECT_MODE_ALWAYS); Index: elementary/src/lib/elm_web.c === --- elem

[E-devel] [patch] elm_genlist - fix typos and remove display_only variable

2012-03-07 Thread Hyoyoung Chang
Dear all. I found a mistake in example. and display_only value is remained. It's fixed some trivial errors. Thanks. Index: elementary/src/lib/elm_gen_common.h === --- elementary/src/lib/elm_gen_common.h (리비전 68995) +++ elementary/src

[E-devel] [patch] elm_genlist - add item_select_mode_set/get

2012-03-07 Thread Hyoyoung Chang
Dear all I added two apis for item selecting mode. It almost same with elm_genlist_select_mode. +EAPI void +elm_genlist_item_select_mode_set(Elm_Object_Item *it, + Elm_Object_Select_Mode_Type mode) +EAPI Elm_Object_Select_Mode_Type +elm_genlist_item_select_mode_ge

[E-devel] [patch] elm_list - add select_mode_set and some remove deprecated apis in examples

2012-03-07 Thread Hyoyoung Chang
Dear all. Like other widget (genlist, gengrid...), I add select_mode to elm_list. +elm_list_select_mode_set(Evas_Object *obj, Elm_Object_Select_Mode_Type mode) +EAPI Elm_Object_Select_Mode_Type +elm_list_select_mode_get(const Evas_Object *obj) And I removed deprecated apis (no_select, always_se

[E-devel] [patch] elm_gengrid - add item_index_get func

2012-03-07 Thread Hyoyoung Chang
Dear all. I made a patch that's adding elm_gengrid_item_index_get function. +EAPI int +elm_gengrid_item_index_get(const Elm_Object_Item *it) It works like elm_genlist_item_index_get() Thanks From 0d4e445288c21768541cffae58ad40af2e319c09 Mon Sep 17 00:00:00 2001 From: Hyoyoung Chang Date

[E-devel] [patch] gengrid - Some missing APIs is added

2012-03-07 Thread Hyoyoung Chang
*obj); Thanks From 5eb24212f94c5441209ab0bb936f6dd002c23e6e Mon Sep 17 00:00:00 2001 From: Hyoyoung Chang Date: Wed, 7 Mar 2012 17:58:19 +0900 Subject: [PATCH 2/3] [gengrid] add scroller_policy_set/get --- src/lib/elm_gengrid.c | 28 src/lib/elm_gengrid.h | 36

[E-devel] [patch] elm_genlist - add no_finger_size_calc and item_select_mode

2012-03-06 Thread Hyoyoung Chang
(git, ELM_OBJECT_NO_SELECT); Thanks From 250410d0d8c92773eefb7350d0f570da64c34893 Mon Sep 17 00:00:00 2001 From: Hyoyoung Chang Date: Wed, 7 Mar 2012 15:33:17 +0900 Subject: [PATCH] [genlist] add item finger size calc and item select mode api --- src/bin/test_genlist.c | 11 +++- src/lib

[E-devel] [patch] elm_gen{list, grid} - add no_highlight_mode_set/get

2012-03-06 Thread Hyoyoung Chang
From f63ea71832d6749a36fc512d19b65a2a9a636cea Mon Sep 17 00:00:00 2001 From: Hyoyoung Chang Date: Wed, 7 Mar 2012 14:09:38 +0900 Subject: [PATCH] [gen{list,grid] add no_highlight_mode_set/get --- src/lib/elm_gen_common.h |1 + src/lib/elm_gengrid.c| 18 +- src/lib/elm_gengrid.h|

[E-devel] [patch] elm_toolbar - add elm_toolbar_select_mode_set

2012-03-06 Thread Hyoyoung Chang
a142aa78adb517040eda911e4ade5c9626bb5bf0 Mon Sep 17 00:00:00 2001 From: Hyoyoung Chang Date: Wed, 7 Mar 2012 13:51:13 +0900 Subject: [PATCH] add select_mode in toolbar --- src/bin/test_toolbar.c |2 +- src/lib/elm_deprecated.h | 64 + src/lib/elm_toolbar.c| 79

Re: [E-devel] [patch] elm_gen{list, grid} - add elm_genlist_select_mode_set

2012-03-06 Thread Hyoyoung Chang
Oops i missed attachment. sorry. On Wed, Mar 7, 2012 at 1:36 PM, Hyoyoung Chang wrote: > Dear all > > As discussed in irc, I made a patch about unifying > always_select_mode_set and no_select_mode_set. > > I'm introducing two apis in genlist (also in

[E-devel] [patch] elm_gen{list, grid} - add elm_genlist_select_mode_set

2012-03-06 Thread Hyoyoung Chang
Dear all As discussed in irc, I made a patch about unifying always_select_mode_set and no_select_mode_set. I'm introducing two apis in genlist (also in gengrid) +EAPI void +elm_genlist_select_mode_set(Evas_Object *obj, Elm_Object_Select_Mode_Type mode) +EAPI Elm_Object_Select_Mode_Type +elm_gen

[E-devel] [patch] elm_genlist - add comments for item class

2012-03-05 Thread Hyoyoung Chang
Dear all. after working several hours, i made some comments. :P If it's only, plz comit it. Thanks. Index: elementary/src/lib/elm_genlist.h === --- elementary/src/lib/elm_genlist.h(리비전 68783) +++ elementary/src/lib/elm_genlist.h

Re: [E-devel] [patch] elm_genlist - add item flip set/get

2012-03-05 Thread Hyoyoung Chang
Hello, I modifed fliP_set api to use ecore_job. It resolved version of mouse_{move, up} bugs. On Sun, Mar 4, 2012 at 2:47 PM, Hyoyoung Chang wrote: > As discussed in irc, i modified and removed draggable in flip mode. > > @@ -975,6 +975,8 @@ _mouse_move(void        *data, >    if (

Re: [E-devel] [patch] elm_genlist - add item flip set/get

2012-03-03 Thread Hyoyoung Chang
ing = EINA_TRUE; What do you think about it? If it's not a good idea, i think flip mode should have only one item. On Sat, Mar 3, 2012 at 1:39 PM, Hyoyoung Chang wrote: > On Fri, Mar 2, 2012 at 7:39 PM, Daniel Juyung Seo > wrote: >> Thanks for your patch. >> Everything is fine

Re: [E-devel] [patch] elm_genlist - add item flip set/get

2012-03-02 Thread Hyoyoung Chang
n how about to define flipped item would not draggable? Or as i think we should restrict to only one flipped mode item. What do you think so? > > Thanks. > > Daniel Juyung Seo (SeoZ) > > On Fri, Mar 2, 2012 at 5:14 PM, Hyoyoung Chang wrote: >> I attached improved version of fli

Re: [E-devel] [patch] elm_genlist - add item flip set/get

2012-03-02 Thread Hyoyoung Chang
I attached improved version of flip patch Thanks On Thu, Mar 1, 2012 at 10:52 PM, Hyoyoung Chang wrote: > First of all, thanks for detailed review > > On Thu, Mar 1, 2012 at 3:01 PM, Daniel Juyung Seo > wrote: >> Thanks Hyoyoung, overall it looks good :) >> I have some

Re: [E-devel] [patch] elm_genlist - add item flip set/get

2012-03-01 Thread Hyoyoung Chang
>     if (_it->flipped) < do not need to check this >     else >  } First checking is to verify changed. Second checking is about previous status. So It leaves at it is. I don't think it's good or clean code either. But checking is right. Maybe it should be re-written to

[E-devel] [patch] elm_genlist - add item flip set/get

2012-02-29 Thread Hyoyoung Chang
Dear all. I made a patch to introduce new genlist item mode. Two public apis are added. +EAPI void elm_genlist_item_flip_set(Elm_Object_Item *it, Eina_Bool flip); +EAPI Eina_Bool elm_genlist_item_flip_get(Elm_Object_Item *it); It provides on-the-flying item change. It works like that a new item a

[E-devel] [patch] elm_cnp - revise apis

2012-02-27 Thread Hyoyoung Chang
Dear all. I made a small patch about revise cnp apis. It changed argument orders of apis to consistence and make elm widget centric. now all cnp api's first argument is a elm widget. It breaks api compatibility. so elementarychanges is needed to update. thanks. Index: elementary/src/lib/elm_entry

[E-devel] [patch] elm_cnp - revise document

2012-02-27 Thread Hyoyoung Chang
Dear all. As i said earlier, elm_cnp's document is revised. I add information about x11 and make some comment clear. Thanks Index: elementary/src/lib/elm_cnp.h === --- elementary/src/lib/elm_cnp.h(리비전 68487) +++ elementary/sr

  1   2   3   >