On Tue, Jul 25, 2006 at 09:29:14AM +0900, Carsten Haitzler wrote:
> a quick scan of the patch - coding style. we can argue forever which is
> best/right/wrong - but we won't. follow the existing style. i.e.
> if (x)
> {
> blah(x);
> blah(y);
> }
I thought the existing style
While trying to compile ecore on OpenBSD, the build failed on
ecore_con_dns.c because OpenBSD doesn't have ,
but commenting out that include line lets it build fine.
While looking through the file, I looked at ecore_con_dns_lookup, and it
looks like fd[1] is leaked whenever the function is succ
On Sat, Jun 10, 2006 at 07:20:47PM +0200, Kim Woelders wrote:
> I forgot to mention - I think I have seen cases where c is zero. I'm not
> sure malloc(0) always is legal.
It's legal. Thus spake POSIX[1]:
If size is 0, either a null pointer or a unique pointer that can be
successfully p
On Sat, Jun 10, 2006 at 07:13:33PM +0200, Kim Woelders wrote:
> > --- ecore_x_icccm.c 8 Jun 2006 20:03:42 - 1.43
> > +++ ecore_x_icccm.c 10 Jun 2006 16:54:36 - 1.44
> > @@ -752,8 +752,12 @@
> > if (argc) *argc = c;
> > if (argv)
> > {
> > - (*argv) = malloc(c);
>
On Tue, May 02, 2006 at 10:50:16AM +0300, [EMAIL PROTECTED] wrote:
> Hosting is slow so please be patient.
I've mirrored the PDF at http://utdlug.org/~mdempsky/concepts.pdf
> give me some feedback...
Overall, I think it looks good so far.
In many places, you use ``OpenGl'' instead of ``OpenGL''
