Re: [E-devel] [EGIT] [core/efl] master 01/03: evas - fix gl egl textrue from pixmap support y invert query extension

2013-12-04 Thread Stanislav Vorobiov
that extension if that driver is found. i don't know what specific driver strings you have there so i can't write a blacklist for you, but i suspect you want to file a bug with mesa/driver/xorg devs :) On Nov 29, 2013, at 8:08, Stanislav Vorobiov s.vorob...@samsung.com wrote: raster pushed a commit

Re: [E-devel] [PATCH] evas - use EGL_NOK_texture_from_pixmap to get yinvert value when possible

2013-11-28 Thread Stanislav Vorobiov
That's all reasonable, I'll make patch v3 then On 11/28/2013 11:44 AM, Carsten Haitzler (The Rasterman) wrote: On Thu, 28 Nov 2013 09:59:41 +0400 Stanislav Vorobiov s.vorob...@samsung.com said: the patch itself... why the #ifdef? when checking for extensions, we look for strings

[E-devel] [PATCH v3] evas - use EGL_NOK_texture_from_pixmap to get yinvert value when possible

2013-11-28 Thread Stanislav Vorobiov
Instead of hardcoding yinvert=1 we should query for EGL_NOK_texture_from_pixmap extension and if it's present use EGL_Y_INVERTED_NOK value --- src/modules/evas/engines/gl_x11/evas_engine.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git

Re: [E-devel] [PATCH v3] evas - use EGL_NOK_texture_from_pixmap to get yinvert value when possible

2013-11-28 Thread Stanislav Vorobiov
:02:36 +0400 Stanislav Vorobiov s.vorob...@samsung.com said: and that looks great! well done! :) now the question is... is this a new feature.. or a bug fix... hmm i guess it's a bug fix as it makes something work given specific drivers and setup that didn't work before, BUT needs

Re: [E-devel] [PATCH v3] evas - use EGL_NOK_texture_from_pixmap to get yinvert value when possible

2013-11-28 Thread Stanislav Vorobiov
IMHO it's a standard bug, but nobody cares :) On 11/28/2013 02:53 PM, Carsten Haitzler (The Rasterman) wrote: On Thu, 28 Nov 2013 13:33:42 +0400 Stanislav Vorobiov s.vorob...@samsung.com said: Yes, I think it's more of a bugfix. After all, there's no EGL standard that strictly defines how

Re: [E-devel] [PATCH v3] evas - use EGL_NOK_texture_from_pixmap to get yinvert value when possible

2013-11-28 Thread Stanislav Vorobiov
:01:02 +0400 Stanislav Vorobiov s.vorob...@samsung.com said: yeah.. i've hit those before. gles2's runtime glsl compiler is optional thing imho is a major standard bug. anyway - this is in upstream! merged. it'll be out in 1.8. my mulling over if it was a bug or not was to determine

Re: [E-devel] [PATCH v3] evas - use EGL_NOK_texture_from_pixmap to get yinvert value when possible

2013-11-28 Thread Stanislav Vorobiov
2013 15:01:02 +0400 Stanislav Vorobiov s.vorob...@samsung.com said: yeah.. i've hit those before. gles2's runtime glsl compiler is optional thing imho is a major standard bug. anyway - this is in upstream! merged. it'll be out in 1.8. my mulling over if it was a bug

[E-devel] [PATCH] evas - use EGL_NOK_texture_from_pixmap to get yinvert value when possible

2013-11-27 Thread Stanislav Vorobiov
Instead of hardcoding yinvert=1 we should query for EGL_NOK_texture_from_pixmap extension and if it's present use EGL_Y_INVERTED_NOK value --- src/modules/evas/engines/gl_x11/evas_engine.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git

[E-devel] [PATCH] evas - use EGL_NOK_texture_from_pixmap to get yinvert value

2013-11-27 Thread Stanislav Vorobiov
, val); im-native.yinvert = val; For EGL however it assumes they're always inverted, i.e: im-native.yinvert = 1; This patch makes use of EGL_Y_INVERTED_NOK when available to do similar stuff in EGL Stanislav Vorobiov (1): evas - use EGL_NOK_texture_from_pixmap to get yinvert value when

Re: [E-devel] [PATCH] evas - use EGL_NOK_texture_from_pixmap to get yinvert value

2013-11-27 Thread Stanislav Vorobiov
list Cc: Stanislav Vorobiov; kyungmin.p...@samsung.com; e.voevo...@samsung.com Subject: Re: [E-devel] [PATCH] evas - use EGL_NOK_texture_from_pixmap to get yinvert value On Wed, 27 Nov 2013 15:39:05 +0400 Stanislav Vorobiov s.vorob...@samsung.com said: i'm curious. when did you run

Re: [E-devel] [PATCH] evas - use EGL_NOK_texture_from_pixmap to get yinvert value when possible

2013-11-27 Thread Stanislav Vorobiov
Stanislav Vorobiov s.vorob...@samsung.com said: the patch itself... why the #ifdef? when checking for extensions, we look for strings, and not defined macros. also extension checks are done in gl_extn_veto () (which lets us go assume an extension is there then veto it if its not and save

[E-devel] [PATCH v2] evas - use EGL_NOK_texture_from_pixmap to get yinvert value when possible

2013-11-27 Thread Stanislav Vorobiov
Instead of hardcoding yinvert=1 we should query for EGL_NOK_texture_from_pixmap extension and if it's present use EGL_Y_INVERTED_NOK value --- src/modules/evas/engines/gl_x11/evas_engine.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git