Re: [E-devel] [EGIT] [core/efl] master 01/01: Eo: Make sure semi-colons and other directives aren't used in eo_add.

2016-04-15 Thread Cedric BAIL
On Fri, Apr 15, 2016 at 5:53 AM, Tom Hacohen wrote: > tasn pushed a commit to branch master. > > http://git.enlightenment.org/core/efl.git/commit/?id=7c5f81d30f8f2960862daf912a833a096cef6c6b > > commit 7c5f81d30f8f2960862daf912a833a096cef6c6b > Author: Tom Hacohen > Date: Fri Apr 15 13:52:32 20

Re: [E-devel] [EGIT] [core/efl] master 01/01: Eo: Make sure semi-colons and other directives aren't used in eo_add.

2016-04-15 Thread Andrew Williams
Agreed, warnings everywhere - looked serious enough that I thought I'd broken elm_code :( Andy On Fri, 15 Apr 2016 at 19:05, Cedric BAIL wrote: > On Fri, Apr 15, 2016 at 5:53 AM, Tom Hacohen wrote: > > tasn pushed a commit to branch master. > > > > > http://git.enlightenment.org/core/efl.git/co

Re: [E-devel] [EGIT] [core/efl] master 01/01: Eo: Make sure semi-colons and other directives aren't used in eo_add.

2016-04-17 Thread Tom Hacohen
Revert it then. This is the change I intended to do, and of course I compiled test it. I have nothing, but I'm using clang. This code is correct! Just so I know though, what's the warning? On Sat, Apr 16, 2016 at 1:13 AM, Andrew Williams wrote: > Agreed, warnings everywhere - looked serious enou

Re: [E-devel] [EGIT] [core/efl] master 01/01: Eo: Make sure semi-colons and other directives aren't used in eo_add.

2016-04-17 Thread Felipe Magno de Almeida
Hello Tom, It seems to have stopped complained when I changed to: # define _eo_add_common(klass, parent, is_ref, ...) \ ({ \ Eo * const __eo_self = _eo_add_internal_start(__FILE__, __LINE__, klass, parent, is_ref, EINA_FALSE); \ - (void) (0, ##__VA_ARGS__);