Re: [E-devel] [EGIT] [core/efl] master 01/01: edje: calc - remove pointer comparison while finding part desc

2015-12-10 Thread The Rasterman
On Thu, 10 Dec 2015 22:07:50 +0530 Amitesh Singh said: > On Dec 10, 2015 4:32 AM, "Carsten Haitzler" wrote: > > > > On Wed, 9 Dec 2015 20:39:30 +0530 Amitesh Singh > said: > > > > > On Dec 9, 2015 6:20 PM, "Tom Hacohen"

Re: [E-devel] [EGIT] [core/efl] master 01/01: edje: calc - remove pointer comparison while finding part desc

2015-12-10 Thread Amitesh Singh
On Dec 10, 2015 4:32 AM, "Carsten Haitzler" wrote: > > On Wed, 9 Dec 2015 20:39:30 +0530 Amitesh Singh said: > > > On Dec 9, 2015 6:20 PM, "Tom Hacohen" wrote: > > > > > > On 09/12/15 12:40, Mike Blumenkrantz wrote: > > > > I

Re: [E-devel] [EGIT] [core/efl] master 01/01: edje: calc - remove pointer comparison while finding part desc

2015-12-09 Thread Tom Hacohen
On 09/12/15 12:40, Mike Blumenkrantz wrote: > I can confirm that Vyacheslav is correct, and even if he did not mention > stringshare, this change is still wrong on a fundamental level. > > Please revert it. What really stands out in this change, is that I don't get the reason for it. Why was it

Re: [E-devel] [EGIT] [core/efl] master 01/01: edje: calc - remove pointer comparison while finding part desc

2015-12-09 Thread Vyacheslav Reutskiy
Hello, I'm not sure that this changes is correct. The 'state_name' can be pointer to eina_stringshare and comparing the two pointers faster than strcmp. This fix looks doubtful. -- Viacheslav Reutskiy (rimmed) On Wed, Dec 9, 2015 at 12:20 PM, Amitesh Singh wrote: > ami

Re: [E-devel] [EGIT] [core/efl] master 01/01: edje: calc - remove pointer comparison while finding part desc

2015-12-09 Thread Mike Blumenkrantz
I can confirm that Vyacheslav is correct, and even if he did not mention stringshare, this change is still wrong on a fundamental level. Please revert it. On Wed, Dec 9, 2015 at 7:08 AM Vyacheslav Reutskiy wrote: > Hello, > > I'm not sure that this changes is correct.

Re: [E-devel] [EGIT] [core/efl] master 01/01: edje: calc - remove pointer comparison while finding part desc

2015-12-09 Thread Amitesh Singh
On Dec 9, 2015 6:20 PM, "Tom Hacohen" wrote: > > On 09/12/15 12:40, Mike Blumenkrantz wrote: > > I can confirm that Vyacheslav is correct, and even if he did not mention > > stringshare, this change is still wrong on a fundamental level. > > > > Please revert it. > > What

Re: [E-devel] [EGIT] [core/efl] master 01/01: edje: calc - remove pointer comparison while finding part desc

2015-12-09 Thread Tom Hacohen
On 09/12/15 15:09, Amitesh Singh wrote: > On Dec 9, 2015 6:20 PM, "Tom Hacohen" wrote: >> >> On 09/12/15 12:40, Mike Blumenkrantz wrote: >>> I can confirm that Vyacheslav is correct, and even if he did not mention >>> stringshare, this change is still wrong on a fundamental

Re: [E-devel] [EGIT] [core/efl] master 01/01: edje: calc - remove pointer comparison while finding part desc

2015-12-09 Thread The Rasterman
On Wed, 9 Dec 2015 20:39:30 +0530 Amitesh Singh said: > On Dec 9, 2015 6:20 PM, "Tom Hacohen" wrote: > > > > On 09/12/15 12:40, Mike Blumenkrantz wrote: > > > I can confirm that Vyacheslav is correct, and even if he did not mention > > >