On Thu, 10 Dec 2015 22:07:50 +0530 Amitesh Singh said:
> On Dec 10, 2015 4:32 AM, "Carsten Haitzler" wrote:
> >
> > On Wed, 9 Dec 2015 20:39:30 +0530 Amitesh Singh
> said:
> >
> > > On Dec 9, 2015 6:20 PM, "Tom Hacohen"
On Dec 10, 2015 4:32 AM, "Carsten Haitzler" wrote:
>
> On Wed, 9 Dec 2015 20:39:30 +0530 Amitesh Singh
said:
>
> > On Dec 9, 2015 6:20 PM, "Tom Hacohen" wrote:
> > >
> > > On 09/12/15 12:40, Mike Blumenkrantz wrote:
> > > > I
On 09/12/15 12:40, Mike Blumenkrantz wrote:
> I can confirm that Vyacheslav is correct, and even if he did not mention
> stringshare, this change is still wrong on a fundamental level.
>
> Please revert it.
What really stands out in this change, is that I don't get the reason
for it. Why was it
Hello,
I'm not sure that this changes is correct. The 'state_name' can be
pointer to eina_stringshare and comparing the two pointers faster
than strcmp. This fix looks doubtful.
--
Viacheslav Reutskiy (rimmed)
On Wed, Dec 9, 2015 at 12:20 PM, Amitesh Singh
wrote:
> ami
I can confirm that Vyacheslav is correct, and even if he did not mention
stringshare, this change is still wrong on a fundamental level.
Please revert it.
On Wed, Dec 9, 2015 at 7:08 AM Vyacheslav Reutskiy
wrote:
> Hello,
>
> I'm not sure that this changes is correct.
On Dec 9, 2015 6:20 PM, "Tom Hacohen" wrote:
>
> On 09/12/15 12:40, Mike Blumenkrantz wrote:
> > I can confirm that Vyacheslav is correct, and even if he did not mention
> > stringshare, this change is still wrong on a fundamental level.
> >
> > Please revert it.
>
> What
On 09/12/15 15:09, Amitesh Singh wrote:
> On Dec 9, 2015 6:20 PM, "Tom Hacohen" wrote:
>>
>> On 09/12/15 12:40, Mike Blumenkrantz wrote:
>>> I can confirm that Vyacheslav is correct, and even if he did not mention
>>> stringshare, this change is still wrong on a fundamental
On Wed, 9 Dec 2015 20:39:30 +0530 Amitesh Singh said:
> On Dec 9, 2015 6:20 PM, "Tom Hacohen" wrote:
> >
> > On 09/12/15 12:40, Mike Blumenkrantz wrote:
> > > I can confirm that Vyacheslav is correct, and even if he did not mention
> > >