Re: [E-devel] [EGIT] [core/efl] master 01/01: eo - destruction - ensure child is removed from parent child list

2015-08-19 Thread Daniel Zaoui
Hi, On Wed, 19 Aug 2015 20:53:53 -0700 Carsten Haitzler wrote: > raster pushed a commit to branch master. > > http://git.enlightenment.org/core/efl.git/commit/?id=8689d54471aafdd7a5b5a27ce116bf2ab68c1042 > > commit 8689d54471aafdd7a5b5a27ce116bf2ab68c1042 > Author: Carsten Haitzler (Rasterman)

Re: [E-devel] [EGIT] [core/efl] master 01/01: eo - destruction - ensure child is removed from parent child list

2015-08-19 Thread The Rasterman
On Thu, 20 Aug 2015 09:09:44 +0300 Daniel Zaoui said: > Hi, > > On Wed, 19 Aug 2015 20:53:53 -0700 > Carsten Haitzler wrote: > > > raster pushed a commit to branch master. > > > > http://git.enlightenment.org/core/efl.git/commit/?id=8689d54471aafdd7a5b5a27ce116bf2ab68c1042 > > > > commit 868

Re: [E-devel] [EGIT] [core/efl] master 01/01: eo - destruction - ensure child is removed from parent child list

2015-08-20 Thread Daniel Zaoui
On Thu, 20 Aug 2015 15:48:23 +0900 Carsten Haitzler (The Rasterman) wrote: > On Thu, 20 Aug 2015 09:09:44 +0300 Daniel Zaoui > said: > > > Hi, > > > > On Wed, 19 Aug 2015 20:53:53 -0700 > > Carsten Haitzler wrote: > > > > > raster pushed a commit to branch master. > > > > > > http://git.enl

Re: [E-devel] [EGIT] [core/efl] master 01/01: eo - destruction - ensure child is removed from parent child list

2015-08-20 Thread The Rasterman
On Thu, 20 Aug 2015 10:22:42 +0300 Daniel Zaoui said: > On Thu, 20 Aug 2015 15:48:23 +0900 > Carsten Haitzler (The Rasterman) wrote: > > > On Thu, 20 Aug 2015 09:09:44 +0300 Daniel Zaoui > > said: > > > > > Hi, > > > > > > On Wed, 19 Aug 2015 20:53:53 -0700 > > > Carsten Haitzler wrote: > >

Re: [E-devel] [EGIT] [core/efl] master 01/01: eo - destruction - ensure child is removed from parent child list

2015-08-20 Thread Cedric BAIL
On Thu, Aug 20, 2015 at 9:22 AM, Daniel Zaoui wrote: > On Thu, 20 Aug 2015 15:48:23 +0900 > Carsten Haitzler (The Rasterman) wrote: > >> On Thu, 20 Aug 2015 09:09:44 +0300 Daniel Zaoui >> said: >> >> > Hi, >> > >> > On Wed, 19 Aug 2015 20:53:53 -0700 >> > Carsten Haitzler wrote: >> > >> > > ras

Re: [E-devel] [EGIT] [core/efl] master 01/01: eo - destruction - ensure child is removed from parent child list

2015-08-20 Thread The Rasterman
On Thu, 20 Aug 2015 10:12:30 +0200 Cedric BAIL said: > On Thu, Aug 20, 2015 at 9:22 AM, Daniel Zaoui > wrote: > > On Thu, 20 Aug 2015 15:48:23 +0900 > > Carsten Haitzler (The Rasterman) wrote: > > > >> On Thu, 20 Aug 2015 09:09:44 +0300 Daniel Zaoui > >> said: > >> > >> > Hi, > >> > > >> > On

Re: [E-devel] [EGIT] [core/efl] master 01/01: eo - destruction - ensure child is removed from parent child list

2015-08-20 Thread The Rasterman
On Thu, 20 Aug 2015 18:48:46 +0900 Carsten Haitzler (The Rasterman) said: > we do have an issue still - up for discussion here. > > obj = eo_add(SIMPLE_CLASS, NULL); > obj2 = eo_add(SIMPLE_CLASS, obj); > > has obj2 at refcount of 1. as i would expect. BUT > > obj = eo_add(SIMPLE_CLASS, NULL);

Re: [E-devel] [EGIT] [core/efl] master 01/01: eo - destruction - ensure child is removed from parent child list

2015-08-20 Thread Jean-Philippe André
On Thu, Aug 20, 2015 at 6:48 PM, Carsten Haitzler wrote: > On Thu, 20 Aug 2015 10:12:30 +0200 Cedric BAIL said: > > > On Thu, Aug 20, 2015 at 9:22 AM, Daniel Zaoui > > wrote: > > > On Thu, 20 Aug 2015 15:48:23 +0900 > > > Carsten Haitzler (The Rasterman) wrote: > > > > > >> On Thu, 20 Aug 2015

Re: [E-devel] [EGIT] [core/efl] master 01/01: eo - destruction - ensure child is removed from parent child list

2015-08-21 Thread Tom Hacohen
On 21/08/15 07:07, Jean-Philippe André wrote: > On Thu, Aug 20, 2015 at 6:48 PM, Carsten Haitzler > wrote: > >> On Thu, 20 Aug 2015 10:12:30 +0200 Cedric BAIL said: >> >>> On Thu, Aug 20, 2015 at 9:22 AM, Daniel Zaoui >>> wrote: On Thu, 20 Aug 2015 15:48:23 +0900 Carsten Haitzler (The

Re: [E-devel] [EGIT] [core/efl] master 01/01: eo - destruction - ensure child is removed from parent child list

2015-08-21 Thread Tom Hacohen
On 20/08/15 07:09, Daniel Zaoui wrote: > The parent should never be !NULL when reaching the destructor. Imo, this code > has not to be here. Instead, an error message should be displayed in the case > the parent is still connected to the object. There is a bug but definitely > the solution doesn

Re: [E-devel] [EGIT] [core/efl] master 01/01: eo - destruction - ensure child is removed from parent child list

2015-08-21 Thread Tom Hacohen
On 21/08/15 17:16, Tom Hacohen wrote: > On 20/08/15 07:09, Daniel Zaoui wrote: >> The parent should never be !NULL when reaching the destructor. Imo, this >> code has not to be here. Instead, an error message should be displayed in >> the case the parent is still connected to the object. There is

Re: [E-devel] [EGIT] [core/efl] master 01/01: eo - destruction - ensure child is removed from parent child list

2015-08-21 Thread The Rasterman
On Fri, 21 Aug 2015 17:16:54 +0100 Tom Hacohen said: > On 20/08/15 07:09, Daniel Zaoui wrote: > > The parent should never be !NULL when reaching the destructor. Imo, this > > code has not to be here. Instead, an error message should be displayed in > > the case the parent is still connected to th

Re: [E-devel] [EGIT] [core/efl] master 01/01: eo - destruction - ensure child is removed from parent child list

2015-08-26 Thread Tom Hacohen
On 21/08/15 11:21, Tom Hacohen wrote: > On 21/08/15 07:07, Jean-Philippe André wrote: >> On Thu, Aug 20, 2015 at 6:48 PM, Carsten Haitzler >> wrote: >> >>> On Thu, 20 Aug 2015 10:12:30 +0200 Cedric BAIL said: >>> On Thu, Aug 20, 2015 at 9:22 AM, Daniel Zaoui wrote: > On Thu, 20 Aug

Re: [E-devel] [EGIT] [core/efl] master 01/01: eo - destruction - ensure child is removed from parent child list

2015-08-27 Thread Felipe Magno de Almeida
I think the whole problem comes from the lack of concepts. When we use referencing counting, it is meant for sharing ownership. So, we shouldn't have to unparent before eo_unref. However, parents own a reference to the object, or else the object might disappear unexpectedly. However, eo_add is no

Re: [E-devel] [EGIT] [core/efl] master 01/01: eo - destruction - ensure child is removed from parent child list

2015-08-27 Thread Felipe Magno de Almeida
On Thu, Aug 27, 2015 at 5:15 PM, Felipe Magno de Almeida wrote: > I think the whole problem comes from the lack of concepts. Well, it was fixed already. Thanks Tom. > On elm_win.c:3636 we have: > >/* XXX: This hack is needed because we parent ourselves to an inside > object. > * That sh

Re: [E-devel] [EGIT] [core/efl] master 01/01: eo - destruction - ensure child is removed from parent child list

2015-08-27 Thread The Rasterman
On Thu, 27 Aug 2015 17:15:32 -0300 Felipe Magno de Almeida said: > I think the whole problem comes from the lack of concepts. > > When we use referencing counting, it is meant for sharing > ownership. So, we shouldn't have to unparent before > eo_unref. However, parents own a reference to the ob