Re: [E-devel] [EGIT] [core/efl] master 01/02: address non nul terminated string due to strncpy

2014-08-17 Thread The Rasterman
On Sun, 17 Aug 2014 12:39:10 +0100 Tom Hacohen said: > Btw raster, it was my commit that introduced the strncpy (which I assumed > would always have the null because of the same reasoning as you). I did it > because coverity complained about the use of strcpy. I think it's safer to > probably rev

Re: [E-devel] [EGIT] [core/efl] master 01/02: address non nul terminated string due to strncpy

2014-08-17 Thread Tom Hacohen
Btw raster, it was my commit that introduced the strncpy (which I assumed would always have the null because of the same reasoning as you). I did it because coverity complained about the use of strcpy. I think it's safer to probably revert your patch, use my strncpy patch, and add an explicit utf8_

Re: [E-devel] [EGIT] [core/efl] master 01/02: address non nul terminated string due to strncpy

2014-08-12 Thread The Rasterman
On Wed, 13 Aug 2014 10:44:20 +0900 Daniel Juyung Seo said: fixed. it wasnt that. it was removing calloc stupidity after fixing the below CID. > This just broke all my elm apps. > > Program received signal SIGSEGV, Segmentation fault. > 0xb7b01aea in _evas_bidi_unicode_to_fribidichar (dest=0x804

Re: [E-devel] [EGIT] [core/efl] master 01/02: address non nul terminated string due to strncpy

2014-08-12 Thread Daniel Juyung Seo
This just broke all my elm apps. Program received signal SIGSEGV, Segmentation fault. 0xb7b01aea in _evas_bidi_unicode_to_fribidichar (dest=0x80435000 , src=0x80434ff0 L"\x800\x800\x800́" ) at lib/evas/common/language/evas_bidi_utils.c:66 66 while (*src) *dest++ = *src++; (gdb) bt #0