Hey, On 1 December 2015 at 01:59, Stefan Schmidt <ste...@osg.samsung.com> wrote:
> stefan pushed a commit to branch master. > > > http://git.enlightenment.org/core/efl.git/commit/?id=54abe37c44cae3500b514a6ab3563ff93e330725 > > commit 54abe37c44cae3500b514a6ab3563ff93e330725 > Author: Stefan Schmidt <ste...@osg.samsung.com> > Date: Mon Nov 30 17:16:28 2015 +0100 > > evas_font_dir: do not passed free'd memory to eina_list_remove() > > Free the actual memory after we removed it from the list. > Yeah, but you created a new bug here. The previous code was valid, as eina_list only cares about the pointer, not the data it points to. I just realized that when Youngbok made the following patch: https://phab.enlightenment.org/D3392 > --- > src/lib/evas/canvas/evas_font_dir.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/lib/evas/canvas/evas_font_dir.c > b/src/lib/evas/canvas/evas_font_dir.c > index df0f5ef..dc9ac20 100644 > --- a/src/lib/evas/canvas/evas_font_dir.c > +++ b/src/lib/evas/canvas/evas_font_dir.c > @@ -1209,8 +1209,8 @@ object_text_font_cache_dir_add(char *dir) > } > free(tmp); > } > - free(fdir->data); > fdir = eina_list_remove(fdir, fdir->data); > + free(fdir->data); > Nope, fdir may change and even become NULL. > } > > /* fonts.alias */ > > -- > > I can't push right now, so D3392 is pending. (firewall issues) Best regards, -- Jean-Philippe André ------------------------------------------------------------------------------ Go from Idea to Many App Stores Faster with Intel(R) XDK Give your users amazing mobile app experiences with Intel(R) XDK. Use one codebase in this all-in-one HTML5 development environment. Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs. http://pubads.g.doubleclick.net/gampad/clk?id=254741911&iu=/4140 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
