Re: [E-devel] [EGIT] [core/efl] master 02/05: Eo: Add efl_replace() function.

2016-12-05 Thread Gustavo Sverzut Barbieri
the purpose is to properly order ref + unref so if the same object, or dependent objects are used, the new object gets a ref before we drop the old one. which is not what people usually do, since we'd need an intermediate variable or careful code, people often unref() -> ref(), if it was the same

Re: [E-devel] [EGIT] [core/efl] master 02/05: Eo: Add efl_replace() function.

2016-12-05 Thread The Rasterman
On Mon, 5 Dec 2016 13:50:12 + Tom Hacohen said: > I never liked the stringshare function that does it, so it comes with no > surprise that I don't like this one either. > > Regardless of that, I find the name very confusing. I didn't understand > what it does when I

Re: [E-devel] [EGIT] [core/efl] master 02/05: Eo: Add efl_replace() function.

2016-12-05 Thread marcel-hollerbach
Hello, maybe 'efl_ref_replace' since its a replacement of a referenced field. Greetings Marcel Hollerbach On Mon, Dec 05, 2016 at 12:16:15PM -0200, Guilherme Íscaro wrote: > Hello, > > Well, what name do you suggest? > > On Mon, Dec 5, 2016 at 11:50 AM, Tom Hacohen

Re: [E-devel] [EGIT] [core/efl] master 02/05: Eo: Add efl_replace() function.

2016-12-05 Thread Guilherme Íscaro
Hello, Well, what name do you suggest? On Mon, Dec 5, 2016 at 11:50 AM, Tom Hacohen wrote: > I never liked the stringshare function that does it, so it comes with no > surprise that I don't like this one either. > > Regardless of that, I find the name very confusing. I

Re: [E-devel] [EGIT] [core/efl] master 02/05: Eo: Add efl_replace() function.

2016-12-05 Thread Felipe Magno de Almeida
On Mon, Dec 5, 2016 at 11:50 AM, Tom Hacohen wrote: > I never liked the stringshare function that does it, so it comes with no > surprise that I don't like this one either. > > Regardless of that, I find the name very confusing. I didn't understand > what it does when I saw

Re: [E-devel] [EGIT] [core/efl] master 02/05: Eo: Add efl_replace() function.

2016-12-05 Thread Tom Hacohen
I never liked the stringshare function that does it, so it comes with no surprise that I don't like this one either. Regardless of that, I find the name very confusing. I didn't understand what it does when I saw the name nor when I read the docs. I had to read the code to understand what it's