-
-Original Message-
From: Michael Blumenkrantzmichael.blumenkra...@gmail.com
To: Enlightenment developer listenlightenment-devel@lists.sourceforge.net;
Cc:
Sent: 2014-01-19 (일) 05:14:04
Subject: Re: [E-devel] [EGIT] [core/enlightenment] master 01/01: enlightenment
- removed warnings
Also, some of the changes are wrong, like e_auth_begin which is an
exported symbol. It shouldn't be compiled out based on configuration.
--
Tom.
On 18/01/14 20:14, Michael Blumenkrantz wrote:
On Sat, 18 Jan 2014 02:37:10 -0800
ChunEon Park her...@hermet.pe.kr wrote:
hermet pushed a commit
I know. it's not commented out.
-Regards, Hermet-
-Original Message-
From: Tom Hacohentom.haco...@samsung.com
To: enlightenment-devel@lists.sourceforge.net;
Cc:
Sent: 2014-01-20 (월) 19:14:31
Subject: Re: [E-devel] [EGIT] [core/enlightenment
.
-Regards, Hermet-
-Original Message-
From: Tom Hacohentom.hacohen@samsung.com
To: enlightenment-devel@lists.sourceforge.net;
Cc:
Sent: 2014-01-20 (월) 19:14:31
Subject: Re: [E-devel] [EGIT] [core/enlightenment] master 01/01:
enlightenment - removed warnings.
Also, some
On 20/01/14 13:08, ChunEon Park wrote:
read the code,
it's not complied out neither.
You are right, missed that part.
However, it's a lot of code duplication just for the unused attribute.
You could have just done:
(void) passwd;
That we use in similar cases all over the place. This is
On Mon, Jan 20, 2014 at 9:02 AM, Tom Hacohen tom.haco...@samsung.com wrote:
It's not commented out, it's compiled out base on config:
+#ifdef HAVE_PAM
e_auth_begin(char *passwd)
{
-#ifdef HAVE_PAM
It's not the best way to ifdef the function, but he indeed added it
just below the code
/enlightenment] master 01/01: enlightenment
- removed warnings.
On 20/01/14 13:08, ChunEon Park wrote:
read the code,
it's not complied out neither.
You are right, missed that part.
However, it's a lot of code duplication just for the unused attribute.
You could have just done:
(void) passwd;
That we
On 20/01/14 13:56, ChunEon Park wrote:
ok, no problem.
i can change it.
Cool, thanks. Sorry for the previous noise.
--
Tom.
--
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are
On Sat, 18 Jan 2014 02:37:10 -0800
ChunEon Park her...@hermet.pe.kr wrote:
hermet pushed a commit to branch master.
http://git.enlightenment.org/core/enlightenment.git/commit/?id=747403614046ae392004118fa6497dc523125947
commit 747403614046ae392004118fa6497dc523125947
Author: ChunEon Park
