Re: [E-devel] [EGIT] [misc/entrance] master 02/09: entrance: Updated the entrance_conf.c

2014-04-09 Thread Michaël Bouchaud
to factorize 2014-04-08 21:01 GMT+02:00 Marcel Hollerbach : > I write two times the macro LIST_FILL, and two times with different > content(thats why I write the macro twice not once), so I dont see why I > should put that into one macro ? > > On Mon, Apr 07, 2014 at 02:37:04PM +0200, Michaël B

Re: [E-devel] [EGIT] [misc/entrance] master 02/09: entrance: Updated the entrance_conf.c

2014-04-08 Thread Marcel Hollerbach
I write two times the macro LIST_FILL, and two times with different content(thats why I write the macro twice not once), so I dont see why I should put that into one macro ? On Mon, Apr 07, 2014 at 02:37:04PM +0200, Michaël Bouchaud wrote: > yeah you write two times a macro LIST_FILL who call IMG

Re: [E-devel] [EGIT] [misc/entrance] master 02/09: entrance: Updated the entrance_conf.c

2014-04-07 Thread Michaël Bouchaud
yes libc give already some func, no need to add an algo for that. look for strrchr or memrchr. Last one is better 2014-04-07 16:44 GMT+02:00 Sebastian Dransfeld : > strrchr > > Sendt fra min iPad > > > Den Apr 7, 2014 kl. 14:30 skrev Marcel Hollerbach < > marcel-hollerb...@t-online.de>: > > > >

Re: [E-devel] [EGIT] [misc/entrance] master 02/09: entrance: Updated the entrance_conf.c

2014-04-07 Thread Sebastian Dransfeld
strrchr Sendt fra min iPad > Den Apr 7, 2014 kl. 14:30 skrev Marcel Hollerbach > : > > I use them in entrance_conf_main.c and entrance_conf_user.c, so where > should I put the macro ? > > The group has the name entrance/wallpaper/foo > > I just want to display foo so I need something which re

Re: [E-devel] [EGIT] [misc/entrance] master 02/09: entrance: Updated the entrance_conf.c

2014-04-07 Thread Michaël Bouchaud
yeah you write two times a macro LIST_FILL who call IMG_LIST_FORK. Why not creating only one macro in entrance_conf.h 2014-04-07 14:30 GMT+02:00 Marcel Hollerbach : > I use them in entrance_conf_main.c and entrance_conf_user.c, so where > should I put the macro ? > > The group has the name entr

Re: [E-devel] [EGIT] [misc/entrance] master 02/09: entrance: Updated the entrance_conf.c

2014-04-07 Thread Marcel Hollerbach
I use them in entrance_conf_main.c and entrance_conf_user.c, so where should I put the macro ? The group has the name entrance/wallpaper/foo I just want to display foo so I need something which returns me "foo" ecore_file_file_get does that, but okay, I will do it different. On Mon, Apr 07, 201

Re: [E-devel] [EGIT] [misc/entrance] master 02/09: entrance: Updated the entrance_conf.c

2014-04-07 Thread Michaël Bouchaud
nothing to do in a .h if you are using in one place. It's a design request. And a macro calling another macro is just a wrong design. Or you target is to write unmaintainable code. ecore_file is for file and nothing else ... Write a little algo to find last / ??? 2014-04-07 12:57 GMT+02:00 Marcel

Re: [E-devel] [EGIT] [misc/entrance] master 02/09: entrance: Updated the entrance_conf.c

2014-04-07 Thread Marcel Hollerbach
On Mon, Apr 07, 2014 at 10:42:20AM +0200, Michaël Bouchaud wrote: > Please split you patch. why adding a macro used nowhere in this patch ? I am using this macro in the user settings and the general settings. Should I put them in the headers od the user and general settings ? > And stop to cut an

Re: [E-devel] [EGIT] [misc/entrance] master 02/09: entrance: Updated the entrance_conf.c

2014-04-07 Thread Michaël Bouchaud
Please split you patch. why adding a macro used nowhere in this patch ? And stop to cut and paste some code. A group isn't a file ... Try to give a better quality in your patch 2014-04-02 17:55 GMT+02:00 Marcel Hollerbach : > bu5hm4n pushed a commit to branch master. > > > http://git.enlightenme