...@gmail.com
Date : Jan 18, 2013 18:38 (GMT+09:00)
Title : Re: [E-devel] [PATCH] [Elementary] Fix memory leak and callback
function in ctxpopup
I think elm_ctxpopup_memleak_callback_1.7.diff is the backport.
But he made a mistake in NEWS.
Daniel Juyung Seo (SeoZ)
On Fri, Jan 18, 2013 at 6:12 PM
@lists.sourceforge.netgt;;
Cc:
Sent: 2013-01-21 (μ) 09:39:43
Subject: Re: [E-devel] [PATCH] [Elementary] Fix memory leak and callback
function in ctxpopup
Dear Hermet and Daniel,
Thank you for your reviewing.
I provided the backport patch which is elm_ctxpopup_memleak_callback_1.7.diff.
Could you please
;thiep...@samsung.comgt;
To:
enlightenment-devel@lists.sourceforge.netlt;enlightenment-devel@lists.sourceforge.netgt;;
Cc:
Sent: 2013-01-15 (ν) 15:06:45
Subject: [E-devel] [PATCH] [Elementary] Fix memory leak and callback function
in ctxpopup
Hello everyone,
There are two issues
) 18:08:11
Subject: Re: [E-devel][PATCH] [Elementary] Fix memory leak and callback
function in ctxpopup
Here is my review of the first patch elm_ctxpopup_memleak_callback.diff.
I don't have much time to review both.
1. Reduce line as possible. We don't need to block the area if the conditional
?
-Regards, Hermet-
-Original Message-
From: ChunEon Parklt;her...@naver.comgt;
To: Enlightenment developer
listlt;enlightenment-devel@lists.sourceforge.netgt;;
Cc:
Sent: 2013-01-18 (κΈ) 18:08:11
Subject: Re: [E-devel][PATCH] [Elementary] Fix memory leak and callback
function in ctxpopup
Hello everyone,
There are two issues with ctxpopup:
- Memory leak: Elm_Ctxpopup_Item is used but not deleted.
- Incorrect callback function: returned object and event_info are list object
and item
(should be ctxpopup object and item).
I would like to send a patch to fix above issues.
I also
