Re: [E-devel] [PATCH] Add omit feature to elm_index

2013-01-06 Thread Jaeun Choi
"<enlightenment-devel@lists.sourceforge.net>; Cc: Sent: 2013-01-05 (토) 03:32:57 Subject: Re: [E-devel] [PATCH] Add omit feature to elm_index Dear Jaeun Choi, thanks for the patch. I had a QUICK review of your FIRST patch and have many comments. I need to do detail review later. We real

Re: [E-devel] [PATCH] Add omit feature to elm_index

2013-01-04 Thread Daniel Juyung Seo
Dear Jaeun Choi, thanks for the patch. I had a QUICK review of your FIRST patch and have many comments. I need to do detail review later. We really need to adopt gerrit soon. 1. Use of ELM_INDEX_DATA_GET_OR_RETURN_VAL There are too many cases. Fix them all. ELM_INDEX_DATA_GET(obj, sd); if (!sd) r

Re: [E-devel] [PATCH] Add omit feature to elm_index

2013-01-03 Thread Jaeun Choi
attach patch #2 and #3 as well. -Original Message- From: "최자은"<jaeun_c...@naver.com> To: <enlightenment-devel@lists.sourceforge.net>; Cc: Sent: 2013-01-03 (목) 14:12:52 Subject: [E-devel] [PATCH] Add omit feature to elm_index Hi all This patch adds some func

[E-devel] [PATCH] Add omit feature to elm_index

2013-01-02 Thread 최자은
Hi all This patch adds some functions to elm_index for supporting omit feature. When elm_index has too many items, some items are cut out of the frame. This can be resolved by omitting some items in the middle so the whole index can be seen from the top to the bottom. The related source code i