Re: [E-devel] [PATCH] add menu items through modules

2006-01-10 Thread The Rasterman
On Sun, 8 Jan 2006 21:59:01 +1000 David Seikel <[EMAIL PROTECTED]> babbled: > On Sun, 8 Jan 2006 16:17:52 +1000 David Seikel <[EMAIL PROTECTED]> > wrote: > > > I'll probably post it here as a patch and leave it up to raster or > > CodeWarrior to actually commit it. > > So here it is. Not much d

Re: [E-devel] [PATCH] add menu items through modules

2006-01-08 Thread Jorge Luis Zapata Muga
On 1/8/06, David Seikel <[EMAIL PROTECTED]> wrote: > On Sun, 8 Jan 2006 16:17:52 +1000 David Seikel <[EMAIL PROTECTED]> > wrote: > > > I'll probably post it here as a patch and leave it up to raster or > > CodeWarrior to actually commit it. > > So here it is. Not much different from what Morten ha

Re: [E-devel] [PATCH] add menu items through modules

2006-01-08 Thread The Rasterman
On Sun, 8 Jan 2006 17:28:44 +1000 David Seikel <[EMAIL PROTECTED]> babbled: > While looking through apps/e/src looking for the proper way to do this, > I found two things. > > There are many different styles used, so getting a consensus from the > code is hard. I'll just pick one I like. B-) >

Re: [E-devel] [PATCH] add menu items through modules

2006-01-08 Thread David Seikel
On Sun, 8 Jan 2006 16:17:52 +1000 David Seikel <[EMAIL PROTECTED]> wrote: > I'll probably post it here as a patch and leave it up to raster or > CodeWarrior to actually commit it. So here it is. Not much different from what Morten had in mind. I ended up not using the delete_me stuff, it wasn't

Re: [E-devel] [PATCH] add menu items through modules

2006-01-08 Thread David Sharp
On 1/7/06, Morten Nilsen <[EMAIL PROTECTED]> wrote: > David Sharp wrote: > > On 1/7/06, Morten Nilsen <[EMAIL PROTECTED]> wrote: > >> .. on a different note, it would be nice if you in the future snip > >> quoted text.. had to scroll a few miles to get to your reply ;) > >> > >> and also, when maki

Re: [E-devel] [PATCH] add menu items through modules

2006-01-07 Thread David Seikel
While looking through apps/e/src looking for the proper way to do this, I found two things. There are many different styles used, so getting a consensus from the code is hard. I'll just pick one I like. B-) Passing back an opaque pointer from the _add(), which you pass to the _del(), which then

Re: [E-devel] [PATCH] add menu items through modules

2006-01-07 Thread David Seikel
I'm going to change it now to be similar to the way that the other apps/e callback add/del functions work. I'll do this by using the other functions as templates and examples. I will do this now. I'm doing this now because I'm trying to use it now, and I can progress faster if I just fix it up n

Re: [E-devel] [PATCH] add menu items through modules

2006-01-07 Thread Morten Nilsen
David Sharp wrote: On 1/7/06, Morten Nilsen <[EMAIL PROTECTED]> wrote: .. on a different note, it would be nice if you in the future snip quoted text.. had to scroll a few miles to get to your reply ;) and also, when making patches, make them unified (diff -u) please :) WELL! if were going to

Re: [E-devel] [PATCH] add menu items through modules

2006-01-07 Thread David Sharp
On 1/7/06, Morten Nilsen <[EMAIL PROTECTED]> wrote: > Jorge Luis Zapata Muga wrote: > > > Your efm is kind of old, also you shouldnt make changes to it because > > the problem is on the "client" api (_callback_set) on the e_menu.c > > I stated my efm was kind of old, yes.. I only tried being helpfu

Re: [E-devel] [PATCH] add menu items through modules

2006-01-07 Thread Morten Nilsen
Jorge Luis Zapata Muga wrote: On 1/7/06, Morten Nilsen <[EMAIL PROTECTED]> wrote: +++ e/src/bin/e_menu.c 2006-01-07 11:43:25.054986869 +0100 +void * +e_menu_category_callback_add(char *category, void (*create) (E_Menu *m, void *category_data, void *data), void (*free) (void *data), void *data)

Re: [E-devel] [PATCH] add menu items through modules

2006-01-07 Thread Jorge Luis Zapata Muga
On 1/7/06, Morten Nilsen <[EMAIL PROTECTED]> wrote: > Carsten Haitzler (The Rasterman) wrote: > > On Sat, 07 Jan 2006 04:24:35 +0100 Morten Nilsen <[EMAIL PROTECTED]> > > babbled: > > > >> David Seikel wrote: > >>> Even if e_menu_category_callback_set() with the callback set to NULL was > >>> impl

Re: [E-devel] [PATCH] add menu items through modules

2006-01-07 Thread Jorge Luis Zapata Muga
On 1/7/06, The Rasterman Carsten Haitzler <[EMAIL PROTECTED]> wrote: > On Sat, 07 Jan 2006 04:24:35 +0100 Morten Nilsen <[EMAIL PROTECTED]> babbled: > > > David Seikel wrote: > > > Even if e_menu_category_callback_set() with the callback set to NULL was > > > implemented, there is no unique paramet

Re: [E-devel] [PATCH] add menu items through modules

2006-01-07 Thread Morten Nilsen
Carsten Haitzler (The Rasterman) wrote: On Sat, 07 Jan 2006 04:24:35 +0100 Morten Nilsen <[EMAIL PROTECTED]> babbled: David Seikel wrote: Even if e_menu_category_callback_set() with the callback set to NULL was implemented, there is no unique parameter in the function that would identify which

Re: [E-devel] [PATCH] add menu items through modules

2006-01-06 Thread The Rasterman
On Sat, 07 Jan 2006 04:24:35 +0100 Morten Nilsen <[EMAIL PROTECTED]> babbled: > David Seikel wrote: > > Even if e_menu_category_callback_set() with the callback set to NULL was > > implemented, there is no unique parameter in the function that would > > identify which callback to remove. There wa

Re: [E-devel] [PATCH] add menu items through modules

2006-01-06 Thread Morten Nilsen
David Seikel wrote: Even if e_menu_category_callback_set() with the callback set to NULL was implemented, there is no unique parameter in the function that would identify which callback to remove. There way be multiple callbacks registered, that's why they are all added to a list. And that's wh

Re: [E-devel] [PATCH] add menu items through modules

2006-01-06 Thread David Seikel
On Sat, 07 Jan 2006 04:01:23 +0100 Morten Nilsen <[EMAIL PROTECTED]> wrote: > David Seikel wrote: > > e_menu_category_callback_del(). > > wouldn't that be semantically equal to calling > e_menu_category_callback_set() with the callback set to NULL ? If the e_menu_category_callback_set() code kn

Re: [E-devel] [PATCH] add menu items through modules

2006-01-06 Thread Morten Nilsen
David Seikel wrote: e_menu_category_callback_del(). wouldn't that be semantically equal to calling e_menu_category_callback_set() with the callback set to NULL ? -- Morten :wq --- This SF.net email is sponsored by: Splunk Inc. Do you grep

Re: [E-devel] [PATCH] add menu items through modules

2006-01-06 Thread David Seikel
On Wed, 4 Jan 2006 01:32:05 +0100 Jorge Luis Zapata Muga <[EMAIL PROTECTED]> wrote: > on the client (modules, or whatever) > > 1. e_menu_category_callback_set("fileman/action", _callback_create, > _callback_free, local_data); Big problem here. After a module has set the callback, if the module

Re: [E-devel] [PATCH] add menu items through modules

2006-01-06 Thread David Seikel
On Wed, 4 Jan 2006 01:32:05 +0100 Jorge Luis Zapata Muga <[EMAIL PROTECTED]> wrote: > hi all, here i attach the patch wich will add the functionality to add > menu items outside the main routines of creating the menu. the idea is > basically this: Cool, this is something that is needed by the emu

Re: [E-devel] [PATCH] add menu items through modules

2006-01-06 Thread Hisham Mardam Bey
Applied. On 1/4/06, Jorge Luis Zapata Muga <[EMAIL PROTECTED]> wrote: > hi all, here i attach the patch wich will add the functionality to add > menu items outside the main routines of creating the menu. the idea is > basically this: > > on the function where the e_menu_new is called > > 1. set th

[E-devel] [PATCH] add menu items through modules

2006-01-03 Thread Jorge Luis Zapata Muga
hi all, here i attach the patch wich will add the functionality to add menu items outside the main routines of creating the menu. the idea is basically this: on the function where the e_menu_new is called 1. set the category of the menu (i.e "fileman/action") 2. set some data to be passed to ever