Re: [E-devel] [PATCH] eina: Do not always perform magic checks on _free() and _del() (was Re: Magic checks before NULL checks in Eina)

2012-07-04 Thread Cedric BAIL
On Tue, Jul 3, 2012 at 1:17 PM, Raphael Kubo da Costa wrote: > Cedric BAIL writes: > - *_foreach(): >One could argue that passing NULL should be equivalent to an empty >loop. For example, right now >eina_iterator_foreach(NULL, ..., ...) >generates a magic

Re: [E-devel] [PATCH] eina: Do not always perform magic checks on _free() and _del() (was Re: Magic checks before NULL checks in Eina)

2012-07-02 Thread Raphael Kubo da Costa
Cedric BAIL writes: - *_foreach(): One could argue that passing NULL should be equivalent to an empty loop. For example, right now eina_iterator_foreach(NULL, ..., ...) generates a magic check error message, while EINA_ITERATOR_FOREACH(NULL, .

Re: [E-devel] [PATCH] eina: Do not always perform magic checks on _free() and _del() (was Re: Magic checks before NULL checks in Eina)

2012-07-02 Thread Cedric BAIL
On Tue, Jul 3, 2012 at 12:30 PM, Raphael Kubo da Costa wrote: > Cedric BAIL writes: >> On Tue, Jul 3, 2012 at 12:30 AM, Raphael Kubo da Costa >> wrote: >>> I'm unsure about whether to change the following calls, so for now I >>> haven't: >>> - eina_inarray_flush() >>> - eina_inarray_remove() >

Re: [E-devel] [PATCH] eina: Do not always perform magic checks on _free() and _del() (was Re: Magic checks before NULL checks in Eina)

2012-07-02 Thread Raphael Kubo da Costa
Cedric BAIL writes: > On Tue, Jul 3, 2012 at 12:30 AM, Raphael Kubo da Costa > wrote: >> I'm unsure about whether to change the following calls, so for now I >> haven't: >> - eina_inarray_flush() >> - eina_inarray_remove() >> - eina_tiler_clear() >> >> - *_foreach(): >>One could argue th

Re: [E-devel] [PATCH] eina: Do not always perform magic checks on _free() and _del() (was Re: Magic checks before NULL checks in Eina)

2012-07-02 Thread Cedric BAIL
On Tue, Jul 3, 2012 at 12:30 AM, Raphael Kubo da Costa wrote: > Michael Blumenkrantz writes: >> On Wed, 27 Jun 2012 23:43:23 -0300 >> Raphael Kubo da Costa wrote: >>> Cedric BAIL writes: >>> > I personally think that eina_iterator_free like any free function >>> > should just work fine with NUL

Re: [E-devel] [PATCH] eina: Do not always perform magic checks on _free() and _del() (was Re: Magic checks before NULL checks in Eina)

2012-07-02 Thread Gustavo Sverzut Barbieri
List NULL is a valid pointer as its sn empty list, unlike hash that uses a handle for empty hash. On Monday, July 2, 2012, Raphael Kubo da Costa wrote: > Michael Blumenkrantz > > writes: > > > On Wed, 27 Jun 2012 23:43:23 -0300 > > Raphael Kubo da Costa wrote: > > > >> Cedric BAIL > writes: > >>

[E-devel] [PATCH] eina: Do not always perform magic checks on _free() and _del() (was Re: Magic checks before NULL checks in Eina)

2012-07-02 Thread Raphael Kubo da Costa
Michael Blumenkrantz writes: > On Wed, 27 Jun 2012 23:43:23 -0300 > Raphael Kubo da Costa wrote: > >> Cedric BAIL writes: >> >> > I personally think that eina_iterator_free like any free function >> > should just work fine with NULL. I was against at that time, but >> > others won. So we do hav