Hi,

At line 2351 in src/lib/canvas/evas_object_textblock.c, "item" is used 
uninitialized:

   fi = _layout_format_item_add(c, n, item);

This cause a crash in elementary test for me. (See below)  Actually, it's been 
crashing like this
for at least the last 2 months.

The attached patch fixes the crash, but somebody might want to look at it a bit 
harder...

thanks,

Mike


eina_stringshare_add (str=0x48 <Address 0x48 out of bounds>) at 
eina_stringshare.c:689
689        if      (str[0] == '\0')
(gdb) bt
#0  eina_stringshare_add (str=0x48 <Address 0x48 out of bounds>) at 
eina_stringshare.c:689
#1  0xb7c5b750 in _layout_format_item_add (c=0xbffd6674, n=0x82720a0, item=0x48 
<Address 0x48 out of bounds>)
   at evas_object_textblock.c:2165
#2  0xb7c5f1b3 in _layout (obj=0x826e000, calc_only=0, w=166, h=0, 
w_ret=0x826db88, h_ret=0x826db8c)
   at evas_object_textblock.c:2351
#3  0xb7c5f885 in _relayout (obj=0x826e000) at evas_object_textblock.c:2521
#4  0xb7c5fac6 in evas_object_textblock_size_formatted_get (obj=0x826e000, 
w=0xbffd67d0, h=0xbffd67cc)
   at evas_object_textblock.c:5493
#5 0xb7b93e64 in _edje_part_recalc_single (ed=0x826d638, ep=0x8223a14, desc=0x825ce88, chosen_desc=0x825ce88, rel1_to_x=0x0, rel1_to_y=0x0, rel2_to_x=0x0, rel2_to_y=0x0, confine_to=0x0, params=0x8223afc, flags=3)
   at edje_calc.c:722
Index: src/lib/canvas/evas_object_textblock.c
===================================================================
--- src/lib/canvas/evas_object_textblock.c	(revision 50633)
+++ src/lib/canvas/evas_object_textblock.c	(working copy)
@@ -2348,7 +2348,7 @@
                        _layout_line_advance(c, fmt);
                        x2 = w;
                     }
-                  fi = _layout_format_item_add(c, n, item);
+                  fi = _layout_format_item_add(c, n, "");
                   fi->x = c->x;
                   fi->vsize = vsize;
                   fi->size = size;
------------------------------------------------------------------------------
The Palm PDK Hot Apps Program offers developers who use the
Plug-In Development Kit to bring their C/C++ apps to Palm for a share
of $1 Million in cash or HP Products. Visit us here for more details:
http://p.sf.net/sfu/dev2dev-palm
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to