Re: [E-devel] [Patch][ecore_con] Refactoring curl port

2011-12-04 Thread The Rasterman
On Fri, 11 Nov 2011 19:12:09 +0900 Bluezery said: in svn! thanks! i fixed up the conflict with current svn too. > I have done two more things. > Please check attached patch. > I have tested using elm_map. I works well. > > 1) EINA_LIST_FOREACH_SAFE is removed and EINA_LIST_FREE is used instead.

Re: [E-devel] [Patch][ecore_con] Refactoring curl port

2011-12-04 Thread The Rasterman
On Mon, 5 Dec 2011 00:32:00 -0500 Michael Blumenkrantz said: > your patch no longer applies. resend one that does and I will review it. i actually was fixing it up... though i got called off to do other things today. back to it now. -- - Codito, ergo sum - "I code, therefore I am"

Re: [E-devel] [Patch][ecore_con] Refactoring curl port

2011-12-04 Thread Michael Blumenkrantz
On Mon, 5 Dec 2011 14:27:00 +0900 Bluezery wrote: > Hi, > > Congratulations on EFL1.1 release!!! > Now, Can it be added to svn?? :) > > > 2011/11/15 Carsten Haitzler : > > On Mon, 14 Nov 2011 18:47:08 +0900 Bluezery said: > > > > considering the amount of refactoring.. this will have to wait

Re: [E-devel] [Patch][ecore_con] Refactoring curl port

2011-12-04 Thread Bluezery
Hi, Congratulations on EFL1.1 release!!! Now, Can it be added to svn?? :) 2011/11/15 Carsten Haitzler : > On Mon, 14 Nov 2011 18:47:08 +0900 Bluezery said: > > considering the amount of refactoring.. this will have to wait until after > 1.1. > we are in feature freeze. that means no refactorin

Re: [E-devel] [Patch][ecore_con] Refactoring curl port

2011-11-14 Thread The Rasterman
On Mon, 14 Nov 2011 18:47:08 +0900 Bluezery said: considering the amount of refactoring.. this will have to wait until after 1.1. we are in feature freeze. that means no refactoring. no new features. just bug fixes. > Oh, I see. That's better. :) > > On Mon, Nov 14, 2011 at 6:10 PM, Mike Blumen

Re: [E-devel] [Patch][ecore_con] Refactoring curl port

2011-11-14 Thread Bluezery
Oh, I see. That's better. :) On Mon, Nov 14, 2011 at 6:10 PM, Mike Blumenkrantz wrote: > On Mon, 14 Nov 2011 10:08:09 +0100 > Cedric BAIL wrote: > >> On Mon, Nov 14, 2011 at 9:57 AM, Mike Blumenkrantz wrote: >> > On Mon, 14 Nov 2011 09:48:07 +0100 >> > Sebastian Dransfeld wrote: >> >> On 11/14

Re: [E-devel] [Patch][ecore_con] Refactoring curl port

2011-11-14 Thread Mike Blumenkrantz
On Mon, 14 Nov 2011 10:08:09 +0100 Cedric BAIL wrote: > On Mon, Nov 14, 2011 at 9:57 AM, Mike Blumenkrantz wrote: > > On Mon, 14 Nov 2011 09:48:07 +0100 > > Sebastian Dransfeld wrote: > >> On 11/14/2011 01:47 AM, Bluezery wrote: > >> > This patch is rejected?? or could be in ?? :-) > >> > > >>

Re: [E-devel] [Patch][ecore_con] Refactoring curl port

2011-11-14 Thread Cedric BAIL
On Mon, Nov 14, 2011 at 9:57 AM, Mike Blumenkrantz wrote: > On Mon, 14 Nov 2011 09:48:07 +0100 > Sebastian Dransfeld wrote: >> On 11/14/2011 01:47 AM, Bluezery wrote: >> > This patch is rejected?? or could be in ?? :-) >> > >> >> To me it seems fine, but I don't want to commit it now so close bef

Re: [E-devel] [Patch][ecore_con] Refactoring curl port

2011-11-14 Thread Mike Blumenkrantz
On Mon, 14 Nov 2011 09:48:07 +0100 Sebastian Dransfeld wrote: > On 11/14/2011 01:47 AM, Bluezery wrote: > > This patch is rejected?? or could be in ?? :-) > > > > To me it seems fine, but I don't want to commit it now so close before > release of 1.1. Either someone how knows ecore_con better t

Re: [E-devel] [Patch][ecore_con] Refactoring curl port

2011-11-14 Thread Sebastian Dransfeld
On 11/14/2011 01:47 AM, Bluezery wrote: > This patch is rejected?? or could be in ?? :-) > To me it seems fine, but I don't want to commit it now so close before release of 1.1. Either someone how knows ecore_con better than me (Cedric maybe?) can commit it, or I will do it after 1.1 S. --

Re: [E-devel] [Patch][ecore_con] Refactoring curl port

2011-11-13 Thread Bluezery
This patch is rejected?? or could be in ?? :-) On Sat, Nov 12, 2011 at 3:05 AM, Cedric BAIL wrote: > Yop, > > On Fri, Nov 11, 2011 at 9:55 AM, Sebastian Dransfeld > wrote: >> On 11/11/2011 09:41 AM, Bluezery wrote: >>> It's my mistake. >>> >>> fixed patch is attached again. >>> I have removed a

Re: [E-devel] [Patch][ecore_con] Refactoring curl port

2011-11-11 Thread Cedric BAIL
Yop, On Fri, Nov 11, 2011 at 9:55 AM, Sebastian Dransfeld wrote: > On 11/11/2011 09:41 AM, Bluezery wrote: >> It's my mistake. >> >> fixed patch is attached again. >> I have removed active flag also. >> I use eina_list_data_find() instead. > > Also, there is used a lot of idlers. I think all idl

Re: [E-devel] [Patch][ecore_con] Refactoring curl port

2011-11-11 Thread Bluezery
_ecore_con_url_idler_handler() is remained because fd is not set when the return value is CURLM_CALL_MULTI_PERFORM. On Fri, Nov 11, 2011 at 7:52 PM, Sebastian Dransfeld wrote: > But do you need the other idler? _ecore_con_url_idler_handler ? > > Couldn't the fd wakeup just perform curl handling

Re: [E-devel] [Patch][ecore_con] Refactoring curl port

2011-11-11 Thread Sebastian Dransfeld
But do you need the other idler? _ecore_con_url_idler_handler ? Couldn't the fd wakeup just perform curl handling directly? S. On 11/11/2011 11:12 AM, Bluezery wrote: > I have done two more things. > Please check attached patch. > I have tested using elm_map. I works well. > > 1) EINA_LIST_FOREA

Re: [E-devel] [Patch][ecore_con] Refactoring curl port

2011-11-11 Thread Bluezery
I have done two more things. Please check attached patch. I have tested using elm_map. I works well. 1) EINA_LIST_FOREACH_SAFE is removed and EINA_LIST_FREE is used instead. 2) I removed complete idler and use ecore_event_add() directly. However, ecore_main_fd_handler_del() sometimes give warnnin

Re: [E-devel] [Patch][ecore_con] Refactoring curl port

2011-11-11 Thread Sebastian Dransfeld
On 11/11/2011 09:41 AM, Bluezery wrote: > It's my mistake. > > fixed patch is attached again. > I have removed active flag also. > I use eina_list_data_find() instead. Also, there is used a lot of idlers. I think all idlers can be removed now, as we only do one multi perform on each fd handler re

Re: [E-devel] [Patch][ecore_con] Refactoring curl port

2011-11-11 Thread Sebastian Dransfeld
On 11/11/2011 09:41 AM, Bluezery wrote: > It's my mistake. > > fixed patch is attached again. > I have removed active flag also. > I use eina_list_data_find() instead. + EINA_LIST_FOREACH_SAFE(_url_con_list, l, ll, url_con) + { +CURLMcode ret; +Ecore_Con_Event_Url_Complete *e

Re: [E-devel] [Patch][ecore_con] Refactoring curl port

2011-11-11 Thread Sebastian Dransfeld
On 11/11/2011 03:09 AM, Bluezery wrote: > Dear all, > > I have modified the way curl used in ecore_con_url.c > > 1) A file descriptor of libcurl is not matched to any easy handles. > We can get a file descriptor from curl_multi_fdset(), we do not > guarantee that it is a socket of easy handle just

Re: [E-devel] [Patch][ecore_con] Refactoring curl port

2011-11-11 Thread Bluezery
It's my mistake. fixed patch is attached again. I have removed active flag also. I use eina_list_data_find() instead. On Fri, Nov 11, 2011 at 4:54 PM, Sebastian Dransfeld wrote: > On 11/11/2011 03:09 AM, Bluezery wrote: >> Dear all, >> >> I have modified the way curl used in ecore_con_url.c > >

Re: [E-devel] [Patch][ecore_con] Refactoring curl port

2011-11-11 Thread Sebastian Dransfeld
On 11/11/2011 03:09 AM, Bluezery wrote: > Dear all, > > I have modified the way curl used in ecore_con_url.c Don't need to use both of the free functions. + EINA_LIST_FREE(_url_con_list, con_url) ecore_con_url_free(con_url); + eina_list_free(_url_con_list);

[E-devel] [Patch][ecore_con] Refactoring curl port

2011-11-10 Thread Bluezery
Dear all, I have modified the way curl used in ecore_con_url.c 1) A file descriptor of libcurl is not matched to any easy handles. We can get a file descriptor from curl_multi_fdset(), we do not guarantee that it is a socket of easy handle just performed. If libcurl multi handle uses pipeline, th