Dear All, Hello!
If the diskselector is round mode, the scroller of diskselector has
additional items for its rounding(carousel) effect.
Previously, elm_diskselector_item_icon_set(); did not care about
theses additional items.
Please review the attached patch that will care. Thanks.
Sincerely,
Sh
Dear all, hello.
I have tried to use the map with the diskselector.
The attached patch is just draft version for using map.
BUT.. just remind the Raster's comment "at least it can retain its api"...
I removed number of letters feature.. when I had changed the diskselector...
So.. even though an i
On Fri, Apr 27, 2012 at 3:55 PM, cnook wrote:
> Dear all, hello.
>
> I have tried to use the map with the diskselector.
> The attached patch is just draft version for using map.
Is it really draft version? imho, it's too good to be initial version.
i just found few points which can be improved.
Thanks for your response!
I have updated the previous patch based on your comments.
The indentation.. it is difficult to find where it is.. please enlighten me.
Effects.. definitely.. :)
Sincerely,
Shinwoo Kim.
2012/4/27 Hyoyoung Chang :
> On Fri, Apr 27, 2012 at 3:55 PM, cnook wrote:
>> Dear a
The effect looks good to me.
Comments here.
1. indentation in your patch.
line 79
line 115 ~ 136
2. more braces for if
if (x + (w / 2) < ox + (0.2 * ow))
-->
if ((x + (w / 2)) < (ox + (0.2 * ow)))
you need more braces for other if statements.
I'll wait for other's comments about map.
Thanks.
D
I'm glad to get your response.
The revised patch has been attached.
Please review the patch.. Thanks!
Sincerely,
Shinwoo Kim.
2012/4/30 Daniel Juyung Seo :
> The effect looks good to me.
> Comments here.
>
> 1. indentation in your patch.
> line 79
> line 115 ~ 136
>
> 2. more braces for if
> if (
ginal Message-
From: "Kim Shinwoo"<kimcinoo@gmail.com>
To: "Enlightenment developer
list"<enlightenment-devel@lists.sourceforge.net>;
Cc:
Sent: 2012-04-30 (월) 16:32:06
Subject: Re: [E-devel] [Patch] elm_diskselector, set icon to added item
I'm glad t
On Mon, 30 Apr 2012 16:32:06 +0900 Kim Shinwoo said:
actually not reviewing code itself here at all... going to review results. very
interesting and quite cool! it's a step in the right direction indeed! but it
does look a bit odd with the item flipping ONLY when it gets "to" the edge. i'm
actual
Please review this patch. Thanks.
2011/9/22 cnook :
> Dear All, Hello!
>
> If the diskselector is round mode, the scroller of diskselector has
> additional items for its rounding(carousel) effect.
> Previously, elm_diskselector_item_icon_set(); did not care about
> theses additional items.
> Pleas
On Thu, 22 Sep 2011 18:39:53 +0900 cnook said:
> Dear All, Hello!
>
> If the diskselector is round mode, the scroller of diskselector has
> additional items for its rounding(carousel) effect.
> Previously, elm_diskselector_item_icon_set(); did not care about
> theses additional items.
> Please r
Wow this sounds like diskselector needs to be rewritten a lot.
Daniel Juyung Seo (SeoZ)
On Mon, Oct 10, 2011 at 6:45 PM, Carsten Haitzler wrote:
> On Thu, 22 Sep 2011 18:39:53 +0900 cnook said:
>
>> Dear All, Hello!
>>
>> If the diskselector is round mode, the scroller of diskselector has
>> ad
On Mon, 10 Oct 2011 22:45:56 +0900 Daniel Juyung Seo
said:
at least it can retain its api. :)
> Wow this sounds like diskselector needs to be rewritten a lot.
>
> Daniel Juyung Seo (SeoZ)
>
> On Mon, Oct 10, 2011 at 6:45 PM, Carsten Haitzler
> wrote:
> > On Thu, 22 Sep 2011 18:39:53 +0900 cno
12 matches
Mail list logo
