Re: [E-devel] [Patch] patch for elm_module

2011-01-31 Thread The Rasterman
On Tue, 25 Jan 2011 14:46:04 +0900 WooHyun Jung said: i guess thats ok - though i doubt it makes a signficant difference :) in svn! > Hello. > > Mr. Wonguk Jeong made a patch for elm_module. > > This patch is for changing the timing of module loading. > > > > For now, module loading is

Re: [E-devel] [Patch] patch for elm_module

2011-01-24 Thread Tom Hacohen
Dear WooHyun, I haven't really reviewed the patch because I really don't know enough about elementary's modules. But I did manage to spot a couple of issues that mean that the patch can't be accepted: 1. line 15 of the patch: "if (_elm_module_load(m) == EINA_FALSE)" should be "if (!_elm_module_lo

[E-devel] [Patch] patch for elm_module

2011-01-24 Thread WooHyun Jung
Hello. Mr. Wonguk Jeong made a patch for elm_module. This patch is for changing the timing of module loading. For now, module loading is done in elm_init Thus, modules are always loaded, even if the application does not use them. So this patch deferred the timing of module loading to