Re: [E-devel] [e] FreeBSD patch

2012-12-07 Thread rustyBSD
Le 01/12/2012 10:02, rustyBSD a écrit : > We can also fix leaks. > > > I. Removed useless 'buf[sizeof(buf) - 1] = 0;', fgets() > already does that > > II. Ensure file descriptors are closed before 'goto error' > > III.We don't need to nullcheck before freeing a buf, as it's > already d

Re: [E-devel] [e] FreeBSD patch

2012-12-01 Thread rustyBSD
Le 01/12/2012 09:41, Michael Blumenkrantz a écrit : > On Sat, 01 Dec 2012 08:01:28 +0100 > rustyBSD wrote: > >> Hi, >> just a patch to avoid >> >> temperature/tempget.c: In function 'init': >> temperature/tempget.c:271: warning: passing argument 3 of 'sysctlnametomib' >> from incompatible pointe

Re: [E-devel] [e] FreeBSD patch

2012-12-01 Thread Michael Blumenkrantz
On Sat, 01 Dec 2012 08:01:28 +0100 rustyBSD wrote: > Hi, > just a patch to avoid > > temperature/tempget.c: In function 'init': > temperature/tempget.c:271: warning: passing argument 3 of 'sysctlnametomib' > from incompatible pointer type > temperature/tempget.c: In function 'check': > temperat

Re: [E-devel] [e] FreeBSD patch

2012-11-30 Thread Vincent Torri
in svn, thanks Vincent On Sat, Dec 1, 2012 at 8:01 AM, rustyBSD wrote: > Hi, > just a patch to avoid > > temperature/tempget.c: In function 'init': > temperature/tempget.c:271: warning: passing argument 3 of 'sysctlnametomib' > from incompatible pointer type > temperature/tempget.c: In function

[E-devel] [e] FreeBSD patch

2012-11-30 Thread rustyBSD
Hi, just a patch to avoid temperature/tempget.c: In function 'init': temperature/tempget.c:271: warning: passing argument 3 of 'sysctlnametomib' from incompatible pointer type temperature/tempget.c: In function 'check': temperature/tempget.c:379: warning: passing argument 4 of 'sysctl' from inco