On 06/09/12 16:44, Joerg Sonnenberger wrote:
> free(NULL) has been well defined since ANSI C89 at least.
Just checked, and you are right, thanks. I said I wasn't 100% sure about
this one.
--
Tom.
--
Live Security Virtu
On Wed, Sep 05, 2012 at 04:39:23PM +0300, Tom Hacohen wrote:
> On 05/09/12 16:26, Daniel Willmann wrote:
> > Hi,
> >
> > On 09/05/2012 02:12 PM, Tom Hacohen wrote:
> >> free, strlen and strcpy are just a few of the many examples that don't
> >> accept NULL. Having sanity checks everywhere is not "s
On 06/09/12 14:53, Carsten Haitzler (The Rasterman) wrote:
> they are still separate libs though. treat them as such until such a day as we
> have a single namespace. :)
>
>
And even then, they'll be different components...
--
Tom.
On Thu, 6 Sep 2012 19:23:41 +0900 Daniel Juyung Seo said:
> On Thu, Sep 6, 2012 at 7:00 PM, Carsten Haitzler wrote:
> > On Thu, 6 Sep 2012 13:18:15 +0900 Daniel Juyung Seo
> > said:
> >
> >> On Thu, Sep 6, 2012 at 8:54 AM, Carsten Haitzler
> >> wrote:
> >> > On Thu, 6 Sep 2012 01:14:34 +0900 D
On Thu, Sep 6, 2012 at 7:00 PM, Carsten Haitzler wrote:
> On Thu, 6 Sep 2012 13:18:15 +0900 Daniel Juyung Seo
> said:
>
>> On Thu, Sep 6, 2012 at 8:54 AM, Carsten Haitzler
>> wrote:
>> > On Thu, 6 Sep 2012 01:14:34 +0900 Daniel Juyung Seo
>> > said:
>> >
>> >> I am sick and tired of hearing t
On Thu, 6 Sep 2012 13:18:15 +0900 Daniel Juyung Seo said:
> On Thu, Sep 6, 2012 at 8:54 AM, Carsten Haitzler wrote:
> > On Thu, 6 Sep 2012 01:14:34 +0900 Daniel Juyung Seo
> > said:
> >
> >> I am sick and tired of hearing that "EFL code sucks" because of those
> >> missing exception handlings.
2012/9/6 Tom Hacohen :
> Raster and I completely agree here, so you can see most of "my" response
> in his email in his words. :)
>
> But there's one more thing I wanted to add: I love error-free and
> defensive coding, I think it's good and needed. I'm not arguing here
> whether we should write sa
Raster and I completely agree here, so you can see most of "my" response
in his email in his words. :)
But there's one more thing I wanted to add: I love error-free and
defensive coding, I think it's good and needed. I'm not arguing here
whether we should write safe code or not, I'm arguing abo
For consistency, EINA_SAFETY_ON_NULL_RETURN.
-Regards, Hermet-
-Original Message-
From: "Daniel Juyung Seo"
To: "Tom Hacohen";
Cc: "Enlightenment developer list";
Sent: 2012-09-06 (목) 13:27:29
Subject: Re: [E-devel
On Thu, Sep 6, 2012 at 1:39 AM, Tom Hacohen wrote:
> On 05/09/12 19:14, Daniel Juyung Seo wrote:
>> I am sick and tired of hearing that "EFL code sucks" because of those
>> missing exception handlings.
>>
>
> I'm out, so I'll give you a full reply tomorrow, but just regarding this
> sentence: mayb
removing them.
-Regards, Hermet-
-Original Message-
From: "Daniel Juyung Seo"
To: "Carsten Haitzler";
Cc: "Enlightenment developer list";
Sent: 2012-09-06 (목) 13:18:15
Subject: Re: [E-devel] Add Null Chekcing Routine in eet_lib
On Thu, Sep 6, 2012 at 8:54 AM,
On Thu, Sep 6, 2012 at 8:54 AM, Carsten Haitzler wrote:
> On Thu, 6 Sep 2012 01:14:34 +0900 Daniel Juyung Seo
> said:
>
>> I am sick and tired of hearing that "EFL code sucks" because of those
>> missing exception handlings.
>
> and do these people bitch about libc too? checking the programmers
On Thu, 6 Sep 2012 01:14:34 +0900 Daniel Juyung Seo said:
> I am sick and tired of hearing that "EFL code sucks" because of those
> missing exception handlings.
and do these people bitch about libc too? checking the programmers bad and
non-sensical input is a nicety we do in some places. it is
On 05/09/12 19:14, Daniel Juyung Seo wrote:
> I am sick and tired of hearing that "EFL code sucks" because of those
> missing exception handlings.
>
I'm out, so I'll give you a full reply tomorrow, but just regarding this
sentence: maybe you need to start talking to other people, i.e not the
peop
I think that maintain issue is more important than performance.
(except kernel or etc..) and there are so many dumb developers like
me :)
2012. 9. 6. 오전 1:15 Daniel Juyung Seo 작성:
> On Wed, Sep 5, 2012 at 11:31 PM, Tom Hacohen wrote:
>> On 05/09/12 17:18, Daniel Juyung Seo wrote:
>>>
>>> On Wed
On Wed, Sep 5, 2012 at 11:31 PM, Tom Hacohen wrote:
> On 05/09/12 17:18, Daniel Juyung Seo wrote:
>>
>> On Wed, Sep 5, 2012 at 10:12 PM, Tom Hacohen
>> wrote:
>>>
>>> Why should we? It makes really no sense. And if you want to rely on "past
>>> experience" i.e what people do, instead of sense, ta
On Wed, Sep 5, 2012 at 4:31 PM, Tom Hacohen wrote:
> On 05/09/12 17:18, Daniel Juyung Seo wrote:
>> On Wed, Sep 5, 2012 at 10:12 PM, Tom Hacohen wrote:
>>> Why should we? It makes really no sense. And if you want to rely on "past
>>> experience" i.e what people do, instead of sense, take a look a
They can change it whenever they want, they can change strlen not to
crash now if they want to, but they don't, and there's a good reason for
that.
--
Tom.
On 05/09/12 17:20, Daniel Juyung Seo wrote:
> I think EFL is younger than them and we still have a chance to avoid crashing.
>
> Daniel Juy
On 05/09/12 17:22, Daniel Juyung Seo wrote:
> Do you mean EINA_ARG_NONNULL?
> As far as I know, they don't do anything.
> They are just warning from header documentation.
> That's why they are not used that much and removed from some EFL libs
> several months ago.
They were removed because raster
On 05/09/12 17:18, Daniel Juyung Seo wrote:
> On Wed, Sep 5, 2012 at 10:12 PM, Tom Hacohen wrote:
>> Why should we? It makes really no sense. And if you want to rely on "past
>> experience" i.e what people do, instead of sense, take a look at libc:
>> free, strlen and strcpy are just a few of the
Do you mean EINA_ARG_NONNULL?
As far as I know, they don't do anything.
They are just warning from header documentation.
That's why they are not used that much and removed from some EFL libs
several months ago.
Daniel Juyung Seo (SeoZ)
On Wed, Sep 5, 2012 at 5:29 PM, Cedric BAIL wrote:
> On Wed,
I think EFL is younger than them and we still have a chance to avoid crashing.
Daniel Juyung Seo (SeoZ)
On Wed, Sep 5, 2012 at 10:39 PM, Tom Hacohen wrote:
> On 05/09/12 16:26, Daniel Willmann wrote:
>> Hi,
>>
>> On 09/05/2012 02:12 PM, Tom Hacohen wrote:
>>> free, strlen and strcpy are just a f
On Wed, Sep 5, 2012 at 10:12 PM, Tom Hacohen wrote:
> Why should we? It makes really no sense. And if you want to rely on "past
> experience" i.e what people do, instead of sense, take a look at libc:
> free, strlen and strcpy are just a few of the many examples that don't
> accept NULL. Having sa
So we use EINA_ MACROS? what should be removed in release version simply.
-Regards, Hermet-
-Original Message-
From: "Tom Hacohen"
To: "Enlightenment developer list";
Cc:
Sent: 2012-09-05 (수) 22:12:42
Subject: Re
On 05/09/12 16:26, Daniel Willmann wrote:
> Hi,
>
> On 09/05/2012 02:12 PM, Tom Hacohen wrote:
>> free, strlen and strcpy are just a few of the many examples that don't
>> accept NULL. Having sanity checks everywhere is not "safer", it just
>
> I agree with most things you said, just one note from
Hi,
On 09/05/2012 02:12 PM, Tom Hacohen wrote:
> free, strlen and strcpy are just a few of the many examples that don't
> accept NULL. Having sanity checks everywhere is not "safer", it just
I agree with most things you said, just one note from the free() man
page: "Otherwise, or if free(ptr) h
Why should we? It makes really no sense. And if you want to rely on
"past experience" i.e what people do, instead of sense, take a look at libc:
free, strlen and strcpy are just a few of the many examples that don't
accept NULL. Having sanity checks everywhere is not "safer", it just
hides bugs
we should check null at least for public apis.
Daniel Juyung Seo (SeoZ)
On Sep 5, 2012 5:23 PM, "Tom Hacohen" wrote:
> I'm not sure we really want to add NULL checks everywhere. If the docs
> say (or should say) passing NULL is not supported, we just shouldn't
> pass NULL. We can't possibly do s
On Wed, 5 Sep 2012 17:19:38 +0900 Sungho Kwak said:
> Hi,
>
> I still have 10 more null chekcing patches :(
> This patch is for eet_lib.c. eet_identity_x509, eet_identity_signature,
> eet_identity_sha1 can be crushed
> when fucntion tries to if(!ef->sugnature) when ef is null.
this should use e
On Wed, Sep 5, 2012 at 10:21 AM, Tom Hacohen wrote:
> I'm not sure we really want to add NULL checks everywhere. If the docs
> say (or should say) passing NULL is not supported, we just shouldn't
> pass NULL. We can't possibly do such sanity cases everywhere, as they'd
> just slow us and the apps
I'm not sure we really want to add NULL checks everywhere. If the docs
say (or should say) passing NULL is not supported, we just shouldn't
pass NULL. We can't possibly do such sanity cases everywhere, as they'd
just slow us and the apps down, and bloat the code.
--
Tom.
On 05/09/12 11:19, Sun
Hi,
I still have 10 more null chekcing patches :(
This patch is for eet_lib.c. eet_identity_x509, eet_identity_signature,
eet_identity_sha1 can be crushed
when fucntion tries to if(!ef->sugnature) when ef is null.
Thanks.
Sincerely,
Sungho Kwak.
eet_lib.diff
Description: Binary data
--
32 matches
Mail list logo
