Re: [E-devel] Commit Review Rules and Requirements

2018-04-24 Thread Daniel Kolesa
On Tue, Apr 24, 2018, at 12:42, Stefan Schmidt wrote: > Hello. > > > On 04/23/2018 06:05 PM, Stephen Houston wrote: > > In our meeting today we discussed the need for more patch/commit reviewing > > and that there should be rules in place as to what should require a review > > before being

Re: [E-devel] Commit Review Rules and Requirements

2018-04-24 Thread Christophe Sadoine
On 24 April 2018 at 19:42, Stefan Schmidt wrote: > Hello. > > > On 04/23/2018 06:05 PM, Stephen Houston wrote: >> In our meeting today we discussed the need for more patch/commit reviewing >> and that there should be rules in place as to what should require a review >>

Re: [E-devel] Commit Review Rules and Requirements

2018-04-24 Thread Stefan Schmidt
Hello. On 04/23/2018 06:05 PM, Stephen Houston wrote: > In our meeting today we discussed the need for more patch/commit reviewing > and that there should be rules in place as to what should require a review > before being pushed into master. I was one of the persons who pushed for the

Re: [E-devel] Commit Review Rules and Requirements

2018-04-23 Thread Mike Blumenkrantz
As some are aware, I've been trialing this for some time, and with two small exceptions, every patch I've written for the past month (92 patches) has been reviewed and landed by a third party, ie. someone who is not me. Half of these have been submitted and reviewed through phabricator and are

[E-devel] Commit Review Rules and Requirements

2018-04-23 Thread Stephen Houston
In our meeting today we discussed the need for more patch/commit reviewing and that there should be rules in place as to what should require a review before being pushed into master. These were some suggestions: Any commit that: A. Is not a fix or a feature planned for the next release B. Is