Re: [E-devel] E SVN: cedric trunk/efl/src/lib/eina

2013-01-26 Thread Tom Hacohen
Hey Leandro, That's the first idea he had. I was against it, and he came to agree with me. The reason for that, is that it doesn't imply there's something going on at the end, and it's more likely people will return/go out in the middle of the block. On Sat, Jan 26, 2013 at 2:35 PM, Leandro Per

Re: [E-devel] E SVN: cedric trunk/efl/src/lib/eina

2013-01-26 Thread Leandro Pereira
On Mon, Jan 21, 2013 at 1:11 AM, Enlightenment SVN wrote: > +#define EINA_COW_WRITE_BEGIN(Cow, Read, Write_Type, Write) \ > + do \ > +{ \ > + Wri

Re: [E-devel] E SVN: cedric trunk/efl/src/lib/eina

2013-01-21 Thread Cedric BAIL
On Mon, Jan 21, 2013 at 8:33 PM, Gustavo Sverzut Barbieri wrote: > On Mon, Jan 21, 2013 at 9:22 AM, Cedric BAIL wrote: >> On Mon, Jan 21, 2013 at 7:39 PM, Gustavo Sverzut Barbieri >> wrote: >>> This macro declares a variable and do a mix of do-while split into two >>> macros that will likely cau

Re: [E-devel] E SVN: cedric trunk/efl/src/lib/eina

2013-01-21 Thread Gustavo Sverzut Barbieri
On Mon, Jan 21, 2013 at 9:31 AM, Tom Hacohen wrote: > On 21/01/13 11:22, Cedric BAIL wrote: >> On Mon, Jan 21, 2013 at 7:39 PM, Gustavo Sverzut Barbieri >> wrote: >>> This macro declares a variable and do a mix of do-while split into two >>> macros that will likely cause errors. Why did you choos

Re: [E-devel] E SVN: cedric trunk/efl/src/lib/eina

2013-01-21 Thread Gustavo Sverzut Barbieri
On Mon, Jan 21, 2013 at 9:22 AM, Cedric BAIL wrote: > On Mon, Jan 21, 2013 at 7:39 PM, Gustavo Sverzut Barbieri > wrote: >> This macro declares a variable and do a mix of do-while split into two >> macros that will likely cause errors. Why did you choose that over let user >> declare the variable

Re: [E-devel] E SVN: cedric trunk/efl/src/lib/eina

2013-01-21 Thread Tom Hacohen
On 21/01/13 11:22, Cedric BAIL wrote: > On Mon, Jan 21, 2013 at 7:39 PM, Gustavo Sverzut Barbieri > wrote: >> This macro declares a variable and do a mix of do-while split into two >> macros that will likely cause errors. Why did you choose that over let user >> declare the variable, avoiding the

Re: [E-devel] E SVN: cedric trunk/efl/src/lib/eina

2013-01-21 Thread Cedric BAIL
On Mon, Jan 21, 2013 at 7:39 PM, Gustavo Sverzut Barbieri wrote: > This macro declares a variable and do a mix of do-while split into two > macros that will likely cause errors. Why did you choose that over let user > declare the variable, avoiding the do-while? Because you need to execute someth

Re: [E-devel] E SVN: cedric trunk/efl/src/lib/eina

2013-01-21 Thread Gustavo Sverzut Barbieri
This macro declares a variable and do a mix of do-while split into two macros that will likely cause errors. Why did you choose that over let user declare the variable, avoiding the do-while? On Monday, January 21, 2013, Enlightenment SVN wrote: > Log: > efl: add eina_cow helper macro. > > > Aut

Re: [E-devel] E SVN: cedric trunk/efl/src/lib/eina

2012-12-30 Thread Cedric BAIL
On Mon, Dec 31, 2012 at 9:09 AM, Gustavo Sverzut Barbieri wrote: > On Sun, Dec 30, 2012 at 10:05 PM, Enlightenment SVN < > no-re...@enlightenment.org> wrote: >> Log: >> efl: add a way to allocate without memcpy data in an Eina_Inarray. > > could you name it _grow() and make it take an integer inst

Re: [E-devel] E SVN: cedric trunk/efl/src/lib/eina

2012-12-30 Thread Gustavo Sverzut Barbieri
On Sun, Dec 30, 2012 at 10:05 PM, Enlightenment SVN < no-re...@enlightenment.org> wrote: > Log: > efl: add a way to allocate without memcpy data in an Eina_Inarray. > could you name it _grow() and make it take an integer instead of just 1? I bet it will be useful if you have a couple of items an

Re: [E-devel] E SVN: cedric trunk/efl/src/lib/eina

2012-10-28 Thread Cedric BAIL
On Sun, Oct 28, 2012 at 1:32 PM, Vincent Torri wrote: > I see 2 remaining problems: > > line 149: > >tw = _eina_thread_win32_find(index); > > index is not defined. Do you mean t instead of index ? Yes, fixed. > Second problem : _current_index. It is initialized to 1, then the only > other us

Re: [E-devel] E SVN: cedric trunk/efl/src/lib/eina

2012-10-28 Thread Vincent Torri
I see 2 remaining problems: line 149: tw = _eina_thread_win32_find(index); index is not defined. Do you mean t instead of index ? Second problem : _current_index. It is initialized to 1, then the only other use of _current_index is : do { tw->index = _current_index++;