Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2012-10-18 Thread Cedric BAIL
On Fri, Oct 19, 2012 at 11:32 AM, Cedric BAIL wrote: > On Fri, Oct 19, 2012 at 11:18 AM, Gustavo Sverzut Barbieri > wrote: >> On Thursday, October 18, 2012, Enlightenment SVN wrote: >>> Log: >>> eina: eina_stringshare_add_lenght better to >>> return NULL when func args are wrong. >>> >>> Patc

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2012-10-18 Thread Cedric BAIL
On Fri, Oct 19, 2012 at 11:18 AM, Gustavo Sverzut Barbieri wrote: > On Thursday, October 18, 2012, Enlightenment SVN wrote: >> Log: >> eina: eina_stringshare_add_lenght better to >> return NULL when func args are wrong. >> >> Patch by Patryk Kaczmarek > >> >> >> Author: cedric >> Date:

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2012-10-18 Thread Gustavo Sverzut Barbieri
On Thursday, October 18, 2012, Enlightenment SVN wrote: > Log: > eina: eina_stringshare_add_lenght better to > return NULL when func args are wrong. > > Patch by Patryk Kaczmarek > > > > Author: cedric > Date: 2012-10-18 18:25:17 -0700 (Thu, 18 Oct 2012) > New Revision: 78209 > T

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2012-04-20 Thread Vincent Torri
On Fri, Apr 20, 2012 at 12:30 PM, Carsten Haitzler wrote: > On Fri, 20 Apr 2012 03:53:58 -0400 Michael Blumenkrantz > said: > >> On Thu, 19 Apr 2012 10:31:10 +0200 >> Vincent Torri wrote: >> >> > On Thu, Apr 19, 2012 at 10:17 AM, Michael Blumenkrantz >> > wrote: >> > > On Thu, 19 Apr 2012 11:09

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2012-04-20 Thread The Rasterman
On Fri, 20 Apr 2012 03:53:58 -0400 Michael Blumenkrantz said: > On Thu, 19 Apr 2012 10:31:10 +0200 > Vincent Torri wrote: > > > On Thu, Apr 19, 2012 at 10:17 AM, Michael Blumenkrantz > > wrote: > > > On Thu, 19 Apr 2012 11:09:59 +0300 > > > Tom Hacohen wrote: > > > > > >> On 19/04/12 10:34, M

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2012-04-20 Thread Michael Blumenkrantz
On Thu, 19 Apr 2012 10:31:10 +0200 Vincent Torri wrote: > On Thu, Apr 19, 2012 at 10:17 AM, Michael Blumenkrantz > wrote: > > On Thu, 19 Apr 2012 11:09:59 +0300 > > Tom Hacohen wrote: > > > >> On 19/04/12 10:34, Michael Blumenkrantz wrote: > >> > bottom line: this is a feature; we are in a feat

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2012-04-19 Thread Vincent Torri
On Thu, Apr 19, 2012 at 10:17 AM, Michael Blumenkrantz wrote: > On Thu, 19 Apr 2012 11:09:59 +0300 > Tom Hacohen wrote: > >> On 19/04/12 10:34, Michael Blumenkrantz wrote: >> > bottom line: this is a feature; we are in a feature freeze, and we have >> > been >> > for a month. it must be removed

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2012-04-19 Thread Michael Blumenkrantz
On Thu, 19 Apr 2012 11:19:52 +0300 Tom Hacohen wrote: > On 19/04/12 11:17, Michael Blumenkrantz wrote: > > there's a number of other commits which also have broken the freeze, but I'm > > still hopeful that, for the non-essential ones, the authors will acknowledge > > their fault and revert the c

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2012-04-19 Thread Tom Hacohen
On 19/04/12 11:17, Michael Blumenkrantz wrote: > there's a number of other commits which also have broken the freeze, but I'm > still hopeful that, for the non-essential ones, the authors will acknowledge > their fault and revert the commits. > To be honest, I forgot about the freeze. -- Tom. --

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2012-04-19 Thread Michael Blumenkrantz
On Thu, 19 Apr 2012 11:09:59 +0300 Tom Hacohen wrote: > On 19/04/12 10:34, Michael Blumenkrantz wrote: > > bottom line: this is a feature; we are in a feature freeze, and we have been > > for a month. it must be removed immediately. > > > > It seems you are correct. > > -- > Tom. there's a num

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2012-04-19 Thread Tom Hacohen
On 19/04/12 10:34, Michael Blumenkrantz wrote: > bottom line: this is a feature; we are in a feature freeze, and we have been > for a month. it must be removed immediately. > It seems you are correct. -- Tom. -- For Deve

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2012-04-19 Thread Vincent Torri
On Thu, Apr 19, 2012 at 9:34 AM, Michael Blumenkrantz wrote: > On Thu, 19 Apr 2012 09:57:01 +0300 > Tom Hacohen wrote: > >> On 19/04/12 03:25, Cedric BAIL wrote: >> > Having a log post callback could be interesting, but I am wondering >> > what else use it could have than current eina_log don't h

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2012-04-19 Thread Michael Blumenkrantz
On Thu, 19 Apr 2012 09:57:01 +0300 Tom Hacohen wrote: > On 19/04/12 03:25, Cedric BAIL wrote: > > Having a log post callback could be interesting, but I am wondering > > what else use it could have than current eina_log don't have. Do you > > have any use case in mind ? > > Yeah, that's why I sa

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2012-04-19 Thread Tom Hacohen
On 19/04/12 03:25, Cedric BAIL wrote: > Having a log post callback could be interesting, but I am wondering > what else use it could have than current eina_log don't have. Do you > have any use case in mind ? Yeah, that's why I said "no comment" I can't find a use case for it... The purpose of th

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2012-04-18 Thread Cedric BAIL
On Wed, Apr 18, 2012 at 8:49 PM, Tom Hacohen wrote: > On 18/04/12 14:44, Gustavo Sverzut Barbieri wrote: >> You are forcing it to a fixed File descriptor. Also you're imposing the >> getenv() in every log function. Make it a global state that can be enabled >> based on a numerical level. I'd also

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2012-04-18 Thread Tom Hacohen
On 18/04/12 14:44, Gustavo Sverzut Barbieri wrote: > You are forcing it to a fixed File descriptor. Also you're imposing the > getenv() in every log function. Make it a global state that can be enabled > based on a numerical level. I'd also introduce a new backtrace function > that can be provided

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2012-04-18 Thread Gustavo Sverzut Barbieri
You are forcing it to a fixed File descriptor. Also you're imposing the getenv() in every log function. Make it a global state that can be enabled based on a numerical level. I'd also introduce a new backtrace function that can be provided by user, or just a generic "post log" user function that ca

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2012-03-14 Thread Vincent Torri
what about eina_file_win32.c ? Vincent On Wed, Mar 14, 2012 at 4:35 PM, Enlightenment SVN wrote: > Log: > eina: fix dead lock issue. This is hidding a bug with eina_hash_pointer_new. > > > Author:       cedric > Date:         2012-03-14 08:35:12 -0700 (Wed, 14 Mar 2012) > New Revision: 69338 > T

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2012-03-07 Thread Cedric BAIL
On Wed, Mar 7, 2012 at 11:48 AM, Vincent Torri wrote: > is that patch for win32 correct ? I think yes, as the delete_me should be triggered only when the file changed not the other way around... > Index: eina_file_win32.c > === > --

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2012-03-07 Thread Vincent Torri
is that patch for win32 correct ? Index: eina_file_win32.c === --- eina_file_win32.c (revision 68885) +++ eina_file_win32.c (working copy) @@ -922,7 +922,7 @@ file = eina_hash_find(_eina_file_cache, filename); if (file &&

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2011-08-09 Thread Vincent Torri
use a DWORD, not a HANDLE Vincent On Tue, 9 Aug 2011, Enlightenment SVN wrote: > Log: > eina: detect main loop for windows to. > > > Author: cedric > Date: 2011-08-09 01:47:57 -0700 (Tue, 09 Aug 2011) > New Revision: 62239 > Trac: http://trac.enlightenment.org/e/changeset/

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2011-05-17 Thread Vincent Torri
On Tue, 17 May 2011, Enlightenment SVN wrote: > Log: > eina: fix eina_file to be really usable. too bad you didn't fix the windows part too... Vincent > > > Author: cedric > Date: 2011-05-17 09:17:28 -0700 (Tue, 17 May 2011) > New Revision: 59470 > Trac: http://trac.enli

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2011-04-12 Thread Cedric BAIL
On Tue, Apr 12, 2011 at 11:27 AM, Vincent Torri wrote: > On Tue, 12 Apr 2011, Enlightenment SVN wrote: >> Log: >> eina: fix 64bits warning. >> >> Author:       cedric >> Date:         2011-04-12 02:00:45 -0700 (Tue, 12 Apr 2011) >> New Revision: 58583 >> Trac:         http://trac.enlightenment.org

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2011-04-12 Thread Vincent Torri
On Tue, 12 Apr 2011, Enlightenment SVN wrote: > Log: > eina: fix 64bits warning. > > > Author: cedric > Date: 2011-04-12 02:00:45 -0700 (Tue, 12 Apr 2011) > New Revision: 58583 > Trac: http://trac.enlightenment.org/e/changeset/58583 > > Modified: > trunk/eina/src/lib/eina_

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2011-04-12 Thread Vincent Torri
On Tue, 12 Apr 2011, Enlightenment SVN wrote: > Log: > eina: fix 64bits warning. > > > Author: cedric > Date: 2011-04-12 02:00:45 -0700 (Tue, 12 Apr 2011) > New Revision: 58583 > Trac: http://trac.enlightenment.org/e/changeset/58583 > > Modified: > trunk/eina/src/lib/eina_

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2010-10-28 Thread Vincent Torri
On Thu, 28 Oct 2010, Cedric BAIL wrote: On Thu, Oct 28, 2010 at 12:29 PM, Vincent Torri wrote: On Thu, 28 Oct 2010, Enlightenment SVN wrote: Log:       * eina: fix usage of eina_file_*ls in thread. no readdir_r on Windows, and offsetof does not exist on win ce Damn windows ! Well, the b

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2010-10-28 Thread Cedric BAIL
On Thu, Oct 28, 2010 at 12:29 PM, Vincent Torri wrote: > On Thu, 28 Oct 2010, Enlightenment SVN wrote: >> Log: >>       * eina: fix usage of eina_file_*ls in thread. > > no readdir_r on Windows, and offsetof does not exist on win ce Damn windows ! Well, the best solution would be to provide a cod

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2010-10-28 Thread Vincent Torri
On Thu, 28 Oct 2010, Enlightenment SVN wrote: > Log: > * eina: fix usage of eina_file_*ls in thread. no readdir_r on Windows, and offsetof does not exist on win ce Vincent > Author: cedric > Date: 2010-10-28 02:59:27 -0700 (Thu, 28 Oct 2010) > New Revision: 53948 > > Modi

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2010-07-19 Thread Vincent Torri
On Mon, 19 Jul 2010, Enlightenment SVN wrote: > Log: > * eina: fix tolower call. > > Author: cedric > Date: 2010-07-19 04:25:10 -0700 (Mon, 19 Jul 2010) > New Revision: 50366 > > Modified: > trunk/eina/src/lib/eina_str.c > > Modified: trunk/eina/src/lib/eina_str.c >

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2008-12-29 Thread Gustavo Sverzut Barbieri
On Mon, Dec 29, 2008 at 2:11 PM, The Rasterman Carsten Haitzler wrote: > On Mon, 29 Dec 2008 16:52:43 +0100 "Cedric BAIL" > babbled: > >> On Mon, Dec 29, 2008 at 2:53 PM, Gustavo Sverzut Barbieri >> wrote: >> > On Mon, Dec 29, 2008 at 11:38 AM, Cedric BAIL wrote: >> >> On Mon, Dec 29, 2008 at

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2008-12-29 Thread The Rasterman
On Mon, 29 Dec 2008 16:52:43 +0100 "Cedric BAIL" babbled: > On Mon, Dec 29, 2008 at 2:53 PM, Gustavo Sverzut Barbieri > wrote: > > On Mon, Dec 29, 2008 at 11:38 AM, Cedric BAIL wrote: > >> On Mon, Dec 29, 2008 at 2:02 PM, Gustavo Sverzut Barbieri > >> wrote: > >>> On Mon, Dec 29, 2008 at 10:41

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2008-12-29 Thread Cedric BAIL
On Mon, Dec 29, 2008 at 2:53 PM, Gustavo Sverzut Barbieri wrote: > On Mon, Dec 29, 2008 at 11:38 AM, Cedric BAIL wrote: >> On Mon, Dec 29, 2008 at 2:02 PM, Gustavo Sverzut Barbieri >> wrote: >>> On Mon, Dec 29, 2008 at 10:41 AM, Enlightenment SVN >>> wrote: Log: Don't generate warnin

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2008-12-29 Thread Gustavo Sverzut Barbieri
On Mon, Dec 29, 2008 at 11:38 AM, Cedric BAIL wrote: > On Mon, Dec 29, 2008 at 2:02 PM, Gustavo Sverzut Barbieri > wrote: >> On Mon, Dec 29, 2008 at 10:41 AM, Enlightenment SVN >> wrote: >>> Log: >>> Don't generate warning in some little case. >> >> I strongly disagree with this patch. Eina Has

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2008-12-29 Thread Cedric BAIL
On Mon, Dec 29, 2008 at 2:02 PM, Gustavo Sverzut Barbieri wrote: > On Mon, Dec 29, 2008 at 10:41 AM, Enlightenment SVN > wrote: >> Log: >> Don't generate warning in some little case. > > I strongly disagree with this patch. Eina Hash is not like Evas Hash, > by hiding this "warnings in some litt

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2008-12-29 Thread Gustavo Sverzut Barbieri
On Mon, Dec 29, 2008 at 10:41 AM, Enlightenment SVN wrote: > Log: > Don't generate warning in some little case. I strongly disagree with this patch. Eina Hash is not like Evas Hash, by hiding this "warnings in some little case" we're hiding bugs. It's better to fix those bugs and not hide these

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2008-12-11 Thread Gustavo Sverzut Barbieri
On Thu, Dec 11, 2008 at 11:54 AM, Enlightenment SVN <[EMAIL PROTECTED]> wrote: > Log: > Manipulating NULL iterator should be concidered as a defined behaviour as it > give the possibility to write small code like : I disagree with that, it's eina_hash fault to return NULL if it is empty. It's be

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2008-11-10 Thread Cedric BAIL
On Mon, Nov 10, 2008 at 10:55 PM, Gustavo Sverzut Barbieri <[EMAIL PROTECTED]> wrote: > On Mon, Nov 10, 2008 at 12:32 PM, Enlightenment SVN > <[EMAIL PROTECTED]> wrote: >> Log: >> Fix order of free during hash free. >> >> Author: cedric >> Date: 2008-11-10 06:32:14 -0800 (Mon, 10 Nov

Re: [E-devel] E SVN: cedric trunk/eina/src/lib

2008-11-10 Thread Gustavo Sverzut Barbieri
On Mon, Nov 10, 2008 at 12:32 PM, Enlightenment SVN <[EMAIL PROTECTED]> wrote: > Log: > Fix order of free during hash free. > > Author: cedric > Date: 2008-11-10 06:32:14 -0800 (Mon, 10 Nov 2008) > New Revision: 37572 > > Modified: > trunk/eina/src/lib/eina_hash.c > > Modified: trun