Re: [E-devel] E SVN: sanjeev trunk/elementary/src/lib

2012-03-06 Thread Michael Blumenkrantz
On Tue, 6 Mar 2012 18:57:36 -0800 "Enlightenment SVN" wrote: > Log: > Fix elm_multibuttonentry API to have callbacks. For now we only have the API > format fixed. This code needs lot more refactoring after discussing with the > widget author. So, we will address the implementation later. Signed-

Re: [E-devel] E SVN: sanjeev trunk/elementary/src/lib

2012-02-24 Thread Elevate Efl
Applications depending on _MAX behaviour or its value, are already asking for trouble in multiple ways. I have seen plenty of example of _MAX abuse. For such apps., I would rather not have _MAX, than have it and fix their app. logic. Having MAX and adding new enums, changes the value of '_MAX' fo

Re: [E-devel] E SVN: sanjeev trunk/elementary/src/lib

2012-02-24 Thread Daniel Juyung Seo
On Fri, Feb 24, 2012 at 9:24 AM, Elevate Efl wrote: > No. > > *_MAX really doesn't give the app. developer anything useful. Hello, > It has been added for the convenience (bounds checking) of the widget > implementation. Exactly, that's why they're needed. Without it, if the last member of the

Re: [E-devel] E SVN: sanjeev trunk/elementary/src/lib

2012-02-23 Thread Elevate Efl
No. *_MAX really doesn't give the app. developer anything useful. It has been added for the convenience (bounds checking) of the widget implementation. If we expose _MAX we need to tell the app. developer what is the expected behaviour if he uses it, which is unnecessary. On Fri, Feb 24, 201

Re: [E-devel] E SVN: sanjeev trunk/elementary/src/lib

2012-02-23 Thread Tom Hacohen
REVERT! :) Really though, judging from Daniel's comment it sounds like someone should revert it. -- Tom. On 23/02/12 18:12, Daniel Juyung Seo wrote: > Dear Sanjeev, > > On Thu, Feb 23, 2012 at 11:52 AM, Enlightenment SVN > wrote: >> Log: >> Remove MAX, it is not useful for app. developers. >

Re: [E-devel] E SVN: sanjeev trunk/elementary/src/lib

2012-02-23 Thread Daniel Juyung Seo
Dear Sanjeev, On Thu, Feb 23, 2012 at 11:52 AM, Enlightenment SVN wrote: > Log: > Remove MAX, it is not useful for app. developers. This means new selection type will never be added? Daniel Juyung Seo (SeoZ) > >  Signed-off-by: Sanjeev BA > > Author:       sanjeev > Date:         2012-02-22

Re: [E-devel] E SVN: sanjeev trunk/elementary/src/lib

2012-02-14 Thread Tom Hacohen
Yeah. Non-code changes can me merged together to one commit. -- Tom. On 14/02/12 10:53, Michael Blumenkrantz wrote: > On Tue, 14 Feb 2012 00:50:53 -0800 > "Enlightenment SVN" wrote: > >> Log: >> Fix typos in documentation #11. >> >>Signed-off-by: Sanjeev BA >> >> Author: sanjeev >> Da

Re: [E-devel] E SVN: sanjeev trunk/elementary/src/lib

2012-02-14 Thread Michael Blumenkrantz
On Tue, 14 Feb 2012 00:50:53 -0800 "Enlightenment SVN" wrote: > Log: > Fix typos in documentation #11. > > Signed-off-by: Sanjeev BA > > Author: sanjeev > Date: 2012-02-14 00:50:53 -0800 (Tue, 14 Feb 2012) > New Revision: 67914 > Trac: http://trac.enlightenment.org/e/