Hello.
On 19/02/13 06:49, ChunEon Park wrote:
>
> I'm not sure. is it right fix?
Very well spotted. My fix did only fix the error case. We never free'ed
this buffer though. :)
Fixed in rev 84087. Thanks for reviewing this.
regards
Stefan Schmidt
---
I'm not sure. is it right fix?
-Regards, Hermet-
-Original Message-
From: "Enlightenment SVN"
To: ;
Cc:
Sent: 2012-12-19 (수) 19:28:21
Subject: E SVN: stefan trunk/elementary/src/lib
Log:
elm/map: Free buffer on error path
Author: stefan
Date: 2012-12-19 02:28:20 -080
Ok. Just curious :)
And yes it is a good practice.
Thanks.
Daniel Juyung Seo (SeoZ)
On Wed, Oct 3, 2012 at 6:28 PM, Stefan Schmidt wrote:
> Hello.
>
> On 03/10/12 09:32, Daniel Juyung Seo wrote:
>> Good catch but it's not needed.
>> EINA_INLIST_FOREACH_SAFE assign the proper value or NULL to itc
Hello.
On 03/10/12 09:32, Daniel Juyung Seo wrote:
> Good catch but it's not needed.
> EINA_INLIST_FOREACH_SAFE assign the proper value or NULL to itc anyway.
> Did you have any problem with that?
No actually problem. Just spotted it and thought it might be better to
be on the safe side, but tha
Good catch but it's not needed.
EINA_INLIST_FOREACH_SAFE assign the proper value or NULL to itc anyway.
Did you have any problem with that?
Daniel Juyung Seo (SeoZ)
On Tue, Oct 2, 2012 at 9:53 PM, Enlightenment SVN
wrote:
> Log:
> elementary/genlist: Init itc to NULL before using it.
>
> Author:
On 06/14/2012 04:01 PM, Enlightenment SVN wrote:
> Log:
> elementary/elm_win: Check argument for NULL before we pass it to strncmp
>
>strncmp() really does not like that. So we should not be lazy and check
> for it. Say thanks to
>scan-build which reported these to me.
In that case you sh
