Re: [E-devel] ecore_exe API addition

2017-06-11 Thread The Rasterman
On Sun, 11 Jun 2017 19:36:20 + Andrew Williams said: > Hi, > > Indeed some of the waits could be done async but the code becomes so much > more complex. In many cases it is easier to spawn a thread, execute a bunch > of calls that wait, then call back. > > Some of the wait code is a little

Re: [E-devel] ecore_exe API addition

2017-06-11 Thread Andrew Williams
Hi, Indeed some of the waits could be done async but the code becomes so much more complex. In many cases it is easier to spawn a thread, execute a bunch of calls that wait, then call back. Some of the wait code is a little lazy but the callbacks for threading of serial events becomes very confus

Re: [E-devel] ecore_exe API addition

2017-06-11 Thread The Rasterman
On Sun, 11 Jun 2017 13:19:40 +0200 Vincent Torri said: > On Sun, Jun 11, 2017 at 12:53 PM, Carsten Haitzler > wrote: > > > On Sun, 11 Jun 2017 09:59:51 +0200 Vincent Torri > > said: > > > > > hey > > > > > > EDI uses waitpid to wait for the child to terminate. On Windows, this > > > function d

Re: [E-devel] ecore_exe API addition

2017-06-11 Thread Vincent Torri
On Sun, Jun 11, 2017 at 12:53 PM, Carsten Haitzler wrote: > On Sun, 11 Jun 2017 09:59:51 +0200 Vincent Torri > said: > > > hey > > > > EDI uses waitpid to wait for the child to terminate. On Windows, this > > function does not exist. I propose the following path in ecore_exe to > avoid > > #ifde

Re: [E-devel] ecore_exe API addition

2017-06-11 Thread The Rasterman
On Sun, 11 Jun 2017 09:59:51 +0200 Vincent Torri said: > hey > > EDI uses waitpid to wait for the child to terminate. On Windows, this > function does not exist. I propose the following path in ecore_exe to avoid > #ifdef in EDI. > > please review, test, and if it is good enough (API-wise), co

Re: [E-devel] ecore_exe API addition

2017-06-11 Thread Vincent Torri
fixes of the previous patch : missing exit code in the win32 code, and missing declaration in Ecore_Common.h Vincent On Sun, Jun 11, 2017 at 9:59 AM, Vincent Torri wrote: > hey > > EDI uses waitpid to wait for the child to terminate. On Windows, this > function does not exist. I propose the fol

[E-devel] ecore_exe API addition

2017-06-11 Thread Vincent Torri
hey EDI uses waitpid to wait for the child to terminate. On Windows, this function does not exist. I propose the following path in ecore_exe to avoid #ifdef in EDI. please review, test, and if it is good enough (API-wise), commit it Vincent diff --git a/src/lib/ecore/ecore_exe.c b/src/lib/ecore