Original Message-
> From: 박춘언 [mailto:her...@naver.com]
> Sent: Saturday, December 11, 2010 4:35 PM
> To: EFL
> Subject: [E-devel] elm_transit patch
>
> Hi, This is Hermet.
>
> Could somebody please check and apply this patch ?
>
> -It removed deprecated el
Hi, there.
Could somebody check this patch ?
Thanks.
-Original Message-
From: 박춘언 [mailto:her...@naver.com]
Sent: Saturday, December 11, 2010 4:35 PM
To: EFL
Subject: [E-devel] elm_transit patch
Hi, This is Hermet.
Could somebody please check and apply this patch ?
-It removed
Hi, This is Hermet.
Could somebody please check and apply this patch ?
-It removed deprecated elm_transit APIs.
Thanks.
Index: Elementary.h.in
===
--- Elementary.h.in (revision 55487)
+++ Elementary.h.in (working copy)
@@ -
On Thu, 9 Dec 2010 08:31:07 -0200 Gustavo Sverzut Barbieri
said:
> On Thu, Dec 9, 2010 at 4:30 AM, ChunEon Park wrote:
> > Here is new elm_transit patch .
> >
> > Fixed indentation and fixed some logic of flip/resizableflip/wipe effect.
>
> Hi,
>
> As Mike said, don't mix whitespaces, bug fixe
inal Message-
> From: ChunEon Park [mailto:chuneon.p...@samsung.com]
> Sent: Thursday, December 09, 2010 3:06 PM
> To: 마이크; enlightenment-devel@lists.sourceforge.net
> Subject: Re: [E-devel] elm_transit patch
>
>
>sorry. I missed that
>
>I will try again s
Hello k-s,
this is so much helpful advice.
Thanks!
Daniel Juyung Seo.
On Thu, Dec 9, 2010 at 7:31 PM, Gustavo Sverzut Barbieri
wrote:
> On Thu, Dec 9, 2010 at 4:30 AM, ChunEon Park wrote:
>> Here is new elm_transit patch .
>>
>> Fixed indentation and fixed some logic of flip/resizableflip/wipe
On Thu, Dec 9, 2010 at 9:05 AM, ChunEon Park wrote:
> Thanks Barbieri.
>
>
>
> I will try it as your advice.
>
>
>
> I'm not good at contribution yet.
>
> However, these adivces makes me much better for contribution...
>
sure :-)
> Because I don't know who is using elm_transit_event_block_xx
emove them?
If it is, i will just get rid of them and no MACROS also.
Thanks.
--- Original Message ---
Sender : Gustavo Sverzut Barbieri
Date : 2010-12-09 19:31 (GMT+09:00)
Title : Re: [E-devel] elm_transit patch
On Thu, Dec 9, 2010 at 4:30 AM, ChunEon Park wrote:
On Thu, Dec 9, 2010 at 4:30 AM, ChunEon Park wrote:
> Here is new elm_transit patch .
>
> Fixed indentation and fixed some logic of flip/resizableflip/wipe effect.
Hi,
As Mike said, don't mix whitespaces, bug fixes and refactories in the
same patch. Yes, Raster is a very bad example and does thi
Subject: Re: [E-devel] elm_transit patch
sorry. I missed that
I will try again soon.
Thanks.
--- Original Message ---
Sender : 마이크 책임/Mobile S/W Platform
Lab(DMC연)/삼성전자
Date : 2010-12-09 14:42 (GMT+09:00)
Title : Re: [E-devel] elm_transit patch
sorry. I missed that
I will try again soon.
Thanks.
--- Original Message ---
Sender : 마이크 책임/Mobile S/W Platform
Lab(DMC연)/삼성전자
Date : 2010-12-09 14:42 (GMT+09:00)
Title : Re: [E-devel] elm_transit patch
Hello Hermet,
Please avoid changing
Hello Hermet,
Please avoid changing spacing in your patches, it makes them harder to read.
Additionally, I don't think Raster will appreciate you coming up with a
new indentation style for EFL...
Patches should contain the important pieces you want to change, and nothing
else.
thanks,
Mike
-
Sorry, it filtered the patch file .
try again.
-Original Message-
From: ChunEon Park [mailto:chuneon.p...@samsung.com]
Sent: Thursday, December 09, 2010 2:23 PM
To: 'enlightenment-devel@lists.sourceforge.net'
Subject: elm_transit patch
Hello, This is Hermet.
Here is a first patch fo
Hello, This is Hermet.
Here is a first patch for the elm_transit.
* deprecated elm_transit_event_block_set and added
elm_transit_event_enabled_set
* modified event_enabled = EINA_FALSE as a default
Thanks.
--
This S
14 matches
Mail list logo
