Re: [E-devel] internal elm casting

2011-10-17 Thread The Rasterman
barbi...@profusion.mobi> > To: "Enlightenment developer > list"<enlightenment-devel@lists.sourceforge.net> Cc: > Sent: 11-10-17(월) 22:06:50 > Subject: Re: [E-devel] internal elm casting > ACK > On Monday, October 17, 2011, Tom Hacohen > <tom.haco...@partner.samsung.com>

Re: [E-devel] internal elm casting

2011-10-17 Thread Tom Hacohen
On 17/10/11 17:54, ChunEon Park wrote: > but make us to type shortly. > i.e) > Elm_Widget_Item *it = ... > Elm_Diskselector_Item *git = ELM_CAST(it); > That's a discouraged usage. You should do Elm_Diskselector_Item *git = (Elm_Diskselector_Item *) it; I.e, don't cast to (void *) in the proc

Re: [E-devel] internal elm casting

2011-10-17 Thread ChunEon Park
list"<enlightenment-devel@lists.sourceforge.net> Cc: Sent: 11-10-17(월) 22:06:50 Subject: Re: [E-devel] internal elm casting ACK On Monday, October 17, 2011, Tom Hacohen <tom.haco...@partner.samsung.com> wrote: > On 17/10/11 14:32, Mike Blumenkrantz wrote: >> Hi, >> >&g

Re: [E-devel] internal elm casting

2011-10-17 Thread Gustavo Sverzut Barbieri
ACK On Monday, October 17, 2011, Tom Hacohen wrote: > On 17/10/11 14:32, Mike Blumenkrantz wrote: >> Hi, >> >> At some point recently, someone introduced a macro which does: >>#define ELM_CAST(p) ((void *)(p)) >> >> This macro needs to be either changed or removed, as it does nothing but >> n

Re: [E-devel] internal elm casting

2011-10-17 Thread Tom Hacohen
On 17/10/11 14:32, Mike Blumenkrantz wrote: > Hi, > > At some point recently, someone introduced a macro which does: >#define ELM_CAST(p) ((void *)(p)) > > This macro needs to be either changed or removed, as it does nothing but > needlessly obfuscate code (not to mention takes longer to type/r

[E-devel] internal elm casting

2011-10-17 Thread Mike Blumenkrantz
Hi, At some point recently, someone introduced a macro which does: #define ELM_CAST(p) ((void *)(p)) This macro needs to be either changed or removed, as it does nothing but needlessly obfuscate code (not to mention takes longer to type/read than (void*)). -- Mike Blumenkrantz Zentific: Codin