davemds pushed a commit to branch master.
http://git.enlightenment.org/bindings/python/python-efl.git/commit/?id=71946bffb374f741c0f94e19e4da3e8fde9c691f
commit 71946bffb374f741c0f94e19e4da3e8fde9c691f
Author: Dave Andreoli <d...@gurumeditation.it>
Date: Wed Aug 10 18:38:32 2016 +0200
Mark the ComboBox widget as broken/deprecated.
This is really sad, but the combobox is broken by design and should have
been never used in legacy code.
Really, really, sorry about the inconvenience!!
---
doc/elementary/combobox.rst | 12 +++++++++++-
efl/elementary/combobox.pxi | 25 +++++++++++++++++++++++++
examples/elementary/test_combobox.py | 12 +++++++++++-
3 files changed, 47 insertions(+), 2 deletions(-)
diff --git a/doc/elementary/combobox.rst b/doc/elementary/combobox.rst
index 713416a..71636a6 100644
--- a/doc/elementary/combobox.rst
+++ b/doc/elementary/combobox.rst
@@ -3,8 +3,18 @@
Combobox
########
-.. image:: /images/combobox-preview.png
+.. warning::
+ **THE COMBOBOX IS BROKEN AND DEPRECATED, DO NOT USE IN ANY CASE !!**
+
+ The behaviour and the API of the Combobox will change in future release.
+
+ If you are already using this we really encourage you to switch
+ to other widgets.
+ We are really sorry about this breakage, but there is nothing we can do
+ to avoid this :(
+
+.. image:: /images/combobox-preview.png
Widget description
==================
diff --git a/efl/elementary/combobox.pxi b/efl/elementary/combobox.pxi
index 5253468..f32b609 100644
--- a/efl/elementary/combobox.pxi
+++ b/efl/elementary/combobox.pxi
@@ -97,8 +97,22 @@ class Combobox(_Combobox, Button, Entry, Genlist, Hover):
This is the class that actually implements the widget.
+ .. warning::
+ **THE COMBOBOX WIDGET IS BROKEN AND DEPRECATED, DO NOT USE IN ANY CASE
!!**
+
+ The behaviour and the API of the Combobox will change in future
release.
+
+ If you are already using this we really encourage you to switch
+ to other widgets.
+
+ We are really sorry about this breakage, but there is nothing we can do
+ to avoid this :(
+
.. versionadded:: 1.17
+ .. versionchanged:: 1.18
+ The combobox widget has been deprecated. Don't use it in ANY case.
+
"""
def __init__(self, evasObject parent, *args, **kwargs):
"""Combobox(...)
@@ -109,6 +123,17 @@ class Combobox(_Combobox, Button, Entry, Genlist, Hover):
as properties of the instance
"""
+ print("""
+ **THE COMBOBOX IS BROKEN AND DEPRECATED, DO NOT USE IN ANY CASE !!**
+
+ The behaviour and the API of the Combobox will change in future
release.
+
+ If you are already using this we really encourage you to switch
+ to other widgets.
+
+ We are really sorry about this breakage, but there is nothing we can do
+ to avoid this :(
+ """)
_Combobox.__init__(self, parent, *args, **kwargs)
diff --git a/examples/elementary/test_combobox.py
b/examples/elementary/test_combobox.py
index 97b5d53..c60ed32 100644
--- a/examples/elementary/test_combobox.py
+++ b/examples/elementary/test_combobox.py
@@ -5,7 +5,7 @@ from efl.evas import EVAS_HINT_EXPAND, EXPAND_BOTH,
EXPAND_HORIZ, FILL_HORIZ, \
EVAS_ASPECT_CONTROL_VERTICAL
from efl import elementary as elm
from efl.elementary import StandardWindow, Box, Button, Icon, Separator, \
- Combobox, GenlistItemClass
+ Combobox, GenlistItemClass, Label
class ComboboxItemClass(GenlistItemClass):
@@ -98,6 +98,16 @@ def combobox_clicked(obj):
bx.pack_start(bt)
bt.show()
+ lb = Label(win, text="""<failure>
+<big><b>THE COMBOBOX WIDGET IS BROKEN AND DEPRECATED.<br>
+DO NOT USE IN ANY CASE.<b></big><br><br>
+The behaviour and the API of the Combobox will change in future release.<br>
<br>
+If you are already using this we really encourage you to switch to other
widgets.<br><br>
+We are really sorry about this breakage, but there is nothing we can do to
avoid this :( <br><br></failure>
+""")
+ bx.pack_start(lb)
+ lb.show()
+
#
win.show()
--
