englebass pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=50569a69c9072da46ee5c40e0a4fcc94ccb67563
commit 50569a69c9072da46ee5c40e0a4fcc94ccb67563
Author: Sebastian Dransfeld <s...@tango.flipp.net>
Date: Tue Dec 10 08:50:18 2013 +0100
ecore_x: ensure positive malloc size
size_ret is used later as an argument for malloc, so it should be
positive. In addition this should ensure that
ecore_x_window_porp_property_get returns a positive value and is true if
we malloc data.
Hopefully also fixes CID 1135636
---
src/lib/ecore_x/xlib/ecore_x_window_prop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/ecore_x/xlib/ecore_x_window_prop.c
b/src/lib/ecore_x/xlib/ecore_x_window_prop.c
index 465a48c..151f65a 100644
--- a/src/lib/ecore_x/xlib/ecore_x_window_prop.c
+++ b/src/lib/ecore_x/xlib/ecore_x_window_prop.c
@@ -545,7 +545,7 @@ ecore_x_window_prop_property_get(Ecore_X_Window win,
if (_ecore_xlib_sync) ecore_x_sync();
if (ret != Success)
return 0;
- if (!num_ret)
+ if ((!num_ret) || (size_ret <= 0))
{
XFree(prop_ret);
return 0;
--
