zmike pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=d1bc3ea258d64a698e9868698e0382ad2b182ca7
commit d1bc3ea258d64a698e9868698e0382ad2b182ca7 Author: Mike Blumenkrantz <zm...@samsung.com> Date: Thu May 30 13:10:53 2019 -0400 elm/fileselector_button: null fileselector model pointer on delete Summary: the data for this object may be further referenced during deletion after this point without triggering errors, so ensure that pointers which are accessible with api functions do not persist after deletion @fix Depends on D8985 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8986 --- src/lib/elementary/elc_fileselector_button.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/lib/elementary/elc_fileselector_button.c b/src/lib/elementary/elc_fileselector_button.c index df7259e09c..5e10e83063 100644 --- a/src/lib/elementary/elc_fileselector_button.c +++ b/src/lib/elementary/elc_fileselector_button.c @@ -243,8 +243,7 @@ _elm_fileselector_button_efl_canvas_group_group_add(Eo *obj, Elm_Fileselector_Bu EOLIAN static void _elm_fileselector_button_efl_canvas_group_group_del(Eo *obj, Elm_Fileselector_Button_Data *sd) { - if (sd->fsd.model) - efl_unref(sd->fsd.model); + efl_replace(&sd->fsd.model, NULL); eina_stringshare_del(sd->window_title); eina_stringshare_del(sd->fsd.path); if (sd->fsd.selection) --