[EGIT] [core/efl] master 05/05: tests: Use efl_unref() on duplicated event objects

[Jean-Philippe ANDRÉ]

jpeg pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=ce8460406813f2205afe0cf7dde6cd412e1140be

commit ce8460406813f2205afe0cf7dde6cd412e1140be
Author: Jean-Philippe Andre <jp.an...@samsung.com>
Date:   Thu Sep 28 16:50:53 2017 +0900

    tests: Use efl_unref() on duplicated event objects
    
    efl_del() is valid but bindings such as C++ should be using efl_unref()
    and not efl_del() in this situation: a reference was given, so it should
    be released.
---
 src/bin/elementary/test_events.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/src/bin/elementary/test_events.c b/src/bin/elementary/test_events.c
index 36fa0a0719..c6a3ca5a0e 100644
--- a/src/bin/elementary/test_events.c
+++ b/src/bin/elementary/test_events.c
@@ -21,7 +21,7 @@ _pointer_down(void *data, const Efl_Event *ev)
 {
    testdata *td = data;
    td->down = 1;
-   efl_del(td->evdown);
+   efl_unref(td->evdown);
    td->evdown = efl_input_dup(ev->info);
 }
 
@@ -29,7 +29,7 @@ static void
 _pointer_move(void *data, const Efl_Event *ev)
 {
    testdata *td = data;
-   efl_del(td->evmove);
+   efl_unref(td->evmove);
    td->evmove = efl_input_dup(ev->info);
 }
 
@@ -38,7 +38,7 @@ _pointer_up(void *data, const Efl_Event *ev)
 {
    testdata *td = data;
    td->down = 0;
-   efl_del(td->evup);
+   efl_unref(td->evup);
    td->evup = efl_input_dup(ev->info);
 }
 
@@ -63,7 +63,7 @@ _key_down(void *data, const Efl_Event *ev)
 
    if (!efl_input_fake_get(ev->info))
      {
-        efl_del(td->evkeydown);
+        efl_unref(td->evkeydown);
         td->evkeydown = efl_input_dup(ev->info);
      }
 }
@@ -83,7 +83,7 @@ _key_up(void *data, const Efl_Event *ev)
 
    if (!efl_input_fake_get(ev->info))
      {
-        efl_del(td->evkeyup);
+        efl_unref(td->evkeyup);
         td->evkeyup = efl_input_dup(ev->info);
      }
 
@@ -131,8 +131,8 @@ _clicked_button2(void *data, const Efl_Event *ev 
EINA_UNUSED)
      {
         efl_event_callback_call(td->win, EFL_EVENT_KEY_DOWN, td->evkeydown);
         efl_event_callback_call(td->win, EFL_EVENT_KEY_UP, td->evkeyup);
-        efl_del(td->evkeydown);
-        efl_del(td->evkeyup);
+        efl_unref(td->evkeydown);
+        efl_unref(td->evkeyup);
         td->evkeydown = NULL;
         td->evkeyup = NULL;
      }
@@ -142,11 +142,11 @@ static void
 _win_del(void *data, const Efl_Event *ev EINA_UNUSED)
 {
    testdata *td = data;
-   efl_del(td->evdown);
-   efl_del(td->evup);
-   efl_del(td->evmove);
-   efl_del(td->evkeydown);
-   efl_del(td->evkeyup);
+   efl_unref(td->evdown);
+   efl_unref(td->evup);
+   efl_unref(td->evmove);
+   efl_unref(td->evkeydown);
+   efl_unref(td->evkeyup);
    free(td);
 }
 

--