Hello, Few comments on the patch.
- Any reason why you commented out a bunch of the tests? - Should use const for the char * parameters. - if this does the same thing as the custom label, i'd be preferable to just use the custom label stuff instead of creating all new routines. - if you have a format of %3$.0lf%% how can you write 4 differnt thigns into it? or are you depending on that just being ignored since it isn't used? Thats pretty nasty behaviour, in my opinion. dan > Hello! > > While playing with some progressbars, I found myself dreaming about > some missing features... So I coded them :p > > - First I added a char *label_format to struct Ewl_Progressbar, it is > set to "%3$.0lf%%" at initialization, to keep the default percentage > mode, as I changed label arguments to value, range, value/range*100, > range-value, (range-value)/range*100 (there shouldn't be anything that > could be useful missing now :p). > - ewl_progressbar_label_get: retrieves current label value > - ewl_progressbar_label_format_set: sets the default label format, so > that we don't have to call ewl_progressbar_custom_label_set at each > value update, that's a hassle less :) > - ewl_progressbar_label_format_get: do I have to explain what it's > supposed to do ;D > - ewl_progressbar_default_label_set: resets the label format to its > initial value, so "%3$.0lf%%" (maybe this name is not as good) > - some cosmetic changes (english error corrections) > > - correction of default (winter) theme where the bottom of the > progressbar (the 'done' part) was not shown > > Hope this is bugless (;D) and helpful... > > Cheers! > > -- > ilLogict > > Etudiant:1A, E.S.I.A.L., Nancy, France > Student: Y1, E.S.I.A.L., Nancy, France > Website: http://illogict.online.fr > E-Mail: [EMAIL PROTECTED] > ICQ: #74274856 > AIM: illogict > MSN: [EMAIL PROTECTED] > Yahoo: illogict > Jabber: [EMAIL PROTECTED] > Mobile: +33 6 81921083 > Message: Enlightenment DR17 oune ! Et honte à ceux qui ne sont pas d'accord ! > Message: Enlightenment DR17 rocks! Shame on whoever doesn't agree! > ------------------------------------------------------- This SF.Net email is sponsored by: NEC IT Guy Games. How far can you shotput a projector? How fast can you ride your desk chair down the office luge track? If you want to score the big prize, get to know the little guy. Play to win an NEC 61" plasma display: http://www.necitguy.com/?r _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
