Re: [E-devel] [patch] elm_genlist - bugfix evas_object_del at selected callback

2011-08-03 Thread Daniel Juyung Seo
Great. evas_object_ref/unref is a good idea. Thanks raster! Daniel Juyung Seo (SeoZ) On Wed, Aug 3, 2011 at 2:41 PM, Carsten Haitzler wrote: > On Tue, 02 Aug 2011 19:06:21 +0900 Hyoyoung Chang > said: > >> Dear developers. >> >> This patch is about elm_genlist. >> When a user delete genlist obj

Re: [E-devel] E SVN: tasn IN trunk/elementary/data/themes: . widgets

2011-08-03 Thread Daniel Juyung Seo
Raster was the only one who disagreed with this idea. So break him! Anyway we made it :) Daniel Juyung Seo (SeoZ) On Wed, Aug 3, 2011 at 3:25 PM, Tom Hacohen wrote: > On 03/08/11 03:50, Jihoon Kim wrote: >> Tom, wow, awesome job! >> I also have thought default.edc should be split into each widg

[E-devel] [PATCH] mutex lock is not released in error cases in eina_share_common functions

2011-08-03 Thread Myungjae Lee
Hello, all. In error cases, such as node is NULL in eina_share_common_del function mutex lock is not released when the function returns and this can cause infinite loop. Please review this patch and apply it if it is acceptable. Thanks. eina_share_common.c.patch Description: Binary d

Re: [E-devel] [PATCH] mutex lock is not released in error cases in eina_share_common functions

2011-08-03 Thread Cedric BAIL
On Wed, Aug 3, 2011 at 1:24 PM, Myungjae Lee wrote: > Hello, all. > > In error cases, such as node is NULL in eina_share_common_del function mutex > lock is not released when the function returns and this can cause infinite > loop. > > Please review this patch and apply it if it is acceptable. Th

Re: [E-devel] [patch] elm_genlist - bugfix evas_object_del at selected callback

2011-08-03 Thread Hyoyoung Chang
I know that apis but I don't know how much it's useful. Thanks And I attached refined version of this patch. > -Original Message- > From: Carsten Haitzler (The Rasterman) [mailto:ras...@rasterman.com] > Sent: Wednesday, August 03, 2011 2:41 PM > To: Enlightenment developer list > Cc: Hyoy

[E-devel] [patch] elm_widget - elm_widget_type_unregister

2011-08-03 Thread Hyoyoung Chang
Dear developers. This patch is adding a api to elm_widget. In elm_widget, there is an api to register widget type to elementary's own list. However it doesn't provide unregister api. So I made this patch. Most of case, it's not needed. But in some case, it's useful. (such as elm objects in DSO, i

Re: [E-devel] [patch] elm_genlist - bugfix evas_object_del at selected callback

2011-08-03 Thread The Rasterman
On Thu, 04 Aug 2011 14:46:23 +0900 Hyoyoung Chang said: well evas_object_ref() and unref() keep and object from being deleted until all the refs have been removed, so it avoids the deletion problem there. you can do ref at start of func and unref at every exit point meaning that obj will delay de