Re: Questions on Map and Set based on SpiderMonkey implementation

2012-01-23 Thread Sam Tobin-Hochstadt
On Mon, Jan 23, 2012 at 9:23 AM, Rick Waldron wrote: > On Mon, Jan 23, 2012 at 8:53 AM, Sam Tobin-Hochstadt > wrote: >> >> On Mon, Jan 23, 2012 at 5:19 AM, Andreas Rossberg >> wrote: >> > On 22 January 2012 18:52, David Bruant wrote: >> >> >> >> SpiderMonkey implementation landed today. I was l

Re: Questions on Map and Set based on SpiderMonkey implementation

2012-01-23 Thread Rick Waldron
On Mon, Jan 23, 2012 at 8:53 AM, Sam Tobin-Hochstadt wrote: > On Mon, Jan 23, 2012 at 5:19 AM, Andreas Rossberg > wrote: > > On 22 January 2012 18:52, David Bruant wrote: > >> > >> SpiderMonkey implementation landed today. I was looking over the commit > >> [1] and had a question. > >> There is

Re: Questions on Map and Set based on SpiderMonkey implementation

2012-01-23 Thread Sam Tobin-Hochstadt
On Mon, Jan 23, 2012 at 5:19 AM, Andreas Rossberg wrote: > On 22 January 2012 18:52, David Bruant wrote: >> >> SpiderMonkey implementation landed today. I was looking over the commit >> [1] and had a question. >> There is a test: >> >> assertEq(Object.prototype.toString.call(new Map), "[object Ma

Re: Questions on Map and Set based on SpiderMonkey implementation

2012-01-23 Thread Andreas Rossberg
On 22 January 2012 18:52, David Bruant wrote: > > SpiderMonkey implementation landed today. I was looking over the commit > [1] and had a question. > There is a test: > > assertEq(Object.prototype.toString.call(new Map), "[object Map]"); FWIW, V8 behaves the same. It's not in the spec yet, but it

Re: Questions on Map and Set based on SpiderMonkey implementation

2012-01-22 Thread Andrea Giammarchi
random thoughts: it still looks weird to me to prefix undefined and null with "object", plus there is no undefined [[class]], neither Null one so despite the good intention, I believe null, NaN, and undefined, should return "[not an object]" as well as primitives should return "[primitive String]"

Re: Questions on Map and Set based on SpiderMonkey implementation

2012-01-22 Thread Herby Vojčík
David Bruant wrote: Hi, SpiderMonkey implementation landed today. I was looking over the commit [1] and had a question. There is a test: assertEq(Object.prototype.toString.call(new Map), "[object Map]"); I can't see anything about it neither in the latest spec draft nor in the wiki proposal. I

Questions on Map and Set based on SpiderMonkey implementation

2012-01-22 Thread David Bruant
Hi, SpiderMonkey implementation landed today. I was looking over the commit [1] and had a question. There is a test: assertEq(Object.prototype.toString.call(new Map), "[object Map]"); I can't see anything about it neither in the latest spec draft nor in the wiki proposal. Is it how Object.protot