Re: [Evolution-hackers] Largefile support

2008-04-15 Thread Milan Crha
On Mon, 2008-04-07 at 14:23 -0400, Jeffrey Stedfast wrote: > On Mon, 2008-04-07 at 13:29 -0400, Matthew Barnes wrote: > > On Mon, 2008-04-07 at 12:43 -0400, Jeffrey Stedfast wrote: > > > The only 'gotcha' I can think of by enabling it by default is that it > > > might break ABI if old builds were

Re: [Evolution-hackers] Largefile support

2008-04-07 Thread Srinivasa Ragavan
On Mon, 2008-04-07 at 13:29 -0400, Matthew Barnes wrote: > On Mon, 2008-04-07 at 12:43 -0400, Jeffrey Stedfast wrote: > > The only 'gotcha' I can think of by enabling it by default is that it > > might break ABI if old builds were 32bit off_t's (the new off_t's would > > be 64bit). > > > > Oh, a

Re: [Evolution-hackers] Largefile support

2008-04-07 Thread Jeffrey Stedfast
On Mon, 2008-04-07 at 13:29 -0400, Matthew Barnes wrote: > On Mon, 2008-04-07 at 12:43 -0400, Jeffrey Stedfast wrote: > > The only 'gotcha' I can think of by enabling it by default is that it > > might break ABI if old builds were 32bit off_t's (the new off_t's would > > be 64bit). > > > > Oh,

Re: [Evolution-hackers] Largefile support

2008-04-07 Thread Matthew Barnes
On Mon, 2008-04-07 at 12:43 -0400, Jeffrey Stedfast wrote: > The only 'gotcha' I can think of by enabling it by default is that it > might break ABI if old builds were 32bit off_t's (the new off_t's would > be 64bit). > Oh, and fwiw, looking ahead, it may even be worth changing the public > API

Re: [Evolution-hackers] Largefile support

2008-04-07 Thread Jeffrey Stedfast
Oh, and fwiw, looking ahead, it may even be worth changing the public API to take goffset's rather than off_t's if breaking API is acceptable since it will prevent future off_t size issues (since I believe that goffset is supposed to be an int64_t) Jeff On Mon, 2008-04-07 at 12:35 -0400, Jeffrey

Re: [Evolution-hackers] Largefile support

2008-04-07 Thread Jeffrey Stedfast
I meant to keep it with the same defaults as before... did I goof? :( The only 'gotcha' I can think of by enabling it by default is that it might break ABI if old builds were 32bit off_t's (the new off_t's would be 64bit). I think the best coarse of action is to default it to the same off_t size

[Evolution-hackers] Largefile support

2008-04-07 Thread Matthew Barnes
On Mon, 2008-04-07 at 17:11 +0100, [EMAIL PROTECTED] wrote: > Author: fejj > Date: Mon Apr 7 17:11:40 2008 > New Revision: 8625 > URL: http://svn.gnome.org/viewvc/evolution-data-server?rev=8625&view=rev > > Log: > 2008-04-07 Jeffrey Stedfast <[EMAIL PROTECTED]> > > * configure.in: Do pro