[Evolution-hackers] Composer #14333 (was Re: [Evolution-patches] Cut & Paste in mailer.)

[Radek Doulík]

On Pá, 2001-11-02 at 00:33, NotZed wrote:

Check out the number of identical attachments to this message !

20, all same content, all same content-id.

OK, I have filled a bug report (#14333) and attached diff should fix it. I am CC-ing Larry as he know this code.

Best wishes
Radek

Radek Doulík [EMAIL PROTECTED] Hacker Monkey Ximian, Inc.

Index: ChangeLog
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvs/gnome/evolution/composer/ChangeLog,v
retrieving revision 1.346
diff -u -p -r1.346 ChangeLog
--- ChangeLog   2001/10/31 04:40:29     1.346
+++ ChangeLog   2001/11/02 10:12:01
@@ -1,3 +1,8 @@
+2001-11-02  Radek Doulik  <[EMAIL PROTECTED]>
+
+       * e-msg-composer.c (add_inlined_images): use hash table to
+       eliminate duplicates
+
 2001-10-30  Dan Winship  <[EMAIL PROTECTED]>
=20
        * e-msg-composer.c (build_message): Add back the "remove
Index: e-msg-composer.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvs/gnome/evolution/composer/e-msg-composer.c,v
retrieving revision 1.242
diff -u -p -r1.242 e-msg-composer.c
--- e-msg-composer.c    2001/10/31 04:40:29     1.242
+++ e-msg-composer.c    2001/11/02 10:12:02
@@ -271,13 +271,19 @@ static void
 add_inlined_images (EMsgComposer *composer, CamelMultipart *multipart)
 {
        GList *d =3D composer->current_images;
+       GHashTable *added;
=20
+       added =3D g_hash_table_new (g_direct_hash, g_direct_equal);
        while (d) {
                CamelMimePart *part =3D d->data;
=20
-               camel_multipart_add_part (multipart, part);     =09
+               if (!g_hash_table_lookup (added, part)) {
+                       camel_multipart_add_part (multipart, part);
+                       g_hash_table_insert (added, part, part);
+               }
                d =3D d->next;
        }
+       g_hash_table_destroy (added);
 }
=20
 /* This functions builds a CamelMimeMessage for the message that the user =
has