Re: [ewg] [PATCH]mlx4_ib XRC RCV: Fix mlx4_ib_reg_xrc_rcv_qp() locking

2011-02-16 Thread Jack Morgenstein
You are correct! Good catch. We will add this to OFED. (P.S., I would rather leave irqsave -- it is used everywhere else for this spinlock). -Jack On Monday 14 February 2011 09:32, sebastien dugue wrote: Resending to the proper ML (sorry). In mlx4_ib_reg_xrc_rcv_qp(), we need to

Re: [ewg] [PATCH]mlx4_ib XRC RCV: Fix mlx4_ib_reg_xrc_rcv_qp() locking

2011-02-16 Thread Jack Morgenstein
On Wednesday 16 February 2011 15:02, sebastien dugue wrote:   Also, one thing I noticed in that same function: why allocate ctx_entry before knowing if it's going to be of any use? The allocation could be done right before the first use. I did it just to gather all the error returns at

Re: [ewg] [PATCH] node description patch

2010-06-03 Thread Jack Morgenstein
On Tuesday 01 June 2010 17:04, Mike Heinz wrote: +            logger -i Set node_desc for ${hca}: ${NODE_DESC_HOSTNAME} HCA-\${hca_id} +            echo -n ${NODE_DESC_HOSTNAME} HCA-${hca_id} ${sysdir}/${hca}/node_desc I don't see NODE_DESC_HOSTNAME defined anywhere. Don't you need a

Re: [ewg] OFED 1.5 beta status

2009-09-15 Thread Jack Morgenstein
, but this error occurs when I tried to install all packages. However, an HPC installation succeeded., Thanks Pradeep, prad...@us.ibm.com Jack Morgenstein

[ewg] RHEL5.4 backport

2009-09-15 Thread Jack Morgenstein
I've just committed RHEL5.4 backports for: core uverbs mlx4 mthca Still to go: ipoib(me), sdp, qib, cxgb3, iw_nes. (Please try to get these done in a timely manner). Also, I have not yet taken the genalloc patch and its associated file genalloc.c under kernel_addons. (Steve, you are the

Re: [ewg] OFED 1.5 beta status

2009-09-13 Thread Jack Morgenstein
On Friday 11 September 2009 11:00, Alexander Schmidt wrote: On Thu, 10 Sep 2009 18:18:46 -0500 Jon Mason j...@opengridcomputing.com wrote: I believe this will break compilation on x86_64, but I will verify. It seems to compile fine, go ahead and commit it. Thanks, Jon

Re: [ewg] OFED 1.5 beta status

2009-09-13 Thread Jack Morgenstein
On Thursday 10 September 2009 19:11, Alexander Schmidt wrote: The following change fixes the issue for me, and it did not break other parts of the stack, could someone review this? Thanks Index: ofa_kernel-1.5/kernel_addons/backport/2.6.27_sles11/include/linux/cpumask.h

[ewg] [PATCH] sdp: incorrect SDP_FMR_SIZE on 32-bit machines

2009-08-30 Thread Jack Morgenstein
on a single page -- with the result that the fmr pool allocation failed at driver startup. Signed-off-by: Jack Morgenstein ja...@dev.mellanox.co.il --- Amir, Please take care of this. Index: ofed_kernel-fixes/drivers/infiniband/ulp/sdp/sdp.h

[ewg] [PATCH] sdp: check if sdp device is actually present in sdp_remove_one

2009-08-30 Thread Jack Morgenstein
-- and this must be tested for -- or we will get a kernel Oops for a NULL pointer dereference. Signed-off-by: Jack Morgenstein ja...@dev.mellanox.co.il --- Amir, Please take care of this. Index: ofed_kernel-fixes/drivers/infiniband/ulp/sdp/sdp_main.c

Re: [ewg] OFED-1.5: build problem with mthca

2009-07-27 Thread Jack Morgenstein
Unfortunately, we do not have SLES11 installed on any ppc64 machines here as yet. You could try writing a kernel app which includes asm/topology.h and see if you experience the same problem. -Jack On Friday 24 July 2009 16:11, Alexander Schmidt wrote: I'm using the stock SLES11 gcc

[ewg] Re: Compile error on 7/14 daily build of OFED-1.5

2009-07-27 Thread Jack Morgenstein
Jon, Please investigate this -- you added the asm/bitops.h backport file in your commit: commit 3ff95fad45ee5aca5caf6bd78f9bf8c75e424d82 Author: Jon Mason j...@opengridcomputing.com Date: Wed Jul 1 18:13:16 2009 +0300 NFSRDMA: NFS backport for RHEL5.3 This patch provides the NFS

Re: [ewg] [Patch mthca backport] Don't use kmalloc 128k

2009-07-23 Thread Jack Morgenstein
On Thursday 16 July 2009 21:08, Doug Ledford wrote: On rhel4 and rhel5 machines, the kmalloc implementation does not automatically forward kmalloc requests 128kb to __get_free_pages. Please include this patch in all rhel4 and rhel5 backport directories so that we do the right thing in

Re: [ewg] OFED-1.5: build problem with mthca

2009-07-22 Thread Jack Morgenstein
Your compiler seems to be choking on the __init keyword in the kernel installation's asm/topology.h file. I do not know why. The kernel_addons/.../cpumask.h file simply has a line #include asm/topology.h, which should not be causing problems. Problem line: extern void __init

Re: [ewg] Today's daily build (7/20) does not compile on EL5.3

2009-07-21 Thread Jack Morgenstein
We fixed this last night. Thanks for reporting it, though -- we don't always catch these problems immediately (this one was for kernels 2.6.19 and earlier). It is fixed in daily build http://www.openfabrics.org/downloads/OFED/ofed-1.5-daily/OFED-1.5-20090721-0038.tgz -Jack On Monday 20 July

Re: [ewg] Compile error on 7/14 daily build of OFED-1.5

2009-07-16 Thread Jack Morgenstein
Culprit is /var/tmp/OFED_topdir/BUILD/ofa_kernel-1.5/kernel_addons/backport/2.6.18-EL5.3/include/linux/log2.h This file assumed that there was no native include/linux/log2.h -- which is incorrect in RHEL5.2 and 5.3 I'll fix now. Vlad should be taking this commit (from my clone) on Sunday. If

Re: [ewg] Compile error on 7/14 daily build of OFED-1.5

2009-07-16 Thread Jack Morgenstein
On Thursday 16 July 2009 17:19, Jack Morgenstein wrote: I'll fix now.  Vlad should be taking this commit (from my clone) on Sunday. Vlad just took the fix. The daily is being built right now (with the fix). -Jack ___ ewg mailing list ewg

[ewg] Wish to remove local sa patches from OFED 1.5

2009-07-12 Thread Jack Morgenstein
. Thanks! Jack Morgenstein Mellanox ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

[ewg] Re: [GIT PULL OFED-1.5] NFSRDMA bugfix

2009-07-09 Thread Jack Morgenstein
Done (Pulled into OFED 1.5). -Jack On Thursday 09 July 2009 02:23, Jon Mason wrote: Hey Jack, Please pull from ssh://ja...@sofa.openfabrics.org/home/jon/scm/ofed_kernel-1.5.git dev I have run the build script on sofa, and I did not see any issues. It contains the following patch:

Re: [ewg] mlx4 and ibv_devinfo discrepancy?

2009-07-08 Thread Jack Morgenstein
Pradeep, There is no one-to-one connection between an **infiniband** port being active, and an **IPoIB** port being up. The Infiniband port active means that its logical link is up, and it can send and receive packets from its wire interface. For example, if you run the ibv_ud_pingpong

[ewg] Re: [GIT PULL OFED-1.5] NFSRDMA SLES10sp2 backport

2009-07-07 Thread Jack Morgenstein
Done. -Jack On Tuesday 07 July 2009 02:18, Jon Mason wrote: Hey Jack, Please pull from ssh://ja...@sofa.openfabrics.org/home/jon/scm/ofed_kernel-1.5.git dev I have run the build script on sofa, and I did not see any issues. It contains the following patches: commit

[ewg] Re: [GIT PULL OFED-1.5] NFSRDMA 2.6.22 backport and patches for RHEL5

2009-07-06 Thread Jack Morgenstein
Checked and pulled. Using sofa works fine -- I did not see any issues when I compiled. Thanks, Jon! -Jack On Monday 06 July 2009 06:37, Jon Mason wrote: Hey Jack, Please pull from ssh://ja...@sofa.openfabrics.org/home/jon/scm/ofed_kernel-1.5.git 0703 I have run the build script on

[ewg] Re: [PATCH OFED-1.5] NFSRDMA: NFS backport for RHEL5.2

2009-07-01 Thread Jack Morgenstein
On Friday 19 June 2009 19:12, Jon Mason wrote: This patch provides the NFS backport for RHEL5.2. It passes Connectathon as a client and server over TCP and RDMA. Signed-Off-By: Jon Mason j...@opengridcomputing.com Thanks. I fixed the set_cpus_allowed issue as discussed in the thread,

Re: [ewg] Re: [PATCH OFED-1.5] NFSRDMA: NFS backport for 2.6.22

2009-07-01 Thread Jack Morgenstein
Any progress on the 2.6.25 and 2.6.22 backports? -Jack On Thursday 25 June 2009 19:08, Jon Mason wrote: On Thu, Jun 25, 2009 at 10:43:02AM -0500, Jon Mason wrote: On Thu, Jun 25, 2009 at 04:23:13PM +0300, Jack Morgenstein wrote: On Friday 19 June 2009 19:14, Jon Mason wrote: This patch

Re: [ewg] Re: [PATCH OFED-1.5] NFSRDMA: NFS backport for 2.6.22

2009-06-27 Thread Jack Morgenstein
On Thursday 25 June 2009 19:08, Jon Mason wrote: # ./ofed_scripts/ofed_makedist.sh # scp ofed_kernel-2.6.22.tgz  r...@vic12: The kernel source is now on my victim system On the victim: # tar -xzvf ofed_kernel-2.6.22.tgz # cd ofed_kernel-2.6.22 # ./configure --with-core-mod

[ewg] Re: [PATCH OFED-1.5] NFSRDMA: NFS backport for 2.6.22

2009-06-25 Thread Jack Morgenstein
On Friday 19 June 2009 19:14, Jon Mason wrote: This patch provides the NFS backport for 2.6.22. It passes Connectathon as a client and server over TCP and RDMA. Signed-Off-By: Jon Mason j...@opengridcomputing.com This patch fails compilation on the 2.6.22 kernel, as follows:

[ewg] OFED 1.5 Problem on ia64 with your kernel_addons/backport/2.6.22/bitops.h

2009-06-18 Thread Jack Morgenstein
Jon, The commit below added file kernel_addons/backport/2.6.22/bitops.h. On ia64, we get the following error in the OFED 1.5 build (from e-mail: [ofa-general] ofa_1_5_kernel 20090618-0200 daily build status): Build failed on ia64 with linux-2.6.22 Log: from

Re: [ewg] [PATCH OFED-1.5] NFSRDMA: NFS backport for RHEL5.2 (update)

2009-06-16 Thread Jack Morgenstein
On Friday 12 June 2009 00:13, Jon Mason wrote: his patch provides the NFS backport for RHEL5.2. It passes Connectathon as a client and server over TCP and RDMA. Signed-Off-By: Jon Mason j...@opengridcomputing.com --- This patch contains bug fixes found in the previous version Jon, This

Re: [ewg] [PATCH OFED-1.5] NFSRDMA: NFS backport for RHEL5.3 (update)

2009-06-16 Thread Jack Morgenstein
On Friday 12 June 2009 00:12, Jon Mason wrote: This patch provides the NFS backport for RHEL5.3. It passes Connectathon as a client and server over TCP and RDMA. Signed-Off-By: Jon Mason j...@opengridcomputing.com --- This patch contains bug fixes found in the previous version Jon,

Re: [ewg] [PATCH OFED-1.5] Move RHEL5.1 backports to attic

2009-06-16 Thread Jack Morgenstein
On Thursday 11 June 2009 23:48, Jon Mason wrote: The RHEL5.1 backports are legacy patches from the OFED 1.4 build, and do not apply cleanly to the 2.6.30 kernel.  Move them to the attic so they can be referenced for their historical value but no longer interfere with the OFED 1.5 build.

[ewg] Re: [PATCH OFED-1.5] nfsrdma: Fix SLES11 compile error

2009-06-16 Thread Jack Morgenstein
Vlad, Jon, I'll add this one. -Jack On Tuesday 16 June 2009 22:40, Jon Mason wrote: The 2.6.20 kernel update broke the SLES11 backport for NFSRDMA. This is due to the deactivate_locked_super not being defined. The patch below defines it to be what existed there before. With this patch

Re: [ewg] [PATCH OFED-1.5] NFSRDMA: NFS backport for 2.6.22

2009-06-15 Thread Jack Morgenstein
Jon, The transition to kernel 2.6.30-rc8 evidently caused this patch to break in 2 places (files dir.c and super.c). I've indicated the problem below (conflict between patch and base code). Please fix and resend. Thanks! -Jack On Wednesday 03 June 2009 02:41, Jon Mason wrote: This patch

Re: [ewg] OFED 1.5 backport of 2.6.22 mthca broken

2009-06-04 Thread Jack Morgenstein
We are now committing the fix for this (was a wrong include_next in the kernel_addons). Will be fixed in Today's build. -Jack On Wednesday 03 June 2009 02:45, Jon Mason wrote: When building the OFED 1.5 kernel on the 2.6.22 kernel, I get the following error. Is anyone else seeing this

Re: [ewg] [PATCH] RHEL5 backport crypto.h and scatterlist.h cleanup

2009-05-06 Thread Jack Morgenstein
On Wednesday 06 May 2009 18:45, Jon Mason wrote: Lustre is getting a struct redeinfition due to its declaration in the Lustre header files as well as in the RHEL5 backports. Fortunately, OFED can avoid defining the struct all together, as it already exists in the base kernel's header files in

Re: [ewg] [PATCH] ipoib: disable napi while cq is being drained

2009-04-21 Thread Jack Morgenstein
On Friday 17 April 2009 18:26, Yossi Etigin wrote: -   ipoib_dbg(priv, bringing up interface\n); - --  if (!test_and_set_bit(IPOIB_FLAG_ADMIN_UP, priv-flags)) --  napi_enable(priv-napi); -+  set_bit(IPOIB_FLAG_ADMIN_UP, priv-flags); - -   if

Re: [ewg] [GIT PULL] RDMA/nes: update copyright to new legal entity

2008-12-01 Thread Jack Morgenstein
On Thursday 27 November 2008 19:10, Tung, Chien Tin wrote: Vlad, Please pull RDMA/nes update for OFED 1.4: git://git.openfabrics.org/~ctung/ofed-1.4.git ofed_kernel There is only one commit c91850b32187f9269de1df20134f329754c2f51a and it updates the copyright, no code change.

Re: [ewg] [PATCH 1/2 v2]libibvers: add create_qp_expanded

2008-08-13 Thread Jack Morgenstein
On Tuesday 12 August 2008 22:37, Roland Dreier wrote: Sorry for jumping in so late in the process, but a few big concerns: struct ibv_qp *ibv_create_qp_expanded(struct ibv_pd *pd, struct ibv_qp_init_attr *qp_init_attr,

[ewg] Re: Patches for OFED 1.4 beta

2008-08-12 Thread Jack Morgenstein
On Tuesday 12 August 2008 16:39, Olga Shern wrote: Hi Vlad,   Please add the attached patches (in emails) to OFED 1.4 beta. These patches should be applied after Jack's XRC patches.   Please also send the librdmacm patch -- We'll open a librdmacm library git for ofed_1_4 on the

[ewg] Re: [ofa-general] soft lockup in the kernel mad layer

2008-07-01 Thread Jack Morgenstein
On Tuesday 01 July 2008 12:44, Or Gerlitz wrote: Or Gerlitz wrote: doing some tests against some nodes with new HCA firmware (connectx FW 2.5) which seems to be very slow responding on node info queries, I think that I have stepped on a bug/s in the kernel mad code The IB bits used on

Re: [ewg] RE: [ofa-general] OFED Jan 14 meeting summary on RC2readiness

2008-01-18 Thread Jack Morgenstein
On Friday 18 January 2008 03:25, Roland Dreier wrote: I guess you mean just implement XRC without allowing multiple processes to share an XRC domain?  That actually seems like a sensible thing to implement as well... This is part of the current XRC implementation -- just give -1 as the fd

[ewg] Re: [ofa-general] OFED 1.3 Beta release is available

2007-12-17 Thread Jack Morgenstein
On Monday 17 December 2007 17:35, Tang, Changqing wrote: I remembered someone else suggested to use: struct ibv_context { struct ibv_device *device; struct ibv_context_ops ops; int cmd_fd; int async_fd;

[ewg] Re: [ofa-general] OFED 1.3 Beta release is available

2007-12-16 Thread Jack Morgenstein
On Wednesday 05 December 2007 17:45, Tang, Changqing wrote: I think the only alternative we have to preserve backwards compatibility is to leave struct ibv_context_ops alone and change the structure to: struct ibv_context {         struct ibv_device      *device;         struct

Re: [ewg] Re: [ofa-general] OFED 1.3 Beta release is available

2007-12-05 Thread Jack Morgenstein
On Wednesday 05 December 2007 07:24, Roland Dreier wrote: I think the only alternative we have to preserve backwards compatibility is to leave struct ibv_context_ops alone and change the structure to: struct ibv_context { struct ibv_device *device; struct

Re: [ewg] Re: [ofa-general] OFED 1.3 Beta release is available

2007-12-05 Thread Jack Morgenstein
On Wednesday 05 December 2007 02:40, Roland Dreier wrote: BTW, sifting through the OFED 1.3 libibverbs tree, I do see that the commit to add max_xrc_domains to struct ibv_device_attr did break things by adding the member in the middle of the structure (so that an app compiled against the old

Re: [ewg] Re: [ofa-general] OFED 1.3 Beta release is available

2007-12-05 Thread Jack Morgenstein
On Wednesday 05 December 2007 21:59, Tang, Changqing wrote: There are some other input structure changes such as ibv_qp_init_attr, if the qp_type is not IBV_QPT_XRC, the field xrc_domain is not touched, right ? Right. Similar thing for struct ibv_send_wr xrc_remote_srq_num field. Same

[ewg] RE: dmesg spammed by a print from the XRC patches

2007-11-06 Thread Jack Morgenstein
Was fixed on Oct 31. -Original Message- From: Or Gerlitz [mailto:[EMAIL PROTECTED] Sent: Thursday, November 01, 2007 9:28 AM To: Jack Morgenstein Cc: ewg@lists.openfabrics.org Subject: dmesg spammed by a print from the XRC patches Hi Jack, With OFED 1.3, the printk below

Re: [ewg] [PATCH 8/8 warnings] sdp_bcopy.c warning

2007-10-25 Thread Jack Morgenstein
Jeremy, Why did you remove the likely and unlikely macros? Isn't the compiler warning just on the missing != NULL ? - Jack On Saturday 06 October 2007 01:48, Jeremy Brown wrote: Tziporet, Vlad, I've included the eighth of the eight warning fix patches. Thanks! Jeremy Brown ---